Archived
1
0
Commit Graph

388 Commits

Author SHA1 Message Date
Dan Helfman
3da951b0ba Fixed an Internet Explorer bug in which backspace sometimes didn't work, such as when backspacing an empty list element. 2008-12-03 16:27:01 -08:00
Dan Helfman
033833b00b Link pulldowns opened via mouse hovering will now disappear when the mouse is moved away. 2008-12-03 15:42:08 -08:00
Dan Helfman
929d27035a Changed the "new note" key from ctrl-N to ctrl-M so as not to conflict with the "new browser window" key used in most web browsers. 2008-12-03 15:11:49 -08:00
Dan Helfman
0b2b0ec69e Fixed a rare Chrome/Safari bug in which pressing backspace sometimes made the text cursor vanish. 2008-12-03 14:50:53 -08:00
Dan Helfman
6e52384d46 Fixed a bug that prevented deleted notes from being displayed within the trash. 2008-11-24 16:58:59 -08:00
Dan Helfman
54744dd3a9 Fixed a rare bug in which Luminotes sometimes indicated that the current note was saved even when it wasn't.
Fortunately, this was just a visual bug, and the current note was always saved correctly.

The reproduction steps were:

 1. Open two notes, A and B.
 2. Modify note A, and then switch to note B. This causes note A to save.
 3. The save happens to take a long time (which you can force with a sleep).
 4. While the save is executing, quickly modifiy note B.
 5. When the original save completes, the "save" button changes to "saved",
    even though note B has been modified and is not saved.

The solution was simply to check whether the focused note is dirty before changing to a "saved" button.
2008-11-21 12:56:06 -08:00
Dan Helfman
3c11526480 Fixed a bug that prevented the autosaver from working on non-forum notebooks. 2008-11-20 17:39:20 -08:00
Dan Helfman
7a3da18fe0 Typo fix. 2008-11-17 22:59:57 -08:00
Dan Helfman
9dec0ae991 Fixed a bug in which the storage usage area was trying to be accessed even if it wasn't present. 2008-11-17 14:45:10 -08:00
Dan Helfman
4dc93c230b In several places, UI now looks at notebook forum tag instead of READ_WRITE_FOR_OWN_NOTES permissions of notebook. 2008-11-17 13:33:21 -08:00
Dan Helfman
968266079c Fixed a visual bug in which undoing the deletion of a note didn't always make the note reappear, even though the undeletion always worked. 2008-11-14 17:01:55 -08:00
Dan Helfman
e7038bfb1f You can now add an existing note directly to the note tree, instead of having to click "options" -> "show on startup". 2008-11-14 16:51:35 -08:00
Dan Helfman
45c40a44af Helpful <title> text on add-note-to-note-tree note name field. 2008-11-14 15:41:18 -08:00
Dan Helfman
68de634b38 Rearranged the links on the left and right side of the wiki editing page. Added an "add note to note tree" button that's not quite complete. 2008-11-14 12:34:06 -08:00
Dan Helfman
69987e08d9 Emphasizing that signing up for an account in order to post in the forums is free. 2008-11-12 15:21:40 -08:00
Dan Helfman
f632e109cd No longer displaying annoying warning messages about Safari/Chrome support being considered "beta". 2008-11-11 22:38:53 -08:00
Dan Helfman
25b2f2fe84 Added permalinks to blog and discussion forum posts. 2008-11-10 12:32:52 -08:00
Dan Helfman
5b556d03cf Fixed a bug in which autosave did not cause the "notes" and "recent updates" links to rename if necessary. 2008-11-05 16:13:26 -08:00
Dan Helfman
23bff4d6b2 For forum threads, redirect from /notebooks/... URLs to corresponding /forums/... URLs. 2008-10-31 15:55:08 -07:00
Dan Helfman
dccab45de3 The username of the author of a forum post now shows up in the UI. 2008-10-30 16:53:42 -07:00
Dan Helfman
c636850cf0 Some code to tack on a byline to all notes with a creation timestamp, and then remove that byline when you focus a note to edit it. 2008-10-30 16:16:26 -07:00
Dan Helfman
b4a40d2c25 More work on the discussion forums. 2008-10-30 15:26:27 -07:00
Dan Helfman
bce99c26bc New forum thread creation code, plus a re-working of URLs under "/forums/" 2008-10-28 14:07:49 -07:00
Dan Helfman
d1e257a4c2 Fixed typo. 2008-10-27 16:34:12 -07:00
Dan Helfman
21a05befe0 More forum-specific stuff. 2008-10-27 16:23:27 -07:00
Dan Helfman
388f2fcb02 Foundational work for both tags and discussion forums. Should have checked this in in smaller pieces. 2008-10-24 11:51:19 -07:00
Dan Helfman
5310a6916b Magic number to make Safari put links in the right location. 2008-10-08 23:44:25 -07:00
Dan Helfman
489cc08783 Safari/Chrome: Uploading files now works reliably instead of just once. Apparently WebKit caches iframe src URLs! 2008-10-08 17:09:13 -07:00
Dan Helfman
a1ffcfb9b8 Safari/Chrome: Pulldowns on inline images are now positioned correctly. 2008-10-08 14:56:01 -07:00
Dan Helfman
bd0fc7b461 Adding a beta support message for Chrome and Safari. 2008-10-07 16:52:05 -07:00
Dan Helfman
8c7f05801c Modified the WebKit pulldown positioning code so that changes and options pulldowns show up in the correct location. 2008-10-07 14:52:32 -07:00
Dan Helfman
abd5a2a189 Pulldowns for search suggestions, importing, and exporting now show up. Worked around yet another WebKit bug/misfeature. 2008-10-06 17:56:41 -07:00
Dan Helfman
0d371cc490 Remove Safari/Chrome warning message, since hopefully they'll be supported by the time this release is done. 2008-10-06 15:47:19 -07:00
Dan Helfman
fc925a36f8 Changing debugging display of note contents as HTML to use display_message() instead of alert(). 2008-10-02 23:02:08 -07:00
Dan Helfman
2e5ec59c2b Changed the warning about Safari/Chrome/Opera incompatibility to be an in-page message instead of a popup alert so as to be slightly less obnoxious. 2008-09-30 12:58:39 -07:00
Dan Helfman
80a0250c95 Fixed a bug in which clicking the "export" link when the current note was unsaved did not open the export pulldown. 2008-09-29 23:09:44 -07:00
Dan Helfman
968ef22bc4 Implemented CSV exporting, and improved CSV importing to better handle the exported CSV files.
Importing still needs work on properly handling internal note links.
2008-09-17 23:39:11 -07:00
Dan Helfman
c8e910b43a Made it clearer when reverting a note what's going on. Now opening the reverted note if it's not yet open, or highlighting it if it is open. 2008-09-08 15:44:24 -07:00
Dan Helfman
e06579c881 In the revision changes pulldown, no longer showing "by desktopuser" in Luminotes Desktop. 2008-09-08 15:29:16 -07:00
Dan Helfman
c5b916885a When clearing pulldowns, preventing use of pulldown div if it has no pulldown member. 2008-08-13 13:02:07 -07:00
Dan Helfman
c6dbeffc10 Fixed a bug in which the character encoding of uploaded CSV files was not properly detected and used to decode the file.
Note that this fix introduces a new dependency: http://chardet.feedparser.org/ found in the python-chardet package.
2008-08-11 22:53:01 -07:00
Dan Helfman
e844091cdc "There isn't a title column." -> "There is no title column." 2008-08-09 01:05:12 -07:00
Dan Helfman
52f129e571 New notebook import feature for importing notes from a CSV file. (Beta.)
Uses existing file upload mechanism with slightly modified UI to upload the file.
Then there's new CSV parsing code to parse the CSV and import it as a new notebook.
Still need a few more unit tests before this feature can be considered complete.
2008-08-08 16:39:53 -07:00
Dan Helfman
b7e07fbc72 Fixed a bug in which renaming a link title and then pressing ctrl-L would replace the link destination. 2008-08-01 15:50:49 -07:00
Dan Helfman
9fed61aae1 Skipping clearing of messages/errors if they haven't been open long enough to read. 2008-07-31 15:50:25 -07:00
Dan Helfman
17b49b404c Increased speed of note hiding animations. 2008-07-30 20:38:20 -07:00
Dan Helfman
a6bbf04dad Fairly large CSS overhaul with the goal of making both the left and right areas position: fixed;
Still works in IE 6 and 7. And of course Firefox. Even appears visually okay in Safari.
2008-07-30 16:49:50 -07:00
Dan Helfman
066ffdb308 Fixed bug where if you click on a (non-dirty) note, add a character, remove the character, and then click the save button, nothing happened.
Now, if save_editor() decides there's no need to actually save the focused note to the server, it disabled the save button as if a save occurred.
2008-07-29 19:05:34 -07:00
Dan Helfman
ac5c8f6174 By popular demand, added a "save" button that becomes grayed out when everything is saved. 2008-07-29 16:38:35 -07:00
Dan Helfman
953bc5360d On second thought, making scrolling speed even faster (0.25 seconds in duration). 2008-07-29 14:52:23 -07:00
Dan Helfman
3a4030fee5 When scrolling to and then highlighting a note, do so serially instead of in parallel.
Also made speed of scrolling to a note or message slightly faster.
2008-07-29 14:48:54 -07:00
Dan Helfman
c74ff817c2 "Nothing but notes" mode now hides the toolbar as well. 2008-07-28 16:18:56 -07:00
Dan Helfman
d8c58e5f5d Fixed a bug where clicking the link for an updated note in an RSS feed did not properly redirect to that note after login. 2008-07-25 17:05:13 -07:00
Dan Helfman
9d2f0d344d When you invite other people to view or edit your notebook, you can now see the invite link they'll get. 2008-07-18 15:01:09 -07:00
Dan Helfman
f5f54738f3 Can now tab/shift-tab when suggest_pulldown is "open" but invisible. 2008-07-12 14:24:23 -07:00
Dan Helfman
7e519a202f Fixed a bug in which pressing tab/shift-tab when a suggest pulldown was open caused the current text to indent/outdent.
Now, tab/shift-tab only cause indent/outdent when there is no suggest pulldown.
2008-07-12 14:24:00 -07:00
Dan Helfman
1940929090 Wording change. 2008-07-11 17:12:52 -07:00
Dan Helfman
87d57ad7c1 ".. changes have overwritten changes made in another window by" message changed to support blank usernames (demo accounts). 2008-07-11 15:02:28 -07:00
Dan Helfman
a2c9cc2fa9 Display a different revert message if nothing was actually changed. 2008-07-11 14:45:20 -07:00
Dan Helfman
3153492086 Basic note reverting now works. 2008-07-11 14:41:48 -07:00
Dan Helfman
7f1a644a61 Possibly fixed a bug in which the displayed suggestions sometimes did not
reflect the most recent characters typed.
2008-07-07 15:49:01 -07:00
Dan Helfman
6ac620beb0 Fixed a bug in which clicking a note title suggestion from within the link info title field sometimes didn't update the link properly.
This was due to a race condition between the link info pulldown's
onblur/onchange handler and the suggestion onclick handler, both of which
tried to update the link, title, and summary at about the same time.
2008-07-07 15:38:16 -07:00
Dan Helfman
94b53832d5 Fixed bug in which tab/shift-tab for indending/outdenting nested lists no
longer worked, and in the process made it work in IE as well (which it
never has).
2008-07-03 16:56:17 -07:00
Dan Helfman
333e90459d Suggest-as-you-type now works for the search field as well. 2008-06-29 22:26:08 -07:00
Dan Helfman
e2d8fe8ae4 Selecting a suggestion within the link pulldown no longer causes Editor.end_link() to be called. 2008-06-29 20:38:37 -07:00
Dan Helfman
6163ee0f63 Added suggest-as-you-type feature to link pulldown's title field. 2008-06-29 20:32:13 -07:00
Dan Helfman
634b095177 When using custom backspace code in IE, don't require that we're in a
link. This means that if you're at the end of the link but not in link
mode, the custom backspace code is still used.
2008-06-29 15:25:09 -07:00
Dan Helfman
94647c4887 Backspacing at the end of a link in IE no longer ends the link.
Fixed a bug where typing a space within a link in IE caused the space to be added to the end of the link.
2008-06-29 15:19:59 -07:00
Dan Helfman
7e9a5171f3 Factored out some Suggest_pulldown up/down/ handler stuff to separate functions. 2008-06-29 13:53:49 -07:00
Dan Helfman
3951d147b3 Now can use tab and shift-tab in Suggest_pulldown, as alternative to down and up keys. 2008-06-29 13:13:20 -07:00
Dan Helfman
fe139cc749 First pass for suggest-as-you-type for linking. 2008-06-27 16:11:09 -07:00
Dan Helfman
599971ba01 When linking to a note by title, the note resolution is now
case-insensitive instead of case-sensitive.
2008-06-25 20:04:06 -07:00
Dan Helfman
708de3b7e7 Reorganized and renamed some notebook links on the right side of the page. 2008-06-23 12:56:03 -07:00
Dan Helfman
cf7cdefd28 Replaced "add new notebook" link with new notebook button next to
"notebooks" heading.
2008-06-21 22:13:52 -07:00
Dan Helfman
41a85bb41f You can now resize embedded images (small, medium, or large).
Fixed a bug that potentially caused link pulldowns to open in the wrong
location when the page was scrolled past the top.
2008-06-18 17:14:07 -07:00
Dan Helfman
f7626d985c Fixed a bug that caused image files to get deleted if there were multiple images embedded within a single note.
Prevented a link pulldown from auto-opening by hovering if another pulldown is already open.
2008-06-16 16:22:50 -07:00
Dan Helfman
cfc1c18a55 Tweaked the popup positioning code to prevent popups from getting smashed into the right side of the page. Removed (broken) images from downloaded HTML. 2008-06-16 15:07:17 -07:00
Dan Helfman
4bbebc4400 Fixed display of image justification controls IE. Made justification default back to left when unchecking embed checkbox. 2008-06-16 13:42:52 -07:00
Dan Helfman
dbf9dda2a0 Can now left, center, or right justify embedded images. 2008-06-13 23:26:48 -07:00
Dan Helfman
522f8b9330 Implemented support for embedded images within wiki notes. Also added hover support to open link pulldowns. 2008-06-13 15:55:19 -07:00
Dan Helfman
51ccb41fd0 Fix for a bug in which "toolbar/small/undefined_button.png" was being loaded from the login page.
The solution is to bail from update_toolbar() on read-only notebooks.
2008-06-09 13:32:27 -07:00
71a3b29709 When not a member of any groups, show that as an indented div instead of a list item. 2008-06-06 14:49:28 -07:00
a8a6070da0 Implemented controller.users.signup_group_member().
Modified UI code to call this method correctly and display results.
Split generic user signup functionality out into a separate private method.
2008-06-06 14:46:29 -07:00
0e51e461fa New controller.Users.remove_group() method to remove a user's group membership. 2008-06-03 20:19:07 -07:00
32d160d6eb Fleshed out more of the group admin UI. 2008-06-03 16:12:35 -07:00
32e6828c90 Completed basic group user listing. This includes a new group admin settings note. 2008-06-02 19:53:39 -07:00
23f0cbe781 Fixed broken account settings form submission. 2008-06-02 14:19:34 -07:00
cf10cf8c82 Refactored some of the client-side form-handling code to cut down on
special-case hacks.
2008-06-02 14:16:35 -07:00
3f2c51e338 Fixed mouse click handling brokenness introduced by 03b6a15e86e1. Also Beginning to phase out special-case hack for form submission. 2008-05-30 17:10:57 -07:00
79fe7245b6 Removing comma to make IE happy. 2008-05-30 15:48:02 -07:00
3c96f6ba8f Displaying group membership with (non-working) links for each group with admin access. 2008-05-30 15:25:12 -07:00
df3d170362 View groups that you're a member of, with an indicatation if you're an admin of that group.
- modify controller.Users.current() to return the user's groups
    - update test_current() unit tests to expect empty groups list in results
  - modify Main_page, Notebook_rss, Front_page, Tour_page, and Upgrade_page to accept a new groups parameter
    - Main_page should add it as a hidden HTML variable
  - update Wiki.js to read the hidden groups variable and display the groups in account settings
2008-05-28 16:05:38 -07:00
Dan Helfman
694dc2eaba Removed key binding for title button (ctrl-T), since it was interfering
with tab opening in Firefox.
2008-05-27 13:38:10 -07:00
Dan Helfman
ca61369963 Fix for bug where read-write notebooks that the anonymous user had
read-only access to would show up as read-only, even when logged in.
2008-05-20 00:51:23 -07:00
Dan Helfman
02a3544590 Search result now return notes from multiple notebooks.
- change model.Notebook.sql_search_notes() to be a static method
   - take a first_notebook_id argument and a user_id argument
   - join user_notebook on notebook_id and matches on user_notebook.user_id instead of notebook_id
   - order by notebook_id = first_notebook desc, rank instead of just rank
   - include search result for notebooks readable by anonymous user, but only if such a notebook is given as first_notebook_id
 - update code that calls model.Notebook.sql_search_notes()
 - update model.Note.to_dict() to include notebook_id
 - modify Wiki.display_search_results()
   - separate search results for the current notebook and results for all other notebooks
   - indicate which notebook each result is from
   - if there are results in other notebooks but no results in the current notebook, indicate that clearly
   - when you click on a result note link in the current notebook, it should simply open a new note
   - when you click on a result note link in another notebook, it should open in a new window
 - test in IE
 - update unit tests for:
   - controller.Notebooks.search()
   - model.Notebook.sql_search_notes()
   - model.Note.to_dict()
2008-05-19 15:16:25 -07:00
Dan Helfman
8389eae2e5 Expanded workaround for IE iframe positioning bug to include IE 7 and not just 6. 2008-05-18 01:43:20 -07:00
Dan Helfman
99c32fa120 Improved the detection of whether an existing note has been altered.
* Using the browser's tweaked version of the initial HTML, instead of the HTML that we tell the browser to use.
 * Improved normalize_html() function to handle more cases.
 * Added start_dirty flag to Editor() constructor and made use of it for completely new notes.
2008-05-18 01:07:15 -07:00
Dan Helfman
8f08927692 Fixed a bug where the toolbar didn't auto-resize if there were no
notes open.
2008-05-14 08:00:51 +00:00
Dan Helfman
507e8412da New strikethrough toolbar button. 2008-05-14 00:07:02 +00:00
Dan Helfman
c9814075fa Added timed autosave. 2008-05-13 22:52:20 +00:00