witten
/
luminotes
Archived
1
0
Fork 0
Code Releases Activity

When scrolling to and then highlighting a note, do so serially instead of in parallel. 

Also made speed of scrolling to a note or message slightly faster.
This commit is contained in:
Dan Helfman 2008-07-29 14:48:54 -07:00
parent d56710bf78
commit 3a4030fee5
3 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
NEWS
View File

@ -1,3 +1,9 @@
1.4.19:
* When scrolling to and then highlighting a note, do so serially instead of
in parallel.
* Made speed of scrolling to a note or message slightly faster.
* Removed big yellow "sign up for free" box from the sign up page itself.
1.4.18: July 28, 2008:
* Fixed a bug where clicking the link for an updated note in an RSS feed did
not properly redirect to that note after login.

28
static/js/Editor.js
View File

@ -214,22 +214,30 @@ Editor.prototype.highlight = function ( scroll ) {
if ( scroll == undefined )
scroll = true;
var self = this;
function do_highlight() {
if ( /Opera/.test( navigator.userAgent ) ) { // MochiKit's Highlight for iframes is broken in Opera
pulsate( self.iframe, options = { "pulses": 1, "duration": 0.5 } );
} else if ( self.iframe.contentDocument ) { // browsers such as Firefox
Highlight( self.iframe, options = { "queue": { "scope": "highlight", "limit": 1 } } );
} else { // browsers such as IE
if ( self.document && self.document.body )
Highlight( self.document.body, options = { "queue": { "scope": "highlight", "limit": 1 } } );
}
}
if ( scroll ) {
// if the editor is already completely on-screen, then there's no need to scroll
var viewport_position = getViewportPosition();
if ( getElementPosition( this.note_controls ).y < viewport_position.y ||
getElementPosition( this.iframe ).y + getElementDimensions( this.iframe ).h > viewport_position.y + getViewportDimensions().h )
new ScrollTo( this.note_controls );
getElementPosition( this.iframe ).y + getElementDimensions( this.iframe ).h > viewport_position.y + getViewportDimensions().h ) {
new ScrollTo( this.note_controls, { "afterFinish": do_highlight, "duration": 0.5 } );
return;
}
}
if ( /Opera/.test( navigator.userAgent ) ) { // MochiKit's Highlight for iframes is broken in Opera
pulsate( this.iframe, options = { "pulses": 1, "duration": 0.5 } );
} else if ( this.iframe.contentDocument ) { // browsers such as Firefox
Highlight( this.iframe, options = { "queue": { "scope": "highlight", "limit": 1 } } );
} else { // browsers such as IE
if ( this.document && this.document.body )
Highlight( this.document.body, options = { "queue": { "scope": "highlight", "limit": 1 } } );
}
do_highlight();
}
Editor.prototype.exec_command = function ( command, parameter ) {

2
static/js/Wiki.js
View File

@ -2287,7 +2287,7 @@ Wiki.prototype.scroll_to = function ( node ) {
var viewport_position = getViewportPosition();
if ( getElementPosition( node ).y < viewport_position.y ||
getElementPosition( node ).y + getElementDimensions( node ).h > viewport_position.y + getViewportDimensions().h )
new ScrollTo( node );
new ScrollTo( node, { "duration": 0.5 } );
}
Wiki.prototype.clear_messages = function () {