add list_options setting, fixes #306 #464
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#464
Loading…
Reference in New Issue
No description provided.
Delete Branch "nebulon42/borgmatic:306_list_options"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I have hit #306 so I added the proposed option.
This looks great! Thanks for taking the time to submit it. Would you like to take a stab at adding a unit test for this new feature or would prefer me to do it?
A good place to look at for an example would be:
tests/unit/hooks/test_mysql.py
, specifically the existingtest_dump_databases_runs_mysqldump_with_options()
test.I thought about unit tests, but then didn't look into it. I'll try.
Great! Let me know if I can help.
555e896a00
tob9c80516b6
b9c80516b6
to9ba7a0254f
I have added a unit test. Let me know if it is ok.
9ba7a0254f
to3729ba5ca3
Looks great, thank you so much!
Just released in borgmatic 1.5.21!
Great, thanks, I'll try it out.