move mysqldump options to the beginning of the command due to MySQL bug 30994. #470

nebulon42 · 2021-11-26T16:22:05Z

nebulon42 commented

2021-11-26 16:22:05 +00:00

I have added the new options flag for the list databases command to the beginning in #464 for the same reason but have forgot to do so for the mysqldump command.

Some options at mysql and mysqldump commands unfortunately need to be specified as the first option for them to work. See this 14 years old MySQL bug report. Due to the age of the report I don't expect it to be changed anytime soon so I'd like to move the options up in the command sequence. I hope that there are no side-effects but cannot really think of any.

I have added the new options flag for the list databases command to the beginning in #464 for the same reason but have forgot to do so for the mysqldump command. Some options at mysql and mysqldump commands unfortunately need to be specified as the first option for them to work. See this 14 years old [MySQL bug report](https://bugs.mysql.com/bug.php?id=30994). Due to the age of the report I don't expect it to be changed anytime soon so I'd like to move the options up in the command sequence. I hope that there are no side-effects but cannot really think of any.

nebulon42 added 1 commit 2021-11-26 16:22:06 +00:00

move mysqldump options to the beginning of the command due to MySQL bug 30994.

continuous-integration/drone/pr Build is passing

Details

c3e76585fc

witten commented

2021-11-29 20:06:44 +00:00

Awesome! Thanks for making this fix!

witten merged commit c6f47d4d56 into master

2021-11-29 20:09:00 +00:00

witten referenced this issue from a commit

2021-11-29 20:09:01 +00:00