borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

move mysqldump options to the beginning of the command due to MySQL bug 30994. #470

Merged
witten merged 1 commits from nebulon42/borgmatic:mysqldump_options into master 2021-11-29 20:09:00 +00:00
Conversation 2 Commits 1 Files Changed 2 +2 -2
nebulon42 commented 2021-11-26 16:22:05 +00:00
Contributor
Copy Link

I have added the new options flag for the list databases command to the beginning in #464 for the same reason but have forgot to do so for the mysqldump command.

Some options at mysql and mysqldump commands unfortunately need to be specified as the first option for them to work. See this 14 years old MySQL bug report. Due to the age of the report I don't expect it to be changed anytime soon so I'd like to move the options up in the command sequence. I hope that there are no side-effects but cannot really think of any.

I have added the new options flag for the list databases command to the beginning in #464 for the same reason but have forgot to do so for the mysqldump command. Some options at mysql and mysqldump commands unfortunately need to be specified as the first option for them to work. See this 14 years old [MySQL bug report](https://bugs.mysql.com/bug.php?id=30994). Due to the age of the report I don't expect it to be changed anytime soon so I'd like to move the options up in the command sequence. I hope that there are no side-effects but cannot really think of any.
nebulon42 added 1 commit 2021-11-26 16:22:06 +00:00
witten commented 2021-11-29 20:06:44 +00:00
Owner
Copy Link

Awesome! Thanks for making this fix!

Awesome! Thanks for making this fix!
witten merged commit c6f47d4d56 into master 2021-11-29 20:09:00 +00:00
witten commented 2022-01-05 04:24:19 +00:00
Owner
Copy Link

Just released in borgmatic 1.5.22!

Just released in borgmatic 1.5.22!
🎉 1
nebulon42 deleted branch mysqldump_options 2022-01-17 20:41:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#470
No description provided.
Delete Branch "nebulon42/borgmatic:mysqldump_options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?