borgmatic-collective
/
borgmatic
9
39
Fork 37
Code Issues 81 Pull Requests Packages Releases 94 Activity
Labels Milestones

move mysqldump options to the beginning of the command due to MySQL bug 30994. #470

Merged
witten merged 1 commits from nebulon42/borgmatic:mysqldump_options into master 9 months ago
Conversation 2 Commits 1 Files Changed 2
nebulon42 commented 9 months ago

I have added the new options flag for the list databases command to the beginning in #464 for the same reason but have forgot to do so for the mysqldump command.

Some options at mysql and mysqldump commands unfortunately need to be specified as the first option for them to work. See this 14 years old MySQL bug report. Due to the age of the report I don't expect it to be changed anytime soon so I'd like to move the options up in the command sequence. I hope that there are no side-effects but cannot really think of any.

I have added the new options flag for the list databases command to the beginning in #464 for the same reason but have forgot to do so for the mysqldump command. Some options at mysql and mysqldump commands unfortunately need to be specified as the first option for them to work. See this 14 years old [MySQL bug report](https://bugs.mysql.com/bug.php?id=30994). Due to the age of the report I don't expect it to be changed anytime soon so I'd like to move the options up in the command sequence. I hope that there are no side-effects but cannot really think of any.
nebulon42 added 1 commit 9 months ago
witten commented 9 months ago
Owner

Awesome! Thanks for making this fix!

Awesome! Thanks for making this fix!
witten merged commit c6f47d4d56 into master 9 months ago
witten commented 7 months ago
Owner

Just released in borgmatic 1.5.22!

Just released in borgmatic 1.5.22!
🎉 1
nebulon42 deleted branch mysqldump_options 7 months ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as c6f47d4d56.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug data loss design finalized question / support security waiting for response
No Label bug data loss design finalized question / support security waiting for response
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#470
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'nebulon42/borgmatic:mysqldump_options'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes