borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

add list_options setting, fixes #306 #464

Merged
witten merged 1 commits from nebulon42/borgmatic:306_list_options into master 2021-11-22 21:14:03 +00:00
Conversation 7 Commits 1 Files Changed 3 +27
nebulon42 commented 2021-11-12 19:51:13 +00:00
Contributor
Copy Link

I have hit #306 so I added the proposed option.

I have hit #306 so I added the proposed option.
witten commented 2021-11-15 19:13:05 +00:00
Owner
Copy Link

This looks great! Thanks for taking the time to submit it. Would you like to take a stab at adding a unit test for this new feature or would prefer me to do it?

A good place to look at for an example would be: tests/unit/hooks/test_mysql.py, specifically the existing test_dump_databases_runs_mysqldump_with_options() test.

This looks great! Thanks for taking the time to submit it. Would you like to take a stab at adding a unit test for this new feature or would prefer me to do it? A good place to look at for an example would be: `tests/unit/hooks/test_mysql.py`, specifically the existing `test_dump_databases_runs_mysqldump_with_options()` test.
nebulon42 commented 2021-11-18 19:45:18 +00:00
Author
Contributor
Copy Link

I thought about unit tests, but then didn't look into it. I'll try.

I thought about unit tests, but then didn't look into it. I'll try.
witten commented 2021-11-18 19:45:54 +00:00
Owner
Copy Link

Great! Let me know if I can help.

Great! Let me know if I can help.
👍 1
nebulon42 force-pushed 306_list_options from 555e896a00 to b9c80516b6 2021-11-20 14:31:46 +00:00 Compare
nebulon42 force-pushed 306_list_options from b9c80516b6 to 9ba7a0254f 2021-11-20 14:36:52 +00:00 Compare
nebulon42 commented 2021-11-20 14:39:44 +00:00
Author
Contributor
Copy Link

I have added a unit test. Let me know if it is ok.

I have added a unit test. Let me know if it is ok.
nebulon42 force-pushed 306_list_options from 9ba7a0254f to 3729ba5ca3 2021-11-20 14:44:10 +00:00 Compare
witten commented 2021-11-22 21:13:28 +00:00
Owner
Copy Link

Looks great, thank you so much!

Looks great, thank you so much!
witten merged commit bcc820d646 into master 2021-11-22 21:14:03 +00:00
witten commented 2021-11-22 21:20:55 +00:00
Owner
Copy Link

Just released in borgmatic 1.5.21!

Just released in borgmatic 1.5.21!
nebulon42 deleted branch 306_list_options 2021-11-22 21:31:48 +00:00
nebulon42 commented 2021-11-22 21:32:07 +00:00
Author
Contributor
Copy Link

Great, thanks, I'll try it out.

Great, thanks, I'll try it out.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#464
No description provided.
Delete Branch "nebulon42/borgmatic:306_list_options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?