borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

Also read .yml ending configuration files #180

Merged
witten merged 1 commits from :bugfix/detect-also-yml-file-endings into master 2019-05-19 21:16:25 +00:00
Conversation 2 Commits 1 Files Changed 2 +18 -2
decentral1se commented 2019-05-19 11:06:49 +00:00
Contributor
Copy Link

Closes witten/borgmatic#178.

I'm not exactly sure if I should also alter get_default_config_paths to show .yml file endings too? Or it should be left as is? I think this changes covers finding a config.yml as well (should the user want to do that).

Closes https://projects.torsion.org/witten/borgmatic/issues/178. I'm not exactly sure if I should also alter `get_default_config_paths` to show `.yml` file endings too? Or it should be left as is? I think this changes covers finding a `config.yml` as well (should the user want to do that).
witten commented 2019-05-19 21:12:54 +00:00
Owner
Copy Link

Thanks, this PR looks good. But I don't understand your question:

I’m not exactly sure if I should also alter get_default_config_paths to show .yml file endings too?

Based on the contents of your PR, it looks like get_default_config_paths() is already showing both .yaml and .yml file endings. So what else is there to do?

Thanks, this PR looks good. But I don't understand your question: > I’m not exactly sure if I should also alter get_default_config_paths to show .yml file endings too? Based on the contents of your PR, it looks like `get_default_config_paths()` is already showing both `.yaml` and `.yml` file endings. So what else is there to do?
witten commented 2019-05-19 21:14:51 +00:00
Owner
Copy Link

Nevermind, I was looking at the wrong function! I understand your question now. I don't think get_default_config_paths() requires any changes, because the full config.yaml paths are the defaults for borgmatic, and I don't see a need to also support (automatic) probing for alternate extensions for those canonical config files.

Nevermind, I was looking at the wrong function! I understand your question now. I don't think `get_default_config_paths()` requires any changes, because the full `config.yaml` paths are the defaults for borgmatic, and I don't see a need to also support (automatic) probing for alternate extensions for those canonical config files.
witten closed this pull request 2019-05-19 21:16:25 +00:00
decentral1se deleted branch bugfix/detect-also-yml-file-endings 2019-05-19 21:46:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#180
No description provided.
Delete Branch ":bugfix/detect-also-yml-file-endings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?