#178 Also read `.yml` file endings

Closed
opened 6 days ago by decentral1se · 4 comments

AFAICT, these don’t get picked up and AFAICT, they should :) A lot of tools that deal with YAML do both. I don’t know the history about this but this might be a bad experience for users who are used to being able to use these file endings types interchangeably.

AFAICT, these don't get picked up and AFAICT, they should :) A lot of tools that deal with YAML do both. I don't know the history about this but this might be a bad experience for users who are used to being able to use these file endings types interchangeably.
decentral1se commented 6 days ago
Poster

Can submit a PR if we’re all in agreement.

Can submit a PR if we're all in agreement.
witten commented 6 days ago
Owner

Can you say more or give some repro steps on where you’ll seeing .yml file endings not getting picked up? As far as I know, there’s nothing in the borgmatic code that even cares about the filename.. just the contents.

Thanks!

Can you say more or give some repro steps on where you'll seeing `.yml` file endings not getting picked up? As far as I know, there's nothing in the borgmatic code that even cares about the filename.. just the contents. Thanks!
witten commented 6 days ago
Owner

Oh, I think I found a spot that does care:

borgmatic/config/collect.py:46:
if full_filename.endswith('.yaml') and not os.path.isdir(full_filename):

A PR would be most welcome!

Oh, I think I found a spot that does care: ```python borgmatic/config/collect.py:46: if full_filename.endswith('.yaml') and not os.path.isdir(full_filename): ``` A PR would be most welcome!
witten added the
design finalized
label 5 days ago
witten added the
good first issue
label 5 days ago
witten commented 3 days ago
Owner

Thank you!

Thank you!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.