borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
15
60
Fork 43
Code Issues 59 Pull Requests Actions Packages Releases 123 Activity

[Feature] Add label variable interpolation in hook context #861

Closed
codimp wants to merge 5 commits from codimp/borgmatic:label-variable-interpolation-in-hook-context into main
pull from: codimp/borgmatic:label-variable-interpolation-in-hook-context
merge into: borgmatic-collective:main
Conversation 1 Commits 5 Files Changed 3 +5
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b36e11d3ca - Show all commits

5
borgmatic/commands/borgmatic.py
View File

@ -283,9 +283,14 @@ def run_actions(
'''
add_custom_log_levels()
repository_path = os.path.expanduser(repository['path'])
if 'label' in repository:
repository_label = repository['label']
else:
repository_label = ''
codimp marked this conversation as resolved Outdated
witten commented 2024-04-29 01:39:05 +00:00
Outdated
Review
Copy Link

You could simplify this all to just: repository_label = repository.get('label', '')

It could even be inline below without the temporary variable. (Do not feel strongly.)

You could simplify this all to just: `repository_label = repository.get('label', '')` It could even be inline below without the temporary variable. (Do not feel strongly.)
codimp commented 2024-04-29 08:39:11 +00:00
Outdated
Review
Copy Link

Good idea!

Good idea!
global_arguments = arguments['global']
dry_run_label = ' (dry run; not making any changes)' if global_arguments.dry_run else ''
hook_context = {
'label': repository_label,
'repository': repository_path,
# Deprecated: For backwards compatibility with borgmatic < 1.6.0.
'repositories': ','.join([repo['path'] for repo in config['repositories']]),