borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
58
Fork 42
Code Issues 59 Pull Requests 2 Actions Packages Releases 122 Activity

[Feature] Add label variable interpolation in hook context #861

Open
codimp wants to merge 5 commits from codimp/borgmatic:label-variable-interpolation-in-hook-context into main
pull from: codimp/borgmatic:label-variable-interpolation-in-hook-context
merge into: borgmatic-collective:main
Conversation 0 Commits 5 Files Changed 3 +11 -3
codimp commented 2024-04-28 23:03:28 +00:00
Contributor
Copy Link

Goal

  • Add label interpolation variable in hook context for current repository at runtime, like repository
# Goal - Add `label` interpolation variable in hook context for current repository at runtime, like `repository`
codimp added 3 commits 2024-04-28 23:03:28 +00:00
witten requested changes 2024-04-29 01:42:17 +00:00
witten left a comment
Owner
Copy Link

This looks great.. Thank you for doing it! Only a few minor comments below. Also, what do you think of adding a test that if a repository label is present, then it ends up in the hook context? You could model it after one of the existing tests, such as the one you updated.

This looks great.. Thank you for doing it! Only a few minor comments below. Also, what do you think of adding a test that if a repository label is present, then it ends up in the hook context? You could model it after one of the existing tests, such as the one you updated.
borgmatic/commands/borgmatic.py Outdated
@ -286,0 +286,4 @@
if 'label' in repository:
repository_label = repository['label']
else:
repository_label = ''
witten commented 2024-04-29 01:39:05 +00:00
Owner
Copy Link

You could simplify this all to just: repository_label = repository.get('label', '')

It could even be inline below without the temporary variable. (Do not feel strongly.)

You could simplify this all to just: `repository_label = repository.get('label', '')` It could even be inline below without the temporary variable. (Do not feel strongly.)
codimp commented 2024-04-29 08:39:11 +00:00
Author
Contributor
Copy Link

Good idea!

Good idea!
codimp marked this conversation as resolved
codimp added 1 commit 2024-04-29 08:38:28 +00:00
witten reviewed 2024-04-29 16:09:56 +00:00
docs/how-to/add-preparation-and-cleanup-steps-to-backups.md Outdated
@ -84,6 +84,8 @@ variables you can use here:
path of the borgmatic log file, only set when the `--log-file` flag is used
* `repository`: path of the current repository as configured in the current
borgmatic configuration file
* `label`: current repository label as configured in the current borgmatic
witten commented 2024-04-29 16:09:36 +00:00
Owner
Copy Link

Sorry, another thing I think I mentioned on IRC.. What do you think of calling this repository_label instead of just label?

Sorry, another thing I think I mentioned on IRC.. What do you think of calling this `repository_label` instead of just `label`?
codimp commented 2024-04-29 19:04:44 +00:00
Author
Contributor
Copy Link

oups, right, my bad!

oups, right, my bad!
codimp marked this conversation as resolved
codimp added 1 commit 2024-04-29 19:17:00 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b codimp-label-variable-interpolation-in-hook-context main
git pull label-variable-interpolation-in-hook-context

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff codimp-label-variable-interpolation-in-hook-context
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
witten
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#861
No description provided.
Delete Branch "codimp/borgmatic:label-variable-interpolation-in-hook-context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?