borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 41
Code Issues 55 Pull Requests 2 Actions Packages Releases 121 Activity

fix: use jsonschema<4.18 to support MSYS2 #809

Closed
debuglevel wants to merge 1 commits from debuglevel/borgmatic:feature-msys2 into main
pull from: debuglevel/borgmatic:feature-msys2
merge into: borgmatic-collective:main
Conversation 3 Commits 1 Files Changed 1 +1 -1
debuglevel commented 2024-01-03 23:34:01 +00:00
Contributor
Copy Link

jsonschema >=4.18 introduced rust dependencies which do not (yet) work on MSYS2.

jsonschema >=4.18 introduced rust dependencies which do not (yet) work on MSYS2.
debuglevel added 1 commit 2024-01-03 23:34:01 +00:00
f87f9cf8aa fix: use jsonschema<4.18 to support MSYS2 
jsonschema >=4.18 introduced rust dependencies which do not (yet) work on MSYS2.
debuglevel commented 2024-01-03 23:34:17 +00:00
Author
Contributor
Copy Link

See #778

See #778
witten commented 2024-01-04 17:30:43 +00:00
Owner
Copy Link

Thanks for taking the time to submit this! I understand the issue with Rust dependencies introduced in jsonschema (even if I don't understand the dev's rationale), but I'm not sold that we should cap the version of jsonschema in borgmatic for all users. In places where I've done that with borgmatic dependencies in the past, some users end up not being able to install borgmatic anymore when their distro stops including old versions of these dependencies.

As an alternative though, what about installing the "native" MSYS2 package for jsonschema before installing borgmatic? Would borgmatic then use that package? I'll note that, strangely, this native version is jsonschema 4.19. So somebody figured out how to get it to build on MSYS2!

Thanks for taking the time to submit this! I understand the issue with Rust dependencies introduced in jsonschema (even if I don't understand the dev's rationale), but I'm not sold that we should cap the version of jsonschema in borgmatic for all users. In places where I've done that with borgmatic dependencies in the past, some users end up not being able to install borgmatic anymore when their distro stops including old versions of these dependencies. As an alternative though, what about installing the "native" MSYS2 package for jsonschema before installing borgmatic? Would borgmatic then use that package? I'll note that, strangely, this native version is jsonschema 4.19. So somebody figured out how to get it to build on MSYS2!
witten commented 2024-03-12 04:19:11 +00:00
Owner
Copy Link

Closing this for now due to inactivity, but I'd be happy to revisit this if you're still game!

Closing this for now due to inactivity, but I'd be happy to revisit this if you're still game!
witten closed this pull request 2024-03-12 04:19:12 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#809
No description provided.
Delete Branch "debuglevel/borgmatic:feature-msys2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?