Update docs/how-to/backup-your-databases.md #806

axel · 2023-12-30T23:48:12Z

axel commented

2023-12-30 23:48:12 +00:00

Make it clearer that sqlite databases are dumped and therefore require as much extra disk space available than the target database takes. Not that this bit me or anything with a silly large 43 Gb sqlite database that shouldn't even exist in the first place.

axel added 1 commit 2023-12-30 23:48:13 +00:00

b1d3534d17 Update docs/how-to/backup-your-databases.md

Make it clearer that sqlite databases are dumped and therefore require as
much extra disk space available than the target database takes.

witten requested changes 2023-12-30 23:59:48 +00:00

witten left a comment

Thanks for doing this one as well. I actually don't think there's any good reason for the borgmatic SQLite hook to dump to an intermediate file. I'd be happy to merge this for now (after the requested capitalization changes!), but I've filed #807 to encompass the work of making SQLite dumps stream directly to Borg.

docs/how-to/backup-your-databases.md

						
				@ -65,0 +62,4 @@

				⚠️ The exceptions are the PostgreSQL/MongoDB "directory" dump formats, which 

				can't stream, as well as sqlite databases which are dumped. These therefore do 

				consume temporary disk space. (As much as the target database, for sqlite).

witten commented

2023-12-30 23:54:40 +00:00

In this line and the previous: "sqlite" -> "SQLite".

Edit: Also ")." -> ".)"

In this line and the previous: "sqlite" -> "SQLite". Edit: Also ")." -> ".)"

witten commented

2023-12-31 19:08:19 +00:00

Some good news and some bad news. The bad news is I implemented #807, so this PR is now out of date. The good news is I implemented #807, so SQLite dumps will no longer use an intermediate file and fill up your disk!

axel commented

2024-02-22 14:18:24 +00:00

Sorry, slow reply.
Ah ha, excellent. Well that just good news for everyone really (and the other piece of good news for me is that i no longer need to backup a 43 GB sqlite database, which is really a lot nicer).
I'll try to update the PR.

Sorry, slow reply. Ah ha, excellent. Well that just good news for everyone really (and the other piece of good news for me is that i no longer need to backup a 43 GB sqlite database, which is really a lot nicer). I'll try to update the PR.

👍 1

witten commented

2024-02-22 17:54:12 +00:00

Sounds good!