Fix escaped environment variable in configuration #549

essembeh · 2022-06-17T07:57:08Z

essembeh commented

2022-06-17 07:57:08 +00:00

when an env variable is escaped in the configuration file, we expect
not to resolve it and remove the escape char \

- when an env variable is escaped in the configuration file, we expect not to resolve it and remove the escape char `\`

essembeh added 1 commit 2022-06-17 07:57:09 +00:00

Fix escaped environment variable in configuration b63c854509

- when an env variable is escaped in the configuration file, we expect
  not to resolve it and remove the escape char `\`

essembeh referenced this pull request

2022-06-17 07:58:15 +00:00

Allow passing database password as environment variables. #546

witten reviewed 2022-06-23 17:14:41 +00:00

borgmatic/config/environment.py

						
				@@ -12,1 +12,3 @@

				    name, default = matcher.group("name"), matcher.group("default")

				    if matcher.group('escape') is not None:

				        # in case of escaped envvar, unescape it

				        return matcher.group('variable')

witten commented

2022-06-23 17:14:41 +00:00

There's a super edge case where an escaped \${FOO:-default} would not be treated properly, but probably not worth dealing with given how unlikely it is to occur in the wild.

There's a super edge case where an escaped `\${FOO:-default}` would not be treated properly, but probably not worth dealing with given how unlikely it is to occur in the wild.

witten merged commit c664c6b17b into master

2022-06-23 17:16:11 +00:00

witten referenced this issue from a commit

2022-06-23 17:16:12 +00:00

Fix escaped environment variable in configuration (#546).

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#549