Include systemd units in PyPI distribution #218

polyzen · 2019-09-22T01:15:59Z

polyzen commented

2019-09-22 01:15:59 +00:00

No description provided.

witten commented

2019-09-23 16:56:47 +00:00

Thanks for the PR! What's the intent here? I tried building a wheel of borgmatic with this change in place (pip wheel .), but I'm not seeing the sample directory end up in the resulting wheel (unzip ../borgmatic-1.3.18-py3-none-any.whl | grep sample).

Also, have you considered including all of the sample directory, so that the plain cron jobs samples end up in there as well?

Thanks for the PR! What's the intent here? I tried building a wheel of borgmatic with this change in place (`pip wheel .`), but I'm not seeing the `sample` directory end up in the resulting wheel (`unzip ../borgmatic-1.3.18-py3-none-any.whl | grep sample`). Also, have you considered including all of the `sample` directory, so that the plain cron jobs samples end up in there as well?

polyzen commented

2019-09-25 20:15:56 +00:00

Also, have you considered including all of the sample directory, so that the plain cron jobs samples end up in there as well?

I have, but I personally was only interested in the systemd units. I wasn't sure about distributing the Alpine-specific cron job, but I see you consolidated those.

Closing as you've already incorporated this change. :)

> Also, have you considered including all of the sample directory, so that the plain cron jobs samples end up in there as well? I have, but I personally was only interested in the systemd units. I wasn't sure about distributing the Alpine-specific cron job, but I see you consolidated those. Closing as you've already incorporated this change. :)

polyzen closed this pull request

2019-09-25 20:15:56 +00:00

polyzen commented

2019-09-25 20:15:56 +00:00

Also, have you considered including all of the sample directory, so that the plain cron jobs samples end up in there as well?

I have, but I personally was only interested in the systemd units. I wasn't sure about distributing the Alpine-specific cron job, but I see you consolidated those.

Closing as you've already incorporated this change. :)

> Also, have you considered including all of the sample directory, so that the plain cron jobs samples end up in there as well? I have, but I personally was only interested in the systemd units. I wasn't sure about distributing the Alpine-specific cron job, but I see you consolidated those. Closing as you've already incorporated this change. :)

polyzen deleted branch systemd-dist

2019-09-25 20:16:01 +00:00

witten commented

2019-09-25 23:24:14 +00:00

Oops, I didn't mean to commit that.. Was just trying it out. :) My bad.

polyzen commented

2019-09-26 00:16:31 +00:00

¯_(ツ)_/¯ Can confirm it works. Will be moving borgmatic into the Arch repos once pyKwalify tests pass with the latest pytest:
55ade28528 (commitcomment-35240099)

¯\_(ツ)_/¯ Can confirm it works. Will be moving borgmatic into the Arch repos once pyKwalify tests pass with the latest pytest: https://github.com/Grokzen/pykwalify/commit/55ade285287a05a2cebf8576407654ab2b8fc74c#commitcomment-35240099

witten commented

2019-09-26 02:00:00 +00:00

Cool!