--repository option for all subcommands #564

New Issue

Closed

opened 2022-07-21 21:39:06 +00:00 by eoli3n · 10 comments

eoli3n commented 2022-07-21 21:39:06 +00:00

Copy Link

--repository option should be directly under the borgmatic command, and not under specific subcommands.

It would allow to trigger any subcommand only on a specific repository.

``--repository`` option should be directly under the borgmatic command, and not under specific subcommands. It would allow to trigger any subcommand only on a specific repository.

witten commented 2022-08-29 00:52:03 +00:00

Owner

Copy Link

I've decided to add the --repository flag to individual borgmatic actions rather than as a global flag, because certain actions by their nature don't operate on a repository. For instance, borgmatic umount only operates on a mounted path. Additionally, I think it will help discoverability if --repository shows up in the help for individual actions.

Here are the actions that need --repository support added as part of this ticket:

• rcreate (formerly init)
• prune
• compact
• create
• check

I've decided to add the `--repository` flag to individual borgmatic actions rather than as a global flag, because certain actions by their nature don't operate on a repository. For instance, `borgmatic umount` only operates on a mounted path. Additionally, I think it will help discoverability if `--repository` shows up in the help for individual actions. Here are the actions that need `--repository` support added as part of this ticket: * [x] `rcreate` (formerly `init`) * [x] `prune` * [x] `compact` * [x] `create` * [x] `check`

👍 1

witten added the

good first issue

label 2023-02-04 17:13:25 +00:00

witten referenced this issue 2023-02-04 17:45:17 +00:00

check --repair for an specific repository #446

nain commented 2023-03-15 12:38:01 +00:00

Contributor

Copy Link

Status-check: Is rcreate already done?
I see it mentioned in the docs https://torsion.org/borgmatic/docs/reference/command-line/

Is it that it needs handling when there is no config file with the repository in it?

Status-check: Is rcreate already done? I see it mentioned in the docs https://torsion.org/borgmatic/docs/reference/command-line/ Is it that it needs handling when there is no config file with the repository in it?

nain commented 2023-03-15 14:53:52 +00:00

Contributor

Copy Link

I've been reading through the code figuring out an implementation.

2a36a2a312 suggests it's done for rcreate.

I can model the rest on it. (WIP)

I've been reading through the code figuring out an implementation. https://projects.torsion.org/borgmatic-collective/borgmatic/commit/2a36a2a312a140dae7ef84e6698d26014c5e2acd suggests it's done for rcreate. I can model the rest on it. (WIP)

nain referenced this issue 2023-03-15 16:53:02 +00:00

Add "--repository" flag to common actions (where it makes sense) #652

witten commented 2023-03-15 18:15:58 +00:00

Owner

Copy Link

Yeah, it's done for rcreate. This ticket would be adding it for all actions (that it makes sense on).

Yeah, it's done for `rcreate`. This ticket would be adding it for *all* actions (that it makes sense on).

👍 1

witten referenced this issue from a commit 2023-03-16 20:21:42 +00:00

Add "--repository" flag to the "prune" action

witten commented 2023-03-16 20:23:40 +00:00

Owner

Copy Link

Implemented by @nain in #652. Will be part of the next release!

Implemented by @nain in #652. Will be part of the next release!

👍 1

witten closed this issue 2023-03-16 20:23:41 +00:00

eoli3n commented 2023-03-16 20:26:45 +00:00

Author

Copy Link

thanks !

thanks !

witten referenced this issue from a commit 2023-03-16 20:27:32 +00:00

Add "--repository" flag to all actions where it makes sense (#564).

eoli3n commented 2023-03-16 20:27:46 +00:00

Author

Copy Link

hey, I forgot to talk about borgmatic list which should get --repository too

• list
• info

Already ok

hey, I forgot to talk about ``borgmatic list`` which should get ``--repository`` too - [x] list - [x] info Already ok

witten commented 2023-03-16 20:31:15 +00:00

Owner

Copy Link

Looks like those already have --repository flags according to --help...? Some of them have gotten added piecemeal over time. But please let us know if we missed anything else.

Looks like those already have `--repository` flags according to `--help`...? Some of them have gotten added piecemeal over time. But please let us know if we missed anything else.

eoli3n commented 2023-03-16 20:34:56 +00:00

Author

Copy Link

Yes, it does, tested and approved :)

Yes, it does, tested and approved :)

👍 1

witten commented 2023-03-16 20:55:03 +00:00

Owner

Copy Link

Just released in borgmatic 1.7.9!

Just released in borgmatic 1.7.9!

diivi referenced this issue 2023-03-21 19:37:07 +00:00

check --repair for an specific repository #446

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#564

No description provided.