Add "--repository" flag to common actions (where it makes sense) #652
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#652
Loading…
Reference in New Issue
No description provided.
Delete Branch "nain/borgmatic:repository-ticket-#564"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
ticket #564 prune action
Would like some feedback on this pull req.
Tried to implement --repository flag for prune action.
There is some complain by integration test though about " test_parse_arguments_disallows_repository_unless_action_consumes_it".
But we are consuming it in the action, so I don't understand why it's firing.
Help requested.
I did take care of the other (unit) test present and added new ones too, for this feature.
ftr: I'll get to the other ones (check, compact, create) when this one becomes clearer
This is great! I'd say you can just delete that failing test, now that
--repository
isn't expected to error for theprune
action any longer. Thanks! I'll have a look at the rest of the PR when I get a chance.9228994018
tocdbe6cdf3a
This looks great! I added one suggestion about combining a couple tests, but this looks ready to merge after that's resolved (one way or the other). Thank you!
@ -11,0 +26,4 @@
)
def test_run_prune_runs_with_no_explicit_repository():
I might suggest combining this test with the previous one, as (unless I'm missing something) their setups are identical besides
should_receive('execute_hook')
expectation.Done.
011a45d680
to480addd7ce
WIP: Add "--repository" flag to the "prune" actionto WIP: Add "--repository" flag to common actions (where it makes sense)WIP: Add "--repository" flag to common actions (where it makes sense)to Add "--repository" flag to common actions (where it makes sense)Everything looks great! I just merged it. Thanks again for your work here.