Archived
1
0
Commit Graph

605 Commits

Author SHA1 Message Date
Dan Helfman
78cac16bde Removing the byline whenever a note is saved so it doesn't accidentally get written to the database. 2009-02-16 13:41:11 -08:00
Dan Helfman
c2e3aae96a Luminotes now recognizes "mailto:" links as external links, so you can include links to email addresses within your notes. 2009-02-13 13:07:21 -08:00
Dan Helfman
a072564573 Fixed a bug in which a drag-and-dropped note occasionally didn't resize back to its original size. 2009-02-12 14:11:54 -08:00
Dan Helfman
38479d455a Fixed a bug in Internet Explorer in which opening a note by following a link didn't display the opened note correctly. (Missing table <tbody>.) 2009-02-12 14:03:54 -08:00
Dan Helfman
56b25bd1ff Re-added editor_focused( null ) in hide_editor() and delete_editor(), but now passing in a flag that prevents save_editor() from being double called. 2009-02-12 13:19:29 -08:00
Dan Helfman
403fda3590 Fixed a bug in which hiding a note could produce a spurious save conflict notification error.
The solution involves no longer calling Wiki.focused_editor( null ) in Wiki.hide_editor().
2009-02-12 03:38:14 -08:00
Dan Helfman
0b978c4f01 Fixed a bug in which moving a note and then clicking the "changes" tab on any other note failed to show that note's previous revisions. 2009-02-12 03:25:18 -08:00
Dan Helfman
38ddffd556 Fixed bugs related to the display and hiding of previous note revisions: Incorrect widths and no (invisible) note grabber. 2009-02-12 03:15:39 -08:00
Dan Helfman
0644b7e868 Mostly fixed note drag-and-drop in IE. 2009-02-11 01:05:00 -08:00
Dan Helfman
68e31f38be Got note drag-and-drop working in WebKit. 2009-02-11 00:46:37 -08:00
Dan Helfman
e366e324a7 Note tree link order now updates when notes are themselves reordered. 2009-02-10 22:08:42 -08:00
Dan Helfman
a8af8b3fb3 Fixed several edge cases with re-ranking notes during a reorder. Now updating several notes' ranks on every reorder instead of making successively more precise fractional ranks. 2009-02-10 17:05:03 -08:00
Dan Helfman
5446eeec5d No longer showing a grabber on a new note created within a forum. 2009-02-10 13:53:36 -08:00
Dan Helfman
c03c54026f Better interaction between empty notes and note reordering via dragging. 2009-02-10 02:17:28 -08:00
Dan Helfman
d0aa2614bc Properly handling hitting page-up at the top or page-down at the bottom of the notes. 2009-02-10 02:04:37 -08:00
Dan Helfman
3b335cca89 Don't display a note movement grabber when in a non-read-write notebook. 2009-02-10 02:00:15 -08:00
Dan Helfman
4f3267b0f4 Now note reordering is saved to the server. Still to do: New unit tests for reordering. Re-rank all notes in notebook when necessary. 2009-02-10 01:32:08 -08:00
Dan Helfman
0c01d9143f Note drag-and-drop no longer breaks page-up and page-down. 2009-02-09 17:37:58 -08:00
Dan Helfman
81a96915c4 Now also highlighting/focusing the editor even if the drag is canceled. 2009-02-09 17:18:18 -08:00
Dan Helfman
ec377a644a Now highlighting the hovered drop target and highlighting/focusing the dropped editor. 2009-02-09 17:09:37 -08:00
Dan Helfman
a35f62b51f Reordering notes works! Still needs to persist reordering to the server. 2009-02-09 17:03:13 -08:00
Dan Helfman
e31775e6de Only testing drag target hovering periodically, since it can be slow to do it constantly. 2009-02-09 16:24:45 -08:00
Dan Helfman
11b4af7568 Changed drop targets from boxes to just lines so as not to screw up drag positioning. Also added drop target before first note. 2009-02-09 15:01:44 -08:00
Dan Helfman
1cb6b87047 Now showing dashed-border drop targets between each note during a drag. 2009-02-09 14:35:52 -08:00
Dan Helfman
de8daa4892 Change dragging editor from "position: absolute" to "position fixed" and got drag-scrolling to work. 2009-02-06 23:56:36 -08:00
Dan Helfman
6bf81cd2cb A bit safer. 2009-02-06 15:01:46 -08:00
Dan Helfman
53b4aa571d Changed Editor.drop() not to disconnectAll( window ), since there are other non-drag-related signals connected to window. 2009-02-06 14:56:29 -08:00
Dan Helfman
c8a9b98599 The drop part of drag and drop works. Now I just need to add additional drop targets for actually moving the note. 2009-02-06 14:54:02 -08:00
Dan Helfman
e3e3fa93d5 Got note dragging working. Now I just need to imlement drop! 2009-02-06 14:01:44 -08:00
Dan Helfman
e358b0c2b6 Fixing blindUp in Editor.shutdown() to work with new holder table. 2009-02-04 23:45:19 -08:00
Dan Helfman
1f8694b1fe Moved grabber creation to existing note controls creation function and added "....." placeholder text to make IE display it. 2009-02-04 23:43:54 -08:00
Dan Helfman
3e8ae2dc23 Added grippy-surface area to the right of focused note for drag-and-drop of notes for reordering. Drag-and-drop still unimplemented. 2009-02-04 17:09:54 -08:00
Dan Helfman
47834ba541 Fixed a bug in which emptying the trash worked but produced a spurious error message. 2009-01-29 16:38:48 -08:00
Dan Helfman
b2648a037a Prevent UI from attempting to load undefined toolbar buttons when viewing the trash. 2009-01-29 16:21:11 -08:00
Dan Helfman
caaff7af59 Fixed a bug in which performing a search when search results were already open would just hide the initial search results without showing the new ones. 2009-01-29 15:52:11 -08:00
Dan Helfman
3fd6a5f941 Fixed a bug in which hiding a focused note could (temporarily) leave an empty gap at the bottom of the page. 2009-01-29 12:18:57 -08:00
Dan Helfman
06092cb3b0 Don't display a byline if there isn't any note text yet. 2009-01-27 19:35:49 -08:00
Dan Helfman
24210fc9f5 More fixes to page up / page down. This time, properly handles top and bottom notes. 2009-01-27 16:26:37 -08:00
Dan Helfman
b4b2443b8e Previous/next were completely backwards. 2009-01-27 16:17:24 -08:00
Dan Helfman
25db885cb8 Fix to prevent iframe editor from remaining focused when switching to a different static div editor with page up / page down. 2009-01-27 16:13:23 -08:00
Dan Helfman
5afee52199 Internet Explorer version 6, begone! 2009-01-27 15:54:11 -08:00
Dan Helfman
99e1a22f8b Fix typo. 2009-01-27 15:34:17 -08:00
Dan Helfman
025faae54e Updating the browser-not-supported error message. 2009-01-27 15:24:07 -08:00
Dan Helfman
dd7884c76c New keyboard shortcuts now work even when an editor isn't already focused. 2009-01-27 12:26:48 -08:00
Dan Helfman
fcb57dcc98 New keyboard shortcuts: Start a search: Ctrl-slash. Save the current note: Ctrl-space. 2009-01-27 12:07:02 -08:00
Dan Helfman
fdebb1061b New keyboard shortcuts for switching to next open note and previous open note: Page down and page up.
Also fixed visual bug that caused switching notes to flash when focusing.
The fix involved calling Editor.reposition() at the top of resize() instead of at the end.
2009-01-27 11:53:50 -08:00
Dan Helfman
941feb1dbf A non-ideal solution, but now repositioning iframe periodically after a resize in case the div its tracking has moved. 2009-01-27 01:32:21 -08:00
Dan Helfman
345022ac5a Fixed iframe cursor positioning in WebKit! 2009-01-26 22:03:59 -08:00
Dan Helfman
d22e521b74 Messages/errors with no given positioning are now by default positioned at the top of the notes (instead of the bottom). 2009-01-26 14:22:50 -08:00
Dan Helfman
4ac6eb6322 Fixed focusing when opening special notes like search results, settings, etc. 2009-01-26 14:17:54 -08:00
Dan Helfman
72b6a0f90c Fix for iframe cursor positioning not working in certain cases when clicking on a blank area of a static div. 2009-01-26 13:58:00 -08:00
Dan Helfman
683152fdaf Breaking out of loop earlier. 2009-01-26 13:30:26 -08:00
Dan Helfman
b207ca0747 Made byline into a <div> instead of a <p> and moved it to the bottom of the note instead of the top. 2009-01-26 13:18:34 -08:00
Dan Helfman
c1249fd0dc Fix forum bylines not showing up. 2009-01-26 12:34:33 -08:00
Dan Helfman
fb64838d48 Fixed ever-growing iframe editor width in IE6. 2009-01-26 12:15:27 -08:00
Dan Helfman
b0fcf355c9 Properly handle clicks on links within static divs. 2009-01-26 12:12:51 -08:00
Dan Helfman
5eb8311ab7 Fix for an edge case where the mouse is hovering over a link that's in an editor in the process of being coverted from an iframe to a div (in which hovering is ignored). 2009-01-24 23:59:23 -08:00
Dan Helfman
f841c17eeb Apparently 'node.tagName == "FOO"' will throw if tagName is undefined. 2009-01-24 23:56:28 -08:00
Dan Helfman
fa6c9dbc7b Fix: When a blank editor is open, and new note is clicked, just highlight that blank editor. 2009-01-24 23:48:10 -08:00
Dan Helfman
83e2db29f1 Hack to prevent iframe from being incorrectly positioned if there is a closing (and thus moving) message or error box. 2009-01-24 23:39:05 -08:00
Dan Helfman
4675c5969b Removing some code within display_error() that was preventing it from working. 2009-01-24 23:20:54 -08:00
Dan Helfman
9aa96d54a4 Fixing broken click handling in divs and iframes, thereby allowing form submission to work. 2009-01-24 23:20:34 -08:00
Dan Helfman
319477083c Fixed incorrect positioning of link pulldown and various other pulldowns. Also fixed opening of link pulldown via hovering. 2009-01-24 15:32:43 -08:00
Dan Helfman
366382dd20 Making cursor positioning work in WebKit, at least for positioning the cursor at the end of an iframe. 2009-01-24 15:13:44 -08:00
Dan Helfman
73e8ea878c Now only setting the shared iframe's <head> node once. Also fixed brief Firefox text selection flashing when selecting text in a div. 2009-01-24 14:21:07 -08:00
Dan Helfman
a4648981c7 Better range restoration when transitioning from a div to an iframe in IE. Also got rid of click_position, as it's no longer used. 2009-01-24 13:57:33 -08:00
Dan Helfman
42d4d514d2 Some typos and a range fix for IE. 2009-01-24 12:25:48 -08:00
Dan Helfman
3944ebc9d9 Removing obsolete comment. 2009-01-23 15:53:28 -08:00
Dan Helfman
f0fbd4e193 Fixed broken search form by making Editor handler connection only apply to forms within the Editor div itself. 2009-01-23 15:24:47 -08:00
Dan Helfman
5e67a87779 Fixed a bug in which hiding one div caused other divs to hide as well. Now using the note holder as the position_after variable. 2009-01-23 14:55:57 -08:00
Dan Helfman
4817f286bf Make invisible iframe have zero height as well, so it doesn't add blank space at the bottom of the page. 2009-01-23 14:49:03 -08:00
Dan Helfman
bdfc5d3740 Removing FIXME comment that was recently fixed. 2009-01-23 14:38:29 -08:00
Dan Helfman
8cd63ee661 Only adding black focused border to iframes, not static divs. 2009-01-23 14:36:12 -08:00
Dan Helfman
403ce9d305 Fixed cursor positioning at the end of an iframe's text to work in more edge cases. 2009-01-23 14:25:24 -08:00
Dan Helfman
5e7cd17e82 Fix for range start/end not being propagated to iframe. 2009-01-23 12:12:38 -08:00
Dan Helfman
a90a2a842e Got highlight working again with the new shared iframes. 2009-01-22 22:36:24 -08:00
Dan Helfman
51a568c39c Several fixes for shared iframe releasing / focus interaction. 2009-01-22 22:33:32 -08:00
Dan Helfman
59f9134a8c Now blurring the focused editor when hiding/deleting any other editor.
This prevents a visual bug in which the iframe below a shutdown() editor didn't move to its new position.
2009-01-22 16:54:56 -08:00
Dan Helfman
5ce7de4f1d Opening existing notes from note links now works correctly. 2009-01-22 15:41:00 -08:00
Dan Helfman
623dbbdb3a Wiki.js no longer references Editor.iframe directly. 2009-01-22 15:30:17 -08:00
Dan Helfman
efc452dbfb Fix iframe blindUp() call so it doesn't break getSelection() within the iframe. 2009-01-22 14:53:46 -08:00
Dan Helfman
6438d34e97 Removing debugging print. 2009-01-22 14:27:01 -08:00
Dan Helfman
1658d43d4c Now when an editor is focused, the toolbar buttons update accordingly. 2009-01-22 14:23:07 -08:00
Dan Helfman
f3ca7bc677 Removing obsolete "FIXME" comment. 2009-01-22 13:51:19 -08:00
Dan Helfman
c97613490e Fixing some assumptions in Wiki.js that there are multiple iframes. 2009-01-22 13:30:00 -08:00
Dan Helfman
72c485a799 Not doing a blindUp() on an editor's iframe unless it actually has one. 2009-01-22 13:19:40 -08:00
Dan Helfman
56c7f8ea11 Fixing vertical height of new (empty) frames. 2009-01-22 13:16:25 -08:00
Dan Helfman
46d28d0ea0 Better window resizing behavior. 2009-01-22 13:05:18 -08:00
Dan Helfman
f5727d6383 An editor's iframe and div now blindUp in unision when the note is hidden/shutdown. 2009-01-22 12:15:32 -08:00
Dan Helfman
58827c4ebd More work on the reusable iframe. Now visually appears seamless. 2009-01-22 12:08:20 -08:00
Dan Helfman
9fa3cf2001 Resizing new iframe on load. 2009-01-21 13:43:45 -08:00
Dan Helfman
4e4a8ecd20 Removing duplicate focusing code. 2009-01-21 13:40:21 -08:00
Dan Helfman
10e2742ec5 Removing debugging print. 2009-01-21 13:36:14 -08:00
Dan Helfman
a05081166a Refactored Editor to use a reusable iframe for all notes. Also got cursor positioning working in Firefox.
Still needs more cleanup/bugfixing.
2009-01-21 13:33:11 -08:00
Dan Helfman
2e3501f5fc Adding fix for stupid IE 6 HTTPS warning message. 2009-01-19 22:47:43 -08:00
Dan Helfman
6df7b734e7 Fix for another IE 6 error. 2009-01-15 19:14:07 -08:00
Dan Helfman
d212797f7d Fix for IE6 error. 2009-01-15 19:06:05 -08:00
Dan Helfman
4a8e98372d Refactored some of the click position code. 2009-01-15 14:33:54 -08:00
Dan Helfman
404956deec In IE, you can now click on a static note div, and after it's converted into an iframe, the text cursor will be in the right position! 2009-01-15 01:36:32 -08:00
Dan Helfman
cb3d262630 Text cursor in IE is now correctly positioned at the end of the iframe contents when a new iframe is opened. 2009-01-14 16:37:02 -08:00