witten
/
luminotes
Archived
1
0
Fork 0
Code Releases Activity

Fixed bug where revoke buttons would be created with the same invite_id due to 

a closure using a variable within a for-loop.
This commit is contained in:
Dan Helfman 2008-01-06 06:01:30 +00:00
parent 2bcbc17172
commit 179f7ea4d1
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/Editor.js
View File

@ -214,10 +214,7 @@ Editor.prototype.finish_init = function () {
event.stop(); event.stop();
} ); } );
var revoke_buttons = getElementsByTagAndClassName( "input", "revoke_button" ); function connect_button( revoke_button, invite_id ) {
for ( var i in revoke_buttons ) {
var revoke_button = revoke_buttons[ i ];
var invite_id = revoke_button.id.split( "_" ).pop();
connect( revoke_button, "onclick", function ( event ) { connect( revoke_button, "onclick", function ( event ) {
signal( self, "revoke_invite", invite_id, function ( result ) { signal( self, "revoke_invite", invite_id, function ( result ) {
if ( !result.invites ) return; if ( !result.invites ) return;
@ -226,6 +223,13 @@ Editor.prototype.finish_init = function () {
event.stop(); event.stop();
} ); } );
} }
var revoke_buttons = getElementsByTagAndClassName( "input", "revoke_button" );
for ( var i in revoke_buttons ) {
var revoke_button = revoke_buttons[ i ];
var invite_id = revoke_button.id.split( "_" ).pop();
connect_button( revoke_button, invite_id );
}
} }
} ); } );