borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

Run tests for all installed versions of Python (#166). #176

Merged
witten merged 3 commits from tox-skip-missing-interpreters into master 2019-05-14 20:06:09 +00:00
Conversation 3 Commits 3 Files Changed 4 +5 -13
witten commented 2019-05-14 19:11:32 +00:00
Owner
Copy Link

Implementation of #166, including the suggestion about getting rid of the separate black script with conditional logic. Also took the opportunity to inline the isort script.

Testing: Ran this locally, and confirmed Tox output like:

...
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  py37: commands succeeded
  congratulations :)

I will confirm that this works in CI.

@decentral1se

Implementation of #166, including the suggestion about getting rid of the separate black script with conditional logic. Also took the opportunity to inline the isort script. Testing: Ran this locally, and confirmed Tox output like: ```bash ... SKIPPED: py35: InterpreterNotFound: python3.5 SKIPPED: py36: InterpreterNotFound: python3.6 py37: commands succeeded congratulations :) ``` I will confirm that this works in CI. @decentral1se
decentral1se approved these changes 2019-05-14 19:18:15 +00:00
decentral1se left a comment
Contributor
Copy Link

Minor comment. Looks great!

Hoping for a green Ci ...

Minor comment. Looks great! Hoping for a green Ci ...
tox.ini Outdated
@ -1,5 +1,6 @@
[tox]
envlist = py3
envlist = py35,py36,py37
skip_missing_interpreters=true
decentral1se commented 2019-05-14 19:17:26 +00:00
Contributor
Copy Link

Nitpick: skip_missing_interpreters = True - same style as the rest?

Nitpick: `skip_missing_interpreters = True` - same style as the rest?
witten commented 2019-05-14 19:20:21 +00:00
Author
Owner
Copy Link

Thanks, fixed!

Thanks, fixed!
witten commented 2019-05-14 19:21:25 +00:00
Author
Owner
Copy Link

I really need to beef up this CI server, or enable parallel execution as you suggested.. Or something. 🐌 ⌚

I really need to beef up this CI server, or enable parallel execution as you suggested.. Or something. :snail: :watch:
decentral1se commented 2019-05-14 19:47:41 +00:00
Contributor
Copy Link

hehe, also, would be nice (Builds auto cancellation):

https://github.com/drone/drone/issues/1980

hehe, also, would be nice (Builds auto cancellation): > https://github.com/drone/drone/issues/1980
witten commented 2019-05-14 20:05:50 +00:00
Author
Owner
Copy Link

Tell me about it! Looks like the build finally ran and succeeded: https://build.torsion.org/witten/borgmatic/149

Tell me about it! Looks like the build finally ran and succeeded: https://build.torsion.org/witten/borgmatic/149
witten closed this pull request 2019-05-14 20:06:09 +00:00
witten deleted branch tox-skip-missing-interpreters 2019-05-14 20:06:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#176
No description provided.
Delete Branch "tox-skip-missing-interpreters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?