Exclude failing due to confusing expansion of * #132

New Issue

copy · 2019-01-03T17:01:41Z

copy commented

2019-01-03 17:01:41 +00:00

I have these exclude lines in my config file:

    exclude_patterns:
         - /*/node_modules
         - /*/_build

Somehow all _build directories were properly excluded, while all node_modules were still present in my backup. Having a look a the exclude file generated by borgmatic, it turns out that the node_modules exclude was expanded early while the other one was preserved:

/lib/node_modules
/lib64/node_modules
/*/_build

While this seems to be the intended behaviour, it's quite confusing and fragile that borgmatic expands the same characters as borg in a preprocessing step, but only if the matches files are present.

I'd suggest to not expand * in borgmatic and document that this preprocessing of the exclude list is going on in addition to borg's pattern matching.

I have these exclude lines in my config file: ``` exclude_patterns: - /*/node_modules - /*/_build ``` Somehow all `_build` directories were properly excluded, while all `node_modules` were still present in my backup. Having a look a the exclude file generated by borgmatic, it turns out that the `node_modules` exclude was expanded early while the other one was preserved: ```text /lib/node_modules /lib64/node_modules /*/_build ``` While this seems to be the intended behaviour, it's quite confusing and fragile that borgmatic expands the same characters as borg in a preprocessing step, but only if the matches files are present. I'd suggest to not expand `*` in borgmatic and document that this preprocessing of the exclude list is going on in addition to borg's pattern matching.

witten commented

2019-01-05 05:49:29 +00:00

Thanks for reporting this. In borgmatic source, it looks like the function that expands * and ~ in paths is called when interpreting both source_directories and exclude_patterns. So I think the fix would be to continue expanding * for source_directories but not for exclude_patterns. And exclude_patterns still needs to expand ~ so as not to regress #58.

Thanks for reporting this. In borgmatic source, it looks like the function that expands `*` and `~` in paths is called when interpreting both `source_directories` and `exclude_patterns`. So I think the fix would be to continue expanding `*` for `source_directories` but not for `exclude_patterns`. And `exclude_patterns` still needs to expand `~` so as not to regress #58.

witten added the

design finalized

label 2019-01-27 21:01:37 +00:00

witten referenced this issue from a commit

2019-01-27 21:51:50 +00:00

Leave exclude_patterns glob expansion to Borg, since doing it in borgmatic leads to confusing behavior (#132).

witten commented

2019-01-27 21:52:29 +00:00

Okay, this fix is implemented now as described above. It'll be released shortly!

Thanks for reporting this.

Okay, this fix is implemented now as described above. It'll be released shortly! Thanks for reporting this.

witten closed this issue