jetchirag
  • Joined on 2023-03-22
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-28 20:38:06 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

It makes sense to include logic to remove duplicate endpoints. I'll add that.

I've fixed the latest merge conflicts and will start working on the rest of suggestions. Development might still be…

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-28 20:33:40 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Added unit test

jetchirag pushed to action-based-monitor-endpoints at jetchirag/borgmatic 2023-07-28 20:09:33 +00:00
29e718813d Resolved all merge conflicts
c11dcdef0a Fix some "borgmatic" capitalization issues.
8a2514915c Fix for Borg's interactive prompt on the "check --repair" action automatically getting answered "NO" (#730).
4d7a2876a5 Fix for "prune" action error when using the "keep_exclude_tags" option in configuration (#728).
309f67e860 Fix documentation comma grammar issues.
Compare 375 commits »
jetchirag pushed to action-based-monitor-endpoints at jetchirag/borgmatic 2023-07-28 19:08:57 +00:00
08e8262ee7 Minor suggestion fixes
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-06 00:36:17 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten I had this concern too since I started working on this. I was also wondering if someone wants to receive notification for a failed event in any of 4 actions, he will have to set the…

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-05 23:56:17 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Noted. I would personally prefer the skip-monitoring flag if I am configuring monitoring. I've removed the short flag but let me know if you rather want to go through your alternate suggestion.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-06-28 20:35:25 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten Hey, with start of GSoC and completing the other PR, this one slipped my radar.

So Sorry for the delay! I do intend to complete this and will get right back as soon as possible. I…

jetchirag commented on issue borgmatic-collective/borgmatic#659 2023-06-04 07:08:39 +00:00
Borg 2 date-based matching flags for archive selection

Thank you for bearing with me and your continuous help! :)

jetchirag deleted branch borg2-archive-flags from jetchirag/borgmatic 2023-06-04 07:07:43 +00:00
jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-05-23 15:08:33 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Last time I checked I thought I was getting other commits in my files changed. It looks fine right now though.

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-05-20 13:25:23 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

@witten I mostly merge with Github and seem to have messed up conflict resolving with merge as it's assigning other commits to this pull. Can you help?

jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-05-20 13:23:23 +00:00
00e9bb011a test should mock out make_flags_from_arguments
833796d1c4 Add archive check probing logic tweak to NEWS (#688).
e3425f48be Instead of taking the first check time found, take the maximum value (#688)
79b094d035 Bump version for release.
b45e45f161 Partial conversion of showing repository labels in logs instead of paths (part of #635).
Compare 72 commits »
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-04-27 16:57:30 +00:00
a62ac42cca Merge branch 'main' into borg2-archive-flags
22b84a2fea Switch to Docker Compose for dev-docs script, so podman-docker is no longer needed for Podman users.
5962fd473e Another try. Backing out psql error changes (#678).
7e64f415ba Attempt to fix failing end-to-end database test that only fails in CI.
ae12ccd8e6 And fixing again...
Compare 47 commits »
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-04-27 16:56:57 +00:00
68ee9687f5 Added tests for all subcommands and used black formatter
jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-24 15:21:08 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

@witten Sorry for the delay. Exams still going on 😅.

I've updated/fixed existing tests and added a test to prune for your review. Can you please take a quick look and I'll pull new commits…

jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-04-24 15:19:23 +00:00
32395e47f9 Added duplicate flags test for prune
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-04-24 15:13:19 +00:00
8aaba9bb0a Added new flags to prune test for review
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-04-24 14:54:27 +00:00
96aca4f446 Updated existing tests to use new parameters
jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-15 13:21:29 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

@witten I did not encounter any merge issue.

Can you give me pointers on testing? I suppose we can add a date-based matching test for each subcommand under /tests/unit/borg. Is there anything…

jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-04-15 12:00:38 +00:00
1ee56805f1 Merge remote-tracking branch 'upstream/master' into borg2-archive-flags
25506b8d2c Backing out upgrade of end-to-end test packages, because apparently we can't have nice things.
28e62d824b Upgrade end-to-end test packages.
7ee37a890e Fix broken end-to-end tests by no longer using an editable package there, a work-around for https://github.com/pypa/packaging-problems/issues/609
8cb5a42a9e Drop deprecated pkg_resources in favor of importlib.metadata and packaging.
Compare 112 commits »