• Joined on 2023-03-22
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-28 20:38:06 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

It makes sense to include logic to remove duplicate endpoints. I'll add that.

I've fixed the latest merge conflicts and will start working on the rest of suggestions. Development might still be…

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-28 20:33:40 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Added unit test

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-06 00:36:17 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten I had this concern too since I started working on this. I was also wondering if someone wants to receive notification for a failed event in any of 4 actions, he will have to set the…

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-07-05 23:56:17 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Noted. I would personally prefer the skip-monitoring flag if I am configuring monitoring. I've removed the short flag but let me know if you rather want to go through your alternate suggestion.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-06-28 20:35:25 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten Hey, with start of GSoC and completing the other PR, this one slipped my radar.

So Sorry for the delay! I do intend to complete this and will get right back as soon as possible. I…

jetchirag commented on issue borgmatic-collective/borgmatic#659 2023-06-04 07:08:39 +00:00
Borg 2 date-based matching flags for archive selection

Thank you for bearing with me and your continuous help! :)

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-05-23 15:08:33 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Last time I checked I thought I was getting other commits in my files changed. It looks fine right now though.

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-05-20 13:25:23 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

@witten I mostly merge with Github and seem to have messed up conflict resolving with merge as it's assigning other commits to this pull. Can you help?

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-24 15:21:08 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

@witten Sorry for the delay. Exams still going on 😅.

I've updated/fixed existing tests and added a test to prune for your review. Can you please take a quick look and I'll pull new commits…

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-15 13:21:29 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

@witten I did not encounter any merge issue.

Can you give me pointers on testing? I suppose we can add a date-based matching test for each subcommand under /tests/unit/borg. Is there anything…

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-02 21:58:47 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Note that there's unfortunately been some work in master that will pose minor conflicts with this branch. Hopefully it won't be a big deal to merge those in.

No worries, I'll resolve…

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-02 21:56:28 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

I couldn't find a way to simplify it further which can also be read easily. This definitely requires one or two re-reads for first time. I'll check back on this again after tests.

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-02 21:54:31 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Yes it should be paths

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-31 18:58:02 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

I think it's ready for a review. Only tests should be missing.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-29 10:26:37 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

I decided to go with calling ping_monitor in a loop.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-28 13:07:46 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten How do you want to go about adding flag to turn off monitor hook in interactive mode? Does borgmatic already have a method to detect cron or interactive mode?

If not, I think it'd…

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-03-27 08:00:03 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Is length of help text a problem?

'--newest', metavar='TIMESPAN', help='Mount archives within a time range that ends at timestamp of the newest archive and starts a specified time range…
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-26 21:28:23 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten I unexpectedly missed that multiple actions. Will fix it.

jetchirag created pull request borgmatic-collective/borgmatic#661 2023-03-25 20:36:15 +00:00
WIP: Added TIMESPAN flags to match archive in various commands (Borg2 feature)
jetchirag commented on issue borgmatic-collective/borgmatic#659 2023-03-25 20:18:32 +00:00
Borg 2 date-based matching flags for archive selection

Is there any specific reason make_flags_from_arguments() isn't used on every action? I'm working on the PR and have left the borg files untouched which are used this function and passed all…