jetchirag
  • Joined on 2023-03-22
jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-02 21:58:47 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Note that there's unfortunately been some work in master that will pose minor conflicts with this branch. Hopefully it won't be a big deal to merge those in.

No worries, I'll resolve…

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-02 21:56:28 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

I couldn't find a way to simplify it further which can also be read easily. This definitely requires one or two re-reads for first time. I'll check back on this again after tests.

jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-04-02 21:54:31 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Yes it should be paths

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-31 18:58:02 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

I think it's ready for a review. Only tests should be missing.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-29 10:26:37 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

I decided to go with calling ping_monitor in a loop.

jetchirag pushed to action-based-monitor-endpoints at jetchirag/borgmatic 2023-03-29 10:25:22 +00:00
aa6f1e6623 Support multiple actions with ping_monitor
2d728d57d7 minor; log on skipping cronitor due to KeyError
6ce6367a26 --skip-monitoring flag
Compare 3 commits »
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-28 13:07:46 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten How do you want to go about adding flag to turn off monitor hook in interactive mode? Does borgmatic already have a method to detect cron or interactive mode?

If not, I think it'd…

jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-03-28 12:45:52 +00:00
98c6aa6443 Use Square brackets to denote version specific flag
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-03-28 12:40:54 +00:00
edd79ed86c removed individual action parameters, and used make_flags_from_arguments
4fa4fccab7 Use make_flags_from_arguments on mount; Pending test fixes
Compare 2 commits »
jetchirag commented on pull request borgmatic-collective/borgmatic#661 2023-03-27 08:00:03 +00:00
Added TIMESPAN flags to match archive in various commands (Borg2 feature)

Is length of help text a problem?

'--newest', metavar='TIMESPAN', help='Mount archives within a time range that ends at timestamp of the newest archive and starts a specified time range…
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-26 21:28:23 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@witten I unexpectedly missed that multiple actions. Will fix it.

jetchirag pushed to action-based-monitor-endpoints at jetchirag/borgmatic 2023-03-26 10:16:48 +00:00
1ee3b89e99 Merge with master
f56fdab7a9 Add troubleshooting documentation on PostgreSQL/MySQL authentication errors.
8c0eea7229 Add additional documentation link to environment variable feature. Rename constants section.
19e95628c3 Add documentation and NEWS for custom constants feature (#612).
4d01e53414 Fix: replace primitive values in config without quotes (#612).
Compare 27 commits »
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-03-25 20:37:00 +00:00
ff1f4dc09c minor fixes to prune argument help text
jetchirag created pull request borgmatic-collective/borgmatic#661 2023-03-25 20:36:15 +00:00
WIP: Added TIMESPAN flags to match archive in various commands (Borg2 feature)
jetchirag created branch borg2-archive-flags in jetchirag/borgmatic 2023-03-25 20:28:23 +00:00
jetchirag pushed to borg2-archive-flags at jetchirag/borgmatic 2023-03-25 20:28:23 +00:00
141474ff07 Added TIMESPAN flags to match archive in various commands (Borg2 feature)
jetchirag commented on issue borgmatic-collective/borgmatic#659 2023-03-25 20:18:32 +00:00
Borg 2 date-based matching flags for archive selection

Is there any specific reason make_flags_from_arguments() isn't used on every action? I'm working on the PR and have left the borg files untouched which are used this function and passed all…

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-25 14:53:13 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Just found it. Marked!

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-25 14:40:28 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

@diivi No, full scope of this PR includes all 5 supported monitors. This Initial PR is just to verify the method.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-25 14:35:59 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Yes, would be working on tests once I complete basic functions.