Note that there's unfortunately been some work in master that will pose minor conflicts with this branch. Hopefully it won't be a big deal to merge those in.
No worries, I'll resolve…
I couldn't find a way to simplify it further which can also be read easily. This definitely requires one or two re-reads for first time. I'll check back on this again after tests.
I think it's ready for a review. Only tests should be missing.
I decided to go with calling ping_monitor in a loop.
@witten How do you want to go about adding flag to turn off monitor hook in interactive mode? Does borgmatic already have a method to detect cron or interactive mode?
If not, I think it'd…
Is length of help text a problem?
'--newest', metavar='TIMESPAN', help='Mount archives within a time range that ends at timestamp of the newest archive and starts a specified time range…
@witten I unexpectedly missed that multiple actions. Will fix it.
Is there any specific reason make_flags_from_arguments()
isn't used on every action? I'm working on the PR and have left the borg files untouched which are used this function and passed all…
@diivi No, full scope of this PR includes all 5 supported monitors. This Initial PR is just to verify the method.
Yes, would be working on tests once I complete basic functions.