borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
58
Fork 42
Code Issues 62 Pull Requests 2 Actions Packages Releases 122 Activity

Support for Apprise #759

Merged
witten merged 10 commits from pizzapim/borgmatic:main into main 2023-10-04 21:58:21 +00:00
Conversation 7 Commits 10 Files Changed 7 +3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a587e207f9 - Show all commits

3
test_requirements.txt
View File

@ -31,3 +31,6 @@ toml==0.10.2; python_version >= '3.8'
typed-ast; python_version >= '3.8'
typing-extensions==4.5.0; python_version < '3.8'
zipp==3.15.0; python_version < '3.8'
certifi==2022.9.24
PyYAML==6.0
Markdown==3.4.1
pizzapim marked this conversation as resolved Outdated
witten commented 2023-09-25 18:35:51 +00:00
Outdated
Review
Copy Link

I'm not seeing apprise itself in the test dependencies...? I think it needs to be there for it to be available in tests. I'm totally fine if it's not an optional dependency for tests themselves.

Also would you mind alpha ordering these new dependencies into the rest?

I'm not seeing `apprise` itself in the test dependencies...? I think it needs to be there for it to be available in tests. I'm totally fine if it's not an optional dependency for tests themselves. Also would you mind alpha ordering these new dependencies into the rest?