borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
57
Fork 41
Code Issues 53 Pull Requests 2 Actions Packages Releases 122 Activity

/usr/share excluded when it should not be #799

New Issue
Closed
opened 2023-12-11 10:54:42 +00:00 by atelszewski ยท 10 comments
atelszewski commented 2023-12-11 10:54:42 +00:00
Copy Link

What I'm trying to do and why

Hi,

I'm making a full system backup, starting the backup at /.

I noticed that /usr/share is excluded from the backup.
I have some excludes configured, but /usr/share is not on the list.

Steps to reproduce

No response

Actual behavior

/usr/share is excluded, but I haven't configured it to be excluded.

Expected behavior

/usr/share is included in the backup if not explicitely excluded.

Other notes / implementation ideas

No response

borgmatic version

1.8.5

borgmatic installation method

No response

Borg version

1.2.7

Python version

3.9.18

Database version (if applicable)

No response

Operating system and version

NAME=Slackware VERSION="15.0" ID=slackware VERSION_ID=15.0 PRETTY_NAME="Slackware 15.0 x86_64" ANSI_COLOR="0;34" CPE_NAME="cpe:/o:slackware:slackware_linux:15.0" HOME_URL="http://slackware.com/" SUPPORT_URL="http://www.linuxquestions.org/questions/slackware-14/" BUG_REPORT_URL="http://www.linuxquestions.org/questions/slackware-14/" VERSION_CODENAME=stable

### What I'm trying to do and why Hi, I'm making a full system backup, starting the backup at `/`. I noticed that `/usr/share` is excluded from the backup. I have some _excludes_ configured, but `/usr/share` is not on the list. ### Steps to reproduce _No response_ ### Actual behavior `/usr/share` is excluded, but I haven't configured it to be excluded. ### Expected behavior `/usr/share` is included in the backup if not _explicitely_ excluded. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.5 ### borgmatic installation method _No response_ ### Borg version 1.2.7 ### Python version 3.9.18 ### Database version (if applicable) _No response_ ### Operating system and version NAME=Slackware VERSION="15.0" ID=slackware VERSION_ID=15.0 PRETTY_NAME="Slackware 15.0 x86_64" ANSI_COLOR="0;34" CPE_NAME="cpe:/o:slackware:slackware_linux:15.0" HOME_URL="http://slackware.com/" SUPPORT_URL="http://www.linuxquestions.org/questions/slackware-14/" BUG_REPORT_URL="http://www.linuxquestions.org/questions/slackware-14/" VERSION_CODENAME=stable
IBims1NicerTobi commented 2023-12-11 14:52:28 +00:00
Contributor
Copy Link

Can you post you full config (minus secrets) and the output of borgmatic -v 2 here?

Can you post you full config (minus secrets) and the output of `borgmatic -v 2` here?
๐Ÿ‘ 1
witten added the
question / support
 label 2023-12-11 18:13:26 +00:00
atelszewski commented 2023-12-11 20:49:13 +00:00
Author
Copy Link

Hi,

I normally create backup with --list, so that the listing of files is logged as well.
Would it suit you if I posted the log without the listing?

--
Best regards,
Andrzej Telszewski

Hi, I normally create backup with `--list`, so that the listing of files is logged as well. Would it suit you if I posted the log without the listing? -- Best regards, Andrzej Telszewski
witten commented 2023-12-12 03:27:31 +00:00
Owner
Copy Link

The output of --list would be helpful in order to see which files Borg is actually including/excluding. Would it be possible to redact the --list output so we can at least see the start of each path (/usr/share/, etc.)?

The output of `--list` would be helpful in order to see which files Borg is actually including/excluding. Would it be possible to redact the `--list` output so we can at least see the start of each path (`/usr/share/`, etc.)?
atelszewski commented 2023-12-14 10:09:44 +00:00
Author
Copy Link

Hi,

attached please find:

  • Configuration file.
    It has only the repo path changed to not be a real one.

  • Exclude file.
    It has only one line removed, that was excluding files in /home/atelszewski/....

  • dobackup.
    This is the script to start the backup.

  • The log file:

    • it only contains files that were excluded, i.e. x,
    • it has all lines refering to /home/atelszewski removed.

Please let me know if this log file contents is sufficient, if not, I'll provide more details.
I'd like to reiterate that, that only the files under /usr/share are incorrectly excluded - other excludes are correct.

Thank you! :-)

--
Best regards,
Andrzej Telszewski

Hi, attached please find: - Configuration file. It has only the repo path changed to not be a real one. - Exclude file. It has only one line removed, that was excluding files in `/home/atelszewski/...`. - `dobackup`. This is the script to start the backup. - The log file: - it only contains files that were excluded, i.e. `x`, - it has all lines refering to `/home/atelszewski` removed. Please let me know if this log file contents is sufficient, if not, I'll provide more details. I'd like to reiterate that, that only the files under `/usr/share` are incorrectly excluded - other excludes are correct. Thank you! :-) -- Best regards, Andrzej Telszewski
config.yaml.txt
5.9 KiB
complete_system-borgbase.log-excluded_only-01-without-home-atelszewski.txt
79 KiB
excludes.txt
920 B
dobackup.txt
340 B
IBims1NicerTobi commented 2023-12-14 15:36:18 +00:00
Contributor
Copy Link

I'm not 100% sure but sh:*/[Ss]hare/ should match /usr/share (it's on line 11 in your excludes).

I'm not 100% sure but `sh:*/[Ss]hare/` should match `/usr/share` (it's on line 11 in your excludes).
๐Ÿ‘ 1
atelszewski commented 2023-12-14 16:08:31 +00:00
Author
Copy Link

Hi,

good catch! :-)
I'll look into it - so far that's the only possibility I see.

EDIT:

Actually, that makes perfect sense.
I wanted to exclude /root/share and /admin/share, but the wildcard of course matches /usr.

I'll run some test soon to prove what's obvious. :-)

Thanks!

--
Best regards,
Andrzej Telszewski

Hi, good catch! :-) I'll look into it - so far that's the only possibility I see. EDIT: Actually, that makes perfect sense. I wanted to exclude `/root/share` and `/admin/share`, but the wildcard of course matches `/usr`. I'll run some test soon to prove what's obvious. :-) Thanks! -- Best regards, Andrzej Telszewski
๐Ÿ‘ 1
IBims1NicerTobi commented 2023-12-16 23:35:02 +00:00
Contributor
Copy Link

@witten I think this can be closed.

@witten I think this can be closed.
๐Ÿ‘ 1
witten commented 2023-12-16 23:43:01 +00:00
Owner
Copy Link

Thanks!

Thanks!
atelszewski commented 2023-12-17 22:23:15 +00:00
Author
Copy Link

Hi,

I examined the log of excluded files, and indeed, after correcting sh:*/[Ss]hare/ to re:^(admin|root)/[Ss]hare/
all is fine.

Thank you one more time for pointing this out! :-)

--
Best regards,
Andrzej Telszewski

Hi, I examined the log of excluded files, and indeed, after correcting `sh:*/[Ss]hare/` to `re:^(admin|root)/[Ss]hare/` all is fine. Thank you one more time for pointing this out! :-) -- Best regards, Andrzej Telszewski
witten commented 2023-12-17 22:26:05 +00:00
Owner
Copy Link

Awesome, glad to hear it!

Awesome, glad to hear it!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#799
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?