borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

Traceback when usage error occurs #768

New Issue
Closed
opened 2023-10-07 01:42:33 +00:00 by witten · 2 comments
witten commented 2023-10-07 01:42:33 +00:00
Owner
Copy Link

What I'm trying to do and why

As part of prototyping another feature, I accidentally ran borgmatic with an invalid argument. However this produced a traceback instead of a nice usage error message.

Steps to reproduce

$ borgmatic --invalid

Actual behavior

usage: borgmatic [-h] [-c CONFIG_PATHS] [-n] [-nc] [-v {-2,-1,0,1,2}] [--syslog-verbosity {-2,-1,0,1,2}] [--log-file-verbosity {-2,-1,0,1,2}]
                 [--monitoring-verbosity {-2,-1,0,1,2}] [--log-file LOG_FILE] [--log-file-format LOG_FILE_FORMAT] [--log-json]
                 [--override OPTION.SUBOPTION=VALUE] [--no-environment-interpolation] [--bash-completion] [--fish-completion] [--version]
                 ...
Traceback (most recent call last):
  File "/home/witten/code/borgmatic/borgmatic/commands/borgmatic.py", line 816, in main
    arguments = parse_arguments(*sys.argv[1:])
  File "/home/witten/code/borgmatic/borgmatic/commands/arguments.py", line 1283, in parse_arguments
    raise ValueError(
ValueError: Unrecognized argument: --invalid

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/.local/bin/borgmatic", line 8, in <module>
    sys.exit(main())
  File "/home/witten/code/borgmatic/borgmatic/commands/borgmatic.py", line 818, in main
    configure_logging(logging.CRITICAL)
  File "/home/witten/code/borgmatic/borgmatic/logger.py", line 170, in configure_logging
    syslog_log_level = logging.DISABLED
AttributeError: module 'logging' has no attribute 'DISABLED'

Expected behavior

usage: borgmatic [-h] [-c CONFIG_PATHS] [-n] [-nc] [-v {-2,-1,0,1,2}] [--syslog-verbosity {-2,-1,0,1,2}] [--log-file-verbosity {-2,-1,0,1,2}]
                 [--monitoring-verbosity {-2,-1,0,1,2}] [--log-file LOG_FILE] [--log-file-format LOG_FILE_FORMAT] [--log-json]
                 [--override OPTION.SUBOPTION=VALUE] [--no-environment-interpolation] [--bash-completion] [--fish-completion] [--version]
                 ...
Unrecognized argument: --invalid

Need some help? https://torsion.org/borgmatic/#issues

Other notes / implementation ideas

This problem appears to have been introduced in borgmatic 1.8.3, and in particular I'm guessing it was the logging changes as part of #665.

borgmatic version

1.8.3 or main

borgmatic installation method

pipx install --editable

Borg version

1.2.3

Python version

3.10.10

Database version (if applicable)

No response

Operating system and version

Manjaro stable

### What I'm trying to do and why As part of prototyping another feature, I accidentally ran borgmatic with an invalid argument. However this produced a traceback instead of a nice usage error message. ### Steps to reproduce ``` $ borgmatic --invalid ``` ### Actual behavior ``` usage: borgmatic [-h] [-c CONFIG_PATHS] [-n] [-nc] [-v {-2,-1,0,1,2}] [--syslog-verbosity {-2,-1,0,1,2}] [--log-file-verbosity {-2,-1,0,1,2}] [--monitoring-verbosity {-2,-1,0,1,2}] [--log-file LOG_FILE] [--log-file-format LOG_FILE_FORMAT] [--log-json] [--override OPTION.SUBOPTION=VALUE] [--no-environment-interpolation] [--bash-completion] [--fish-completion] [--version] ... Traceback (most recent call last): File "/home/witten/code/borgmatic/borgmatic/commands/borgmatic.py", line 816, in main arguments = parse_arguments(*sys.argv[1:]) File "/home/witten/code/borgmatic/borgmatic/commands/arguments.py", line 1283, in parse_arguments raise ValueError( ValueError: Unrecognized argument: --invalid During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/root/.local/bin/borgmatic", line 8, in <module> sys.exit(main()) File "/home/witten/code/borgmatic/borgmatic/commands/borgmatic.py", line 818, in main configure_logging(logging.CRITICAL) File "/home/witten/code/borgmatic/borgmatic/logger.py", line 170, in configure_logging syslog_log_level = logging.DISABLED AttributeError: module 'logging' has no attribute 'DISABLED' ``` ### Expected behavior ``` usage: borgmatic [-h] [-c CONFIG_PATHS] [-n] [-nc] [-v {-2,-1,0,1,2}] [--syslog-verbosity {-2,-1,0,1,2}] [--log-file-verbosity {-2,-1,0,1,2}] [--monitoring-verbosity {-2,-1,0,1,2}] [--log-file LOG_FILE] [--log-file-format LOG_FILE_FORMAT] [--log-json] [--override OPTION.SUBOPTION=VALUE] [--no-environment-interpolation] [--bash-completion] [--fish-completion] [--version] ... Unrecognized argument: --invalid Need some help? https://torsion.org/borgmatic/#issues ``` ### Other notes / implementation ideas This problem appears to have been introduced in borgmatic 1.8.3, and in particular I'm guessing it was the logging changes as part of #665. ### borgmatic version 1.8.3 or main ### borgmatic installation method pipx install --editable ### Borg version 1.2.3 ### Python version 3.10.10 ### Database version (if applicable) _No response_ ### Operating system and version Manjaro stable
witten added the
bug
 label 2023-10-07 01:43:06 +00:00
witten commented 2023-10-07 04:04:11 +00:00
Author
Owner
Copy Link

Fixed in main. The fix will be part of the next release.

Fixed in main. The fix will be part of the next release.
witten commented 2023-10-27 05:22:31 +00:00
Author
Owner
Copy Link

Released in borgmatic 1.8.4!

Released in borgmatic 1.8.4!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#768
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?