Deprecated mysql name when using mariadb #727

New Issue

Closed

opened 2023-07-22 08:24:15 +00:00 by nsurbay · 3 comments

nsurbay commented 2023-07-22 08:24:15 +00:00

Copy Link

What I'm trying to do and why

The commit b30b040b73 deprecates the usage of mysql and mysql-* when using mariadb database.

When using a borgmatic configuration with mysql_databases, the followed message is displayed:

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Steps to reproduce

Run borgbackup to backup an mariadb database using mysql_databases options. The mariadb server and CLI should be at least at version 11.0.2.

Actual behavior

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Expected behavior

No warning is displayed and borgbackup use mariadb instead of mysql.

Other notes / implementation ideas

As you may want to support both backend, maybe a new option in mysql_databases can be use to select either mysql or mariadb. Another implementation may be copy mysql_databases to a mariadb_databases.

borgmatic version

1.8.0

borgmatic installation method

archlinux package

Borg version

borg 1.2.4

Python version

Python 3.11.3

Database version (if applicable)

mariadb from 11.0.2-MariaDB, client 15.2 for Linux (x86_64) using readline 5.1

Operating system and version

archlinux

### What I'm trying to do and why The commit https://github.com/MariaDB/server/commit/b30b040b733ff2045ffcd7bdd44f608c7f4912b5 deprecates the usage of ``mysql`` and ``mysql-*`` when using mariadb database. When using a borgmatic configuration with ``mysql_databases``, the followed message is displayed: ``` mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead ``` ### Steps to reproduce Run borgbackup to backup an mariadb database using ``mysql_databases`` options. The mariadb server and CLI should be at least at version 11.0.2. ### Actual behavior ``` mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead ``` ### Expected behavior No warning is displayed and borgbackup use mariadb instead of mysql. ### Other notes / implementation ideas As you may want to support both backend, maybe a new option in ``mysql_databases`` can be use to select either mysql or mariadb. Another implementation may be copy ``mysql_databases`` to a ``mariadb_databases``. ### borgmatic version 1.8.0 ### borgmatic installation method archlinux package ### Borg version borg 1.2.4 ### Python version Python 3.11.3 ### Database version (if applicable) mariadb from 11.0.2-MariaDB, client 15.2 for Linux (x86_64) using readline 5.1 ### Operating system and version archlinux

witten commented 2023-07-22 16:06:23 +00:00

Owner

Copy Link

Thank you for bringing this to my attention! My inclination here is to do your second suggestion (a separate mariadb_databases:) for a couple reasons:

• mysql_databases: is a list! So it would require a more involved schema change to be able to stuff an option in there to select MySQL/MariaDB.
• Based on the MariaDB changeset you linked, it's sounding like MariaDB commands may diverge further from MySQL's in the future. In which case it would make sense for borgmatic to have its own dedicated MariaDB hook in order to support those differences.

Thank you for bringing this to my attention! My inclination here is to do your second suggestion (a separate `mariadb_databases:`) for a couple reasons: * `mysql_databases:` is a list! So it would require a more involved schema change to be able to stuff an option in there to select MySQL/MariaDB. * Based on the MariaDB changeset you linked, it's sounding like MariaDB commands may diverge further from MySQL's in the future. In which case it would make sense for borgmatic to have its own dedicated MariaDB hook in order to support those differences.

witten referenced this issue from a commit 2023-08-04 20:23:09 +00:00

Fork a MariaDB database hook from the MySQL database hook (#727).

witten commented 2023-08-04 20:24:52 +00:00

Owner

Copy Link

I just implemented a new mariadb_databases: hook in main and it'll be part of the next release! Be aware though that any existing backups made with the mysql_databases: hook are only restorable with a mysql_databases: configuration. Thanks for the suggestion!

I just implemented a new `mariadb_databases:` hook in main and it'll be part of the next release! Be aware though that any existing backups made with the `mysql_databases:` hook are only restorable with a `mysql_databases:` configuration. Thanks for the suggestion!

witten closed this issue 2023-08-04 20:24:52 +00:00

witten commented 2023-08-14 19:59:05 +00:00

Owner

Copy Link

This has been released in borgmatic 1.8.2!

This has been released in borgmatic 1.8.2!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#727

No description provided.