Development: How to get around self importing module #65

New Issue

Closed

opened 2018-06-06 16:26:49 +00:00 by floli · 2 comments

floli commented 2018-06-06 16:26:49 +00:00

Collaborator

Copy Link

Hello,
when I try to launch borgmatic from a git checkout:

~/software/borgmatic/borgmatic (git)-[master] # python commands/borgmatic.py 

Traceback (most recent call last):
  File "commands/borgmatic.py", line 8, in <module>
    from borgmatic.borg import check as borg_check, create as borg_create, prune as borg_prune, \
  File "/home/florian/software/borgmatic/borgmatic/commands/borgmatic.py", line 8, in <module>
    from borgmatic.borg import check as borg_check, create as borg_create, prune as borg_prune, \
ModuleNotFoundError: No module named 'borgmatic.borg'; 'borgmatic' is not a package

~/software/borgmatic/borgmatic (git)-[master] # echo $PYTHONPATH
:/home/florian/software/borgmatic

this is probably a result of commands/borgmatic.py import from borgmatic, which is interpreted as importing from the same file.

How do you get around this while developing?

Thanks!

Hello, when I try to launch borgmatic from a git checkout: ``` ~/software/borgmatic/borgmatic (git)-[master] # python commands/borgmatic.py Traceback (most recent call last): File "commands/borgmatic.py", line 8, in <module> from borgmatic.borg import check as borg_check, create as borg_create, prune as borg_prune, \ File "/home/florian/software/borgmatic/borgmatic/commands/borgmatic.py", line 8, in <module> from borgmatic.borg import check as borg_check, create as borg_create, prune as borg_prune, \ ModuleNotFoundError: No module named 'borgmatic.borg'; 'borgmatic' is not a package ~/software/borgmatic/borgmatic (git)-[master] # echo $PYTHONPATH :/home/florian/software/borgmatic ``` this is probably a result of `commands/borgmatic.py` import from `borgmatic`, which is interpreted as importing from the same file. How do you get around this while developing? Thanks!

floli changed title from Development: How do get around self importing module to Development: How to get around self importing module 2018-06-06 16:27:01 +00:00

witten added the

question / support

label 2018-06-07 04:42:11 +00:00

witten commented 2018-06-07 04:46:51 +00:00

Owner

Copy Link

I develop on this by installing borgmatic as "editable". Meaning, with the pip install --editable flag. That means I can hack on the source and see changes reflected immediately, while everything is imported exactly as it would be in the real world. Plus, all of the standard borgmatic console commands are runnable this way as well, assuming they're installed somewhere that's on your PATH (or you're using a virtualenv).

If that process works for you, then I can at least make sure that's mentioned in the documentation.

I develop on this by installing borgmatic as "editable". Meaning, with the `pip install --editable` flag. That means I can hack on the source and see changes reflected immediately, while everything is imported exactly as it would be in the real world. Plus, all of the standard borgmatic console commands are runnable this way as well, assuming they're installed somewhere that's on your `PATH` (or you're using a virtualenv). If that process works for you, then I can at least make sure that's mentioned in the documentation.

witten commented 2018-06-17 21:57:09 +00:00

Owner

Copy Link

I added some info about using "editable" mode to the borgmatic README during development. So calling this done for now. But please let me know if you have any other issues with this.

I added some info about using "editable" mode to the borgmatic README during development. So calling this done for now. But please let me know if you have any other issues with this.

witten closed this issue 2018-06-17 21:57:09 +00:00

witten referenced this issue from a commit 2023-04-01 17:45:32 +00:00

Fix: run typos to fix various typos in source code.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#65

No description provided.