create before prune and compact? #636

New Issue

Closed

opened 2023-02-09 04:36:34 +00:00 by anarcat · 3 comments

anarcat commented 2023-02-09 04:36:34 +00:00

Copy Link

I am often running into this situation with borg that it notices a huge junk file i left around. it could be a temporary copy of a file, an ISO image i don't want, anything. Typically, it gets stuck on there for a while and, if i notice, i remove the file, kill the backup and start again.

With normal borg create, this works fine: borg will restart scanning the filesystem from scratch, but at least the chunks are already on the server, so it's a lot faster the second time. Kind of like a resume. A prune will cleanup the stray checkpoints.

the way the default command in borgmatic works breaks that: when you run borgmatic again, the first thing it does is prune and compact that now precious checkpoint to hell. So now when i run borgmatic again, I am starting from scratch.

i'd love to hear the reasoning behind why the default actions are set in the order they are. I can venture a guess: you want to prune and compact before you make a new snapshot to save space. Is that the reasoning?

Is there a way we can customize that order, other than of course calling each command one by one...

I am often running into this situation with borg that it notices a huge junk file i left around. it could be a temporary copy of a file, an ISO image i don't want, anything. Typically, it gets stuck on there for a while and, if i notice, i remove the file, kill the backup and start again. With normal borg create, this works fine: borg will restart scanning the filesystem from scratch, but at least the chunks are already on the server, so it's a lot faster the second time. Kind of like a resume. A prune will cleanup the stray checkpoints. the way the default command in borgmatic works breaks that: when you run borgmatic again, the first thing it does is prune and compact that now precious checkpoint to hell. So now when i run borgmatic again, I am starting from scratch. i'd love to hear the reasoning behind why the [default actions](https://torsion.org/borgmatic/docs/how-to/set-up-backups/#default-actions) are set in the order they are. I can venture a guess: you want to prune and compact before you make a new snapshot to save space. Is that the reasoning? Is there a way we can customize that order, other than of course calling each command one by one...

👀 1

witten commented 2023-02-09 04:42:18 +00:00

Owner

Copy Link

Thanks for filing this!

I can venture a guess: you want to prune and compact before you make a new snapshot to save space. Is that the reasoning?

Yup, that is indeed the reasoning, although I totally see how that interferes with your use case. There's some discussion about the prune-first rationale in #304. I'm not wedded to that order, however, if there are good arguments for changing it.

Is there a way we can customize that order, other than of course calling each command one by one...

Nope, not currently. I agree it makes sense to have a configuration option to customize the order, since it's clear that a single order can't meet all use cases!

Thanks for filing this! > I can venture a guess: you want to prune and compact before you make a new snapshot to save space. Is that the reasoning? Yup, that is indeed the reasoning, although I totally see how that interferes with your use case. There's some discussion about the prune-first rationale in #304. I'm not wedded to that order, however, if there are good arguments for changing it. > Is there a way we can customize that order, other than of course calling each command one by one... Nope, not currently. I agree it makes sense to have a configuration option to customize the order, since it's clear that a single order can't meet all use cases!

anarcat commented 2023-02-09 14:58:56 +00:00

Author

Copy Link

Oh dear, looks like I didn't look properly before opening this issue, let's close this and move to #304, sorry for the noise! :)

Oh dear, looks like I didn't look properly before opening this issue, let's close this and move to #304, sorry for the noise! :)

anarcat closed this issue 2023-02-09 14:58:57 +00:00

anarcat referenced this issue 2023-02-09 15:01:01 +00:00

Why prune first? #304

witten commented 2023-02-09 17:00:24 +00:00

Owner

Copy Link

No worries! It's good to hear about use cases I hadn't considered.

No worries! It's good to hear about use cases I hadn't considered.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#636

No description provided.