Support patterns-from #49

New Issue

Closed

opened 2018-01-09 13:35:33 +00:00 by TiGR · 9 comments

TiGR commented 2018-01-09 13:35:33 +00:00

Copy Link

Borg has an option patterns-from that lets you specify file with include/exclude patterns. Could borgmatic have it also? Or could borgmatic have any option to let you pass any option you want to borg create?

Borg has an option `patterns-from` that lets you specify file with include/exclude patterns. Could borgmatic have it also? Or could borgmatic have any option to let you pass any option you want to `borg create`?

witten commented 2018-01-10 05:23:14 +00:00

Owner

Copy Link

borgmatic already supports "native" exclude_patterns and exclude_from config options. Do you want to use Borg's patterns-from because you also need to specify includes and not just excludes? The Borg feature is marked experimental, so I haven't implemented it yet, but I can imagine why it'd be useful. Out of curiosity, what do you want to use it for?

Thanks!

borgmatic already supports "native" `exclude_patterns` and `exclude_from` config options. Do you want to use Borg's `patterns-from` because you also need to specify includes and not just excludes? The Borg feature is marked experimental, so I haven't implemented it yet, but I can imagine why it'd be useful. Out of curiosity, what do you want to use it for? Thanks!

TiGR commented 2018-01-10 07:06:53 +00:00

Author

Copy Link

I'm trying to create something to ignore files that are ignored in .gitignore files found in backup files. So, I have these lines in my config:

source_directories:
    - /files/to/backup
location:
    exclude_from:
        - /files/to/backup/.borgmatic-exclude
hooks:
    before_backup:
        - echo "`date` - Starting a backup job."
        - find /files/to/backup/ -name .gitignore | grep -v /vendor/ | xargs grep -HPv '^([!#]|$)' | sed -E 's~\.gitignore:([^/])~**/\1~' | sed 's~\.gitignore:/~~' | sed 's/^/sh:/' > /files/to/backup/.borgmatic-exclude

It is quick and dirty, but it works. The only problem is that I have to ignore not-exclude patterns from .gitignore as there is no way to specify these in --exclude-from. That's why I need --patterns-from.

I'm trying to create something to ignore files that are ignored in `.gitignore` files found in backup files. So, I have these lines in my config: ```yaml source_directories: - /files/to/backup location: exclude_from: - /files/to/backup/.borgmatic-exclude hooks: before_backup: - echo "`date` - Starting a backup job." - find /files/to/backup/ -name .gitignore | grep -v /vendor/ | xargs grep -HPv '^([!#]|$)' | sed -E 's~\.gitignore:([^/])~**/\1~' | sed 's~\.gitignore:/~~' | sed 's/^/sh:/' > /files/to/backup/.borgmatic-exclude ``` It is quick and dirty, but it works. The only problem is that I have to ignore not-exclude patterns from `.gitignore` as there is no way to specify these in `--exclude-from`. That's why I need `--patterns-from`.

witten commented 2018-01-10 20:05:12 +00:00

Owner

Copy Link

Makes sense.. Thanks for clarifying the need and including the work-around example!

Makes sense.. Thanks for clarifying the need and including the work-around example!

witten commented 2018-01-14 23:53:41 +00:00

Owner

Copy Link

Just implemented this in master via new patterns_from and patterns configuration options in borgmatic. It'll be part of the next release. I'll be interested to hear how it works out for your use case.

Just implemented this in master via new `patterns_from` and `patterns` configuration options in borgmatic. It'll be part of the next release. I'll be interested to hear how it works out for your use case.

witten closed this issue 2018-01-14 23:53:41 +00:00

witten commented 2018-01-15 00:40:28 +00:00

Owner

Copy Link

borgmatic 1.1.13 was just released with this.

borgmatic 1.1.13 was just released with this.

TiGR commented 2018-01-15 11:08:25 +00:00

Author

Copy Link

Well, borgmatic fails with

borg: error: unrecognized arguments: --pattern-from /files/to/backup/.borgmatic-patterns

I suppose the problem is that the argument name is patterns-from, not pattern-from.

Well, borgmatic fails with borg: error: unrecognized arguments: --pattern-from /files/to/backup/.borgmatic-patterns I suppose the problem is that the argument name is `patterns-from`, not `pattern-from`.

TiGR reopened this issue 2018-01-15 11:08:25 +00:00

TiGR commented 2018-01-15 11:12:47 +00:00

Author

Copy Link

There are 6 instances of pattern-from in b8f6bab12d

There are 6 instances of `pattern-from` in b8f6bab12d

witten commented 2018-01-16 04:17:54 +00:00

Owner

Copy Link

My bad, will fix!

My bad, will fix!

witten commented 2018-01-16 04:58:43 +00:00

Owner

Copy Link

Okay, fixed and released in borgmatic 1.1.14.

Okay, fixed and released in borgmatic 1.1.14.

witten closed this issue 2018-01-16 04:58:43 +00:00

witten referenced this issue from a commit 2022-11-18 16:35:11 +00:00

Override PostgreSQL dump/restore commands via configuration options (#311).

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#49

No description provided.