borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

before_everything / after_everything hook does not apply for "borgmatic info/list" #487

New Issue
Closed
opened 2021-12-31 12:00:38 +00:00 by xLogiiCx · 2 comments
xLogiiCx commented 2021-12-31 12:00:38 +00:00
Copy Link

What I'm trying to do and why

Running a before/after-everything hook with borgmatic info / list.
By default my filesystem for Backups is mounted read-only.
When creating a Backup with borg i remount it read-write to create the Backup and then remount it back to read-only.
Works fine for borgmatic create but does not work at all when running info or list.

Steps to reproduce (if a bug)

Actual behavior (if a bug)

user@pc:~$ sudo borgmatic info --verbosity 2 
Ensuring legacy configuration is upgraded
/media/user/borgbackup/pc.borg: Displaying summary info for archives
borg info --debug --show-rc /media/user/borgbackup/pc.borg
using builtin fallback logging configuration
35 self tests completed in 0.05 seconds
Failed to create/acquire the lock /media/user/borgbackup/pc.borg/lock.exclusive ([Errno 30] Read-only file system: '/media/user/borgbackup/pc.borg/lock.exclusive').
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4703, in main
    exit_code = archiver.run(args)
  File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4635, in run
    return set_ec(func(args))
  File "/usr/lib/python3/dist-packages/borg/archiver.py", line 162, in wrapper
    with repository:
  File "/usr/lib/python3/dist-packages/borg/repository.py", line 190, in __enter__
    self.open(self.path, bool(self.exclusive), lock_wait=self.lock_wait, lock=self.do_lock)
  File "/usr/lib/python3/dist-packages/borg/repository.py", line 421, in open
    self.lock = Lock(os.path.join(path, 'lock'), exclusive, timeout=lock_wait, kill_stale_locks=hostname_is_unique()).acquire()
  File "/usr/lib/python3/dist-packages/borg/locking.py", line 359, in acquire
    with self._lock:
  File "/usr/lib/python3/dist-packages/borg/locking.py", line 114, in __enter__
    return self.acquire()
  File "/usr/lib/python3/dist-packages/borg/locking.py", line 138, in acquire
    raise LockFailed(self.path, str(err)) from None
borg.locking.LockFailed: Failed to create/acquire the lock /media/user/borgbackup/pc.borg/lock.exclusive ([Errno 30] Read-only file system: '/media/user/borgbackup/pc.borg/lock.exclusive').
Platform: Linux pc 5.13.0-22-generic #22-Ubuntu SMP Fri Nov 5 13:21:36 UTC 2021 x86_64
Linux: Unknown Linux
Borg: 1.1.17  Python: CPython 3.9.7 msgpack: 0.5.6.+borg1
PID: 198601  CWD: /home/user
sys.argv: ['/usr/bin/borg', 'info', '--debug', '--show-rc', '/media/user/borgbackup/pc.borg']
SSH_ORIGINAL_COMMAND: None
terminating with error status, rc 2
/media/user/borgbackup/pc.borg: Error running actions for repository
Command 'borg info --debug --show-rc /media/user/borgbackup/pc.borg' returned non-zero exit status 2.
/etc/borgmatic/config.yaml: Error running configuration file

summary:
/etc/borgmatic/config.yaml: Error running configuration file
/media/user/borgbackup/pc.borg: Error running actions for repository
...
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4703, in main
    exit_code = archiver.run(args)
  File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4635, in run
    return set_ec(func(args))
  File "/usr/lib/python3/dist-packages/borg/archiver.py", line 162, in wrapper
    with repository:
  File "/usr/lib/python3/dist-packages/borg/repository.py", line 190, in __enter__
    self.open(self.path, bool(self.exclusive), lock_wait=self.lock_wait, lock=self.do_lock)
  File "/usr/lib/python3/dist-packages/borg/repository.py", line 421, in open
    self.lock = Lock(os.path.join(path, 'lock'), exclusive, timeout=lock_wait, kill_stale_locks=hostname_is_unique()).acquire()
  File "/usr/lib/python3/dist-packages/borg/locking.py", line 359, in acquire
    with self._lock:
  File "/usr/lib/python3/dist-packages/borg/locking.py", line 114, in __enter__
    return self.acquire()
  File "/usr/lib/python3/dist-packages/borg/locking.py", line 138, in acquire
    raise LockFailed(self.path, str(err)) from None
borg.locking.LockFailed: Failed to create/acquire the lock /media/user/borgbackup/pc.borg/lock.exclusive ([Errno 30] Read-only file system: '/media/user/borgbackup/pc.borg/lock.exclusive').
Platform: Linux pc 5.13.0-22-generic #22-Ubuntu SMP Fri Nov 5 13:21:36 UTC 2021 x86_64
Linux: Unknown Linux
Borg: 1.1.17  Python: CPython 3.9.7 msgpack: 0.5.6.+borg1
PID: 198601  CWD: /home/user
sys.argv: ['/usr/bin/borg', 'info', '--debug', '--show-rc', '/media/user/borgbackup/pc.borg']
SSH_ORIGINAL_COMMAND: None
terminating with error status, rc 2
Command 'borg info --debug --show-rc /media/user/borgbackup/pc.borg' returned non-zero exit status 2.

Need some help? https://torsion.org/borgmatic/#issues

Expected behavior (if a bug)

Borgmatic should run the before_everything and the after_everything for all commands including "info" and "list".

Environment

borgmatic version: 1.5.13.dev0

borgmatic installation method: Ubuntu Package

Borg version: borg 1.1.17

Python version: Python 3.9.7

operating system and version: Ubuntu 21.10 x86_64

#### What I'm trying to do and why Running a before/after-everything hook with borgmatic info / list. By default my filesystem for Backups is mounted read-only. When creating a Backup with borg i remount it read-write to create the Backup and then remount it back to read-only. Works fine for borgmatic create but does not work at all when running info or list. #### Steps to reproduce (if a bug) #### Actual behavior (if a bug) ``` user@pc:~$ sudo borgmatic info --verbosity 2 Ensuring legacy configuration is upgraded /media/user/borgbackup/pc.borg: Displaying summary info for archives borg info --debug --show-rc /media/user/borgbackup/pc.borg using builtin fallback logging configuration 35 self tests completed in 0.05 seconds Failed to create/acquire the lock /media/user/borgbackup/pc.borg/lock.exclusive ([Errno 30] Read-only file system: '/media/user/borgbackup/pc.borg/lock.exclusive'). Traceback (most recent call last): File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4703, in main exit_code = archiver.run(args) File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4635, in run return set_ec(func(args)) File "/usr/lib/python3/dist-packages/borg/archiver.py", line 162, in wrapper with repository: File "/usr/lib/python3/dist-packages/borg/repository.py", line 190, in __enter__ self.open(self.path, bool(self.exclusive), lock_wait=self.lock_wait, lock=self.do_lock) File "/usr/lib/python3/dist-packages/borg/repository.py", line 421, in open self.lock = Lock(os.path.join(path, 'lock'), exclusive, timeout=lock_wait, kill_stale_locks=hostname_is_unique()).acquire() File "/usr/lib/python3/dist-packages/borg/locking.py", line 359, in acquire with self._lock: File "/usr/lib/python3/dist-packages/borg/locking.py", line 114, in __enter__ return self.acquire() File "/usr/lib/python3/dist-packages/borg/locking.py", line 138, in acquire raise LockFailed(self.path, str(err)) from None borg.locking.LockFailed: Failed to create/acquire the lock /media/user/borgbackup/pc.borg/lock.exclusive ([Errno 30] Read-only file system: '/media/user/borgbackup/pc.borg/lock.exclusive'). Platform: Linux pc 5.13.0-22-generic #22-Ubuntu SMP Fri Nov 5 13:21:36 UTC 2021 x86_64 Linux: Unknown Linux Borg: 1.1.17 Python: CPython 3.9.7 msgpack: 0.5.6.+borg1 PID: 198601 CWD: /home/user sys.argv: ['/usr/bin/borg', 'info', '--debug', '--show-rc', '/media/user/borgbackup/pc.borg'] SSH_ORIGINAL_COMMAND: None terminating with error status, rc 2 /media/user/borgbackup/pc.borg: Error running actions for repository Command 'borg info --debug --show-rc /media/user/borgbackup/pc.borg' returned non-zero exit status 2. /etc/borgmatic/config.yaml: Error running configuration file summary: /etc/borgmatic/config.yaml: Error running configuration file /media/user/borgbackup/pc.borg: Error running actions for repository ... Traceback (most recent call last): File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4703, in main exit_code = archiver.run(args) File "/usr/lib/python3/dist-packages/borg/archiver.py", line 4635, in run return set_ec(func(args)) File "/usr/lib/python3/dist-packages/borg/archiver.py", line 162, in wrapper with repository: File "/usr/lib/python3/dist-packages/borg/repository.py", line 190, in __enter__ self.open(self.path, bool(self.exclusive), lock_wait=self.lock_wait, lock=self.do_lock) File "/usr/lib/python3/dist-packages/borg/repository.py", line 421, in open self.lock = Lock(os.path.join(path, 'lock'), exclusive, timeout=lock_wait, kill_stale_locks=hostname_is_unique()).acquire() File "/usr/lib/python3/dist-packages/borg/locking.py", line 359, in acquire with self._lock: File "/usr/lib/python3/dist-packages/borg/locking.py", line 114, in __enter__ return self.acquire() File "/usr/lib/python3/dist-packages/borg/locking.py", line 138, in acquire raise LockFailed(self.path, str(err)) from None borg.locking.LockFailed: Failed to create/acquire the lock /media/user/borgbackup/pc.borg/lock.exclusive ([Errno 30] Read-only file system: '/media/user/borgbackup/pc.borg/lock.exclusive'). Platform: Linux pc 5.13.0-22-generic #22-Ubuntu SMP Fri Nov 5 13:21:36 UTC 2021 x86_64 Linux: Unknown Linux Borg: 1.1.17 Python: CPython 3.9.7 msgpack: 0.5.6.+borg1 PID: 198601 CWD: /home/user sys.argv: ['/usr/bin/borg', 'info', '--debug', '--show-rc', '/media/user/borgbackup/pc.borg'] SSH_ORIGINAL_COMMAND: None terminating with error status, rc 2 Command 'borg info --debug --show-rc /media/user/borgbackup/pc.borg' returned non-zero exit status 2. Need some help? https://torsion.org/borgmatic/#issues ``` #### Expected behavior (if a bug) Borgmatic should run the before_everything and the after_everything for all commands including "info" and "list". #### Environment **borgmatic version:** 1.5.13.dev0 **borgmatic installation method:** Ubuntu Package **Borg version:** borg 1.1.17 **Python version:** Python 3.9.7 **operating system and version:** Ubuntu 21.10 x86_64
Alexander-Shukaev commented 2021-12-31 12:36:37 +00:00
Copy Link

See #427 regarding --bypass-lock as another (perhaps better) way to solve this issue. In short, for such read-only operations you don't even need a lock.

See #427 regarding `--bypass-lock` as another (perhaps better) way to solve this issue. In short, for such read-only operations you don't even need a lock.
witten commented 2022-04-22 05:19:36 +00:00
Owner
Copy Link

Thanks for filing this, but it looks like it's a duplicate of #463. I'll close this in favor of that ticket, but please feel free to follow along there.

Thanks for filing this, but it looks like it's a duplicate of #463. I'll close this in favor of that ticket, but please feel free to follow along there.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#487
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?