Missing source_dir = fatal error #121
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#121
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On borgmatic 1.2.0
I have two confs in borgmatic.d/
If I run borgmatic with a missing source dir, I get this error:
/my_scripts: [Errno 2] No such file or directory: '/my_scripts'
Ok fine, but other directories exist.
So the rest of the output is hard to decipher but I get this too:
and then the second config is not ran
So I guess a missing source_dir fails everything, but that doesn't seem right, it should still work for other dirs, no?
note: also what about some colors in the verbose output??
@witten
If I'm reading this correctly, I'm not sure there's a whole lot we can do about this limitation as the borgmatic level. That's because we pass the entire list of source directories to a single Borg invocation as part of creating a single backup archive, and Borg either succeeds or fails the whole invocation, based on whether any errors occur (such as the one you're seeing above).
You might consider filing a ticket on the Borg project if you'd like it to support (optionally) plowing through even if particular source directories don't exist.
Colors in the verbose output is a neat idea! I recommend filing that as a separate borgmatic ticket, ideally with some ideas on how you'd like it colored.
Original issue seems to be linked to this witten/borgmatic#116
It's certainly related to #116, but the difference is that with separate config files, borgmatic issues separate Borg invocations. And so we have a little more latitude to handle errors together or independently. But with a single config file and thus a single Borg invocation, we can't selectively bypass failure on individual source directories. Please let me know if I'm missing something here.. Otherwise I think I'll need to close this! Thanks.
I think you mixed two of my issues together witten, but not sure.
In this one I'm just reporting that it stops after 1 configuration failed.
I see.. So you have multiple configuration files? And borgmatic exits after one of the configuration files fails? If so, that should be fixed by #116 if you upgrade to borgmatic 1.2.14.
If that's not the case, then can you provide a little more detail about your configuration and expected versus actual behavior? Thanks.
Ok, not sure how to retest this but yes, I updated to 1.2.14 since then so it should be fine?
If you wanted to try to reproduce this, you could add an intentional error into one of your configuration files so as to induce an error when processing that config file. For instance, changing the repository to a path that doesn't exist.
But yes, upgrading to 1.2.14 should hopefully fix that case.
Yes, I confirm it's working. But at the end it says the error right?
/etc/borgmatic.d/config_for_databases.yaml: Error running configuration file
That's correct!