Remove obnoxious log message when Healthchecks hook sends failure for check action.

borgmatic/hooks/healthchecks.py

@@ -53,9 +53,8 @@ def format_buffered_logs_for_payload():
             if isinstance(handler, Forgetful_buffering_handler)
         )
     except StopIteration:
-        payload = 'Cannot find the log handler for sending logs to Healthchecks'
+        # No handler means no payload.
-        logger.warning(payload)
+        return ''
-        return payload
 
     payload = ''.join(message for message in buffering_handler.buffer)
 

tests/unit/hooks/test_healthchecks.py

@@ -46,14 +46,14 @@ def test_format_buffered_logs_for_payload_inserts_truncation_indicator_when_logs
     assert payload == '...\nfoo\nbar\n'
 
 
-def test_format_buffered_logs_for_payload_without_handler_produces_payload_anyway():
+def test_format_buffered_logs_for_payload_without_handler_produces_empty_payload():
     flexmock(module.logging).should_receive('getLogger').and_return(
         flexmock(handlers=[module.logging.Handler()])
     )
 
     payload = module.format_buffered_logs_for_payload()
 
-    assert payload
+    assert payload == ''
 
 
 def test_ping_monitor_hits_ping_url_for_start_state():