Archived
1
0
Commit Graph

585 Commits

Author SHA1 Message Date
Dan Helfman
4817f286bf Make invisible iframe have zero height as well, so it doesn't add blank space at the bottom of the page. 2009-01-23 14:49:03 -08:00
Dan Helfman
bdfc5d3740 Removing FIXME comment that was recently fixed. 2009-01-23 14:38:29 -08:00
Dan Helfman
8cd63ee661 Only adding black focused border to iframes, not static divs. 2009-01-23 14:36:12 -08:00
Dan Helfman
403ce9d305 Fixed cursor positioning at the end of an iframe's text to work in more edge cases. 2009-01-23 14:25:24 -08:00
Dan Helfman
5e7cd17e82 Fix for range start/end not being propagated to iframe. 2009-01-23 12:12:38 -08:00
Dan Helfman
a90a2a842e Got highlight working again with the new shared iframes. 2009-01-22 22:36:24 -08:00
Dan Helfman
51a568c39c Several fixes for shared iframe releasing / focus interaction. 2009-01-22 22:33:32 -08:00
Dan Helfman
59f9134a8c Now blurring the focused editor when hiding/deleting any other editor.
This prevents a visual bug in which the iframe below a shutdown() editor didn't move to its new position.
2009-01-22 16:54:56 -08:00
Dan Helfman
5ce7de4f1d Opening existing notes from note links now works correctly. 2009-01-22 15:41:00 -08:00
Dan Helfman
623dbbdb3a Wiki.js no longer references Editor.iframe directly. 2009-01-22 15:30:17 -08:00
Dan Helfman
efc452dbfb Fix iframe blindUp() call so it doesn't break getSelection() within the iframe. 2009-01-22 14:53:46 -08:00
Dan Helfman
6438d34e97 Removing debugging print. 2009-01-22 14:27:01 -08:00
Dan Helfman
1658d43d4c Now when an editor is focused, the toolbar buttons update accordingly. 2009-01-22 14:23:07 -08:00
Dan Helfman
f3ca7bc677 Removing obsolete "FIXME" comment. 2009-01-22 13:51:19 -08:00
Dan Helfman
c97613490e Fixing some assumptions in Wiki.js that there are multiple iframes. 2009-01-22 13:30:00 -08:00
Dan Helfman
72c485a799 Not doing a blindUp() on an editor's iframe unless it actually has one. 2009-01-22 13:19:40 -08:00
Dan Helfman
56c7f8ea11 Fixing vertical height of new (empty) frames. 2009-01-22 13:16:25 -08:00
Dan Helfman
46d28d0ea0 Better window resizing behavior. 2009-01-22 13:05:18 -08:00
Dan Helfman
f5727d6383 An editor's iframe and div now blindUp in unision when the note is hidden/shutdown. 2009-01-22 12:15:32 -08:00
Dan Helfman
58827c4ebd More work on the reusable iframe. Now visually appears seamless. 2009-01-22 12:08:20 -08:00
Dan Helfman
9fa3cf2001 Resizing new iframe on load. 2009-01-21 13:43:45 -08:00
Dan Helfman
4e4a8ecd20 Removing duplicate focusing code. 2009-01-21 13:40:21 -08:00
Dan Helfman
10e2742ec5 Removing debugging print. 2009-01-21 13:36:14 -08:00
Dan Helfman
a05081166a Refactored Editor to use a reusable iframe for all notes. Also got cursor positioning working in Firefox.
Still needs more cleanup/bugfixing.
2009-01-21 13:33:11 -08:00
Dan Helfman
2e3501f5fc Adding fix for stupid IE 6 HTTPS warning message. 2009-01-19 22:47:43 -08:00
Dan Helfman
6df7b734e7 Fix for another IE 6 error. 2009-01-15 19:14:07 -08:00
Dan Helfman
d212797f7d Fix for IE6 error. 2009-01-15 19:06:05 -08:00
Dan Helfman
4a8e98372d Refactored some of the click position code. 2009-01-15 14:33:54 -08:00
Dan Helfman
404956deec In IE, you can now click on a static note div, and after it's converted into an iframe, the text cursor will be in the right position! 2009-01-15 01:36:32 -08:00
Dan Helfman
cb3d262630 Text cursor in IE is now correctly positioned at the end of the iframe contents when a new iframe is opened. 2009-01-14 16:37:02 -08:00
Dan Helfman
4871d96f84 Fixing the padding within iframes within various browsers. 2009-01-13 16:12:34 -08:00
Dan Helfman
76e35cbbb9 Changing the way editor resizing works in Webkit (Chrome/Safari) so that it actually works properly. 2009-01-13 14:14:03 -08:00
Dan Helfman
2516f30625 IE really doesn't like those extra commas. 2009-01-13 13:52:26 -08:00
Dan Helfman
5ada27ac74 Fixed reverting a note to an old revision. 2009-01-13 13:38:35 -08:00
Dan Helfman
725904ba49 Now blurring in Wiki.editor_focused() for static divs as well (not just iframes). 2009-01-13 12:35:41 -08:00
Dan Helfman
f4511a8493 Fixed indentation. 2009-01-13 12:35:12 -08:00
Dan Helfman
ab3e04538c Fixed editor_by_id() function to work correctly when a revision is given and a static div editor is returned. 2009-01-13 12:20:36 -08:00
Dan Helfman
53bff5980d Removed some iframe CSS that wasn't actually used in iframes, such as CSS for forms, buttons, etc. 2009-01-12 17:06:44 -08:00
Dan Helfman
5eb1aff6a2 Prevent double-connection of note controls to click signal handlers. 2009-01-12 16:44:28 -08:00
Dan Helfman
9a0650e946 Fix for spurious exception. 2009-01-12 16:37:03 -08:00
Dan Helfman
4e31959dfd Fixing note highlighting when opening an old revision of a note. 2009-01-12 16:24:52 -08:00
Dan Helfman
a6540e6da3 Ignore mouse hover events for static div notes, thereby preventing link pulldown from opening. 2009-01-12 16:00:24 -08:00
Dan Helfman
59be7cc79d Fixed more focusing issues. 2009-01-12 14:49:45 -08:00
Dan Helfman
d6611c1029 Fix for several note focusing problems. Also converted more of Wiki.js not to rely on an editor having an iframe. 2009-01-12 14:19:32 -08:00
Dan Helfman
b25cc97308 Fix for broken focusing. 2009-01-09 17:15:07 -08:00
Dan Helfman
6e1908a66a Renamed finish_init() to connect_handlers() and made it work with create_div(). Made read-only editors stay divs, never iframes.
Added an OPERA constant to indicate when running in Opera.
2009-01-09 16:43:33 -08:00
Dan Helfman
28dc92ad21 Fixed a cut and paste error in Wiki.js initialization code. 2009-01-09 14:54:51 -08:00
Dan Helfman
36e1843f66 Setting a slight delay on the resize so that it works properly. 2009-01-09 14:35:47 -08:00
Dan Helfman
f36d6b9500 Creating a new iframe (where this is no static div) now works again. 2009-01-09 13:17:33 -08:00
Dan Helfman
4f5825c862 Editor.summarize() now supports static note divs. 2009-01-09 13:12:03 -08:00
Dan Helfman
28b2dbe469 Editor.shutdown() now supports static div notes, not just iframes. 2009-01-09 13:10:33 -08:00
Dan Helfman
9dfe196dc7 Editor.highlight() now supports static div notes, not just iframes. 2009-01-09 13:05:42 -08:00
Dan Helfman
7442f46de2 The transition from a static note div to a design-mode-enabled iframe now appears visually seamless. 2009-01-09 12:27:00 -08:00
Dan Helfman
d5b0351bb4 Rewrote Editor.empty() to rely on scrapeText() again. 2009-01-08 12:42:00 -08:00
Dan Helfman
c40a180a5d Now properly resizing a note if you cut/paste text in it with the mouse. Only works in FF3. 2009-01-07 17:14:22 -08:00
Dan Helfman
2d728b584d Fixing Editor.empty() and getting rid of now unnecessary iframe onreload (which had the unwanted side effect of scrolling the page to the top for every iframe). 2009-01-07 15:14:58 -08:00
Dan Helfman
f0da74b8ed Made use of a new normalize_title() function that's responsible for returning "untitled note" as appropriate. 2009-01-07 14:15:22 -08:00
Dan Helfman
dbc095030c Making new notes start off in title mode. Also making the cursor of a new iframe start at the end of the contents. 2009-01-07 13:51:02 -08:00
Dan Helfman
19a24d9d78 Fixed Editor.dirty() and Editor.mark_clean() to deal with divs in addition to iframes. 2009-01-07 12:57:51 -08:00
Dan Helfman
b0202e785b More padding at the top of each frame/div. 2009-01-07 12:43:16 -08:00
Dan Helfman
55362cd4b1 Now properly stripping off / adding "static_note_contents" span when switching between iframe/div. 2009-01-07 12:39:48 -08:00
Dan Helfman
b2eaa5a168 Don't blur an iframe as soon as the focus leaves, but rather when another editor is focused. This makes the toolbar work again. 2009-01-06 16:28:01 -08:00
Dan Helfman
087723ebdd Improved iframe initialization code. 2009-01-06 16:20:04 -08:00
Dan Helfman
e043cf1e0c Pulled in and merged most recent revision with iframes-on-demand changes. 2009-01-03 15:56:54 -08:00
Dan Helfman
c07794377d Work towards iframes-on-demand. 2009-01-03 15:52:12 -08:00
Dan Helfman
ad96bbff86 Fixed a bug in which renaming the first post in a disussion didn't rename the discussion itself.
Also fixed a bug in which clicking on the notebook rename text field ended the renaming prematurely.
2008-12-27 01:28:38 -08:00
Dan Helfman
12bd7b2640 Centering the font pulldown selected mark dot is difficult, so instead just vertically align it to the top. 2008-12-27 00:32:37 -08:00
Dan Helfman
290391899c Fixed a bug in which fonts set in one browser did not always show up as selected within a different browser. 2008-12-27 00:09:54 -08:00
Dan Helfman
80432f3cbb Renamed "Sans Serif" to "Arial", "Serif" to "Times New Roman", etc. 2008-12-26 19:51:34 -08:00
Dan Helfman
4d7b08ef32 Fixed broken font selection in IE. Now using a button tag instead of a <label> to make IE happy. 2008-12-26 19:32:12 -08:00
Dan Helfman
d61b6f16ea Backed out patch that dropped support for IE 6 (for now), since it may not actually be necessary yet. 2008-12-23 23:20:24 -08:00
Dan Helfman
712a2dee6b Dropped support for Internet Explorer version 6.0! Time to break out the champagne. 2008-12-23 19:31:08 -08:00
Dan Helfman
8d37ad2a3f Adding the title button back to the toolbar, since it's really essential if a note has no title. 2008-12-23 00:27:44 -08:00
Dan Helfman
74db4e8164 Fixed current font indication in IE. 2008-12-22 23:26:01 -08:00
Dan Helfman
1f3b50704e If a pulldown is partially off the bottom of the window, move it up until it isn't obscured any longer. 2008-12-22 22:14:16 -08:00
Dan Helfman
f68d571e68 Indication of current font now works in WebKit (Safari/Chrome). 2008-12-22 19:25:09 -08:00
Dan Helfman
7254dc6972 Changed font selector check mark to a bullet point / circle. And font selector now works in IE. 2008-12-17 12:15:08 -08:00
Dan Helfman
f385ebaa9c In the font pulldown, now showing the current font with a check mark. 2008-12-15 18:10:38 -08:00
Dan Helfman
461ae4f467 Got rid of auto-hiding notebook "rename" link, since it didn't work reliably. The link is now back in the link area on the left. 2008-12-14 23:28:43 -08:00
Dan Helfman
d687d2b1c8 Vertically compacted the link area on the left somewhat. "rename" hover link no longer showing up on read-only/trash notebooks. 2008-12-13 00:32:19 -08:00
Dan Helfman
c07d315ffe Replaced title button with font face button. Needs more work in IE. Also added more rounded corners to several display elements. 2008-12-10 23:21:44 -08:00
Dan Helfman
bceedf8edd Removing code that surpressed backspaces, since it breaks backspaces on the search field too. 2008-12-03 17:14:49 -08:00
Dan Helfman
3da951b0ba Fixed an Internet Explorer bug in which backspace sometimes didn't work, such as when backspacing an empty list element. 2008-12-03 16:27:01 -08:00
Dan Helfman
033833b00b Link pulldowns opened via mouse hovering will now disappear when the mouse is moved away. 2008-12-03 15:42:08 -08:00
Dan Helfman
929d27035a Changed the "new note" key from ctrl-N to ctrl-M so as not to conflict with the "new browser window" key used in most web browsers. 2008-12-03 15:11:49 -08:00
Dan Helfman
0b2b0ec69e Fixed a rare Chrome/Safari bug in which pressing backspace sometimes made the text cursor vanish. 2008-12-03 14:50:53 -08:00
Dan Helfman
cfdd666c5f Fixed a Chrome/Safari bug in which ending a link didn't always work.
Specifically, in a list of two elements in which each element was a link,
clicking right after the first element and then pressing ctrl-L to end the
link didn't work as expected. Now it does.
2008-12-03 13:10:18 -08:00
Dan Helfman
db1435c7c1 Began work to make only the currently focused note an iframe, while all other notes are static divs. 2008-12-02 11:42:57 -08:00
Dan Helfman
6e52384d46 Fixed a bug that prevented deleted notes from being displayed within the trash. 2008-11-24 16:58:59 -08:00
Dan Helfman
54744dd3a9 Fixed a rare bug in which Luminotes sometimes indicated that the current note was saved even when it wasn't.
Fortunately, this was just a visual bug, and the current note was always saved correctly.

The reproduction steps were:

 1. Open two notes, A and B.
 2. Modify note A, and then switch to note B. This causes note A to save.
 3. The save happens to take a long time (which you can force with a sleep).
 4. While the save is executing, quickly modifiy note B.
 5. When the original save completes, the "save" button changes to "saved",
    even though note B has been modified and is not saved.

The solution was simply to check whether the focused note is dirty before changing to a "saved" button.
2008-11-21 12:56:06 -08:00
Dan Helfman
3c11526480 Fixed a bug that prevented the autosaver from working on non-forum notebooks. 2008-11-20 17:39:20 -08:00
Dan Helfman
4c3d374062 Fixes for IE 6. 2008-11-18 16:16:52 -08:00
Dan Helfman
7a3da18fe0 Typo fix. 2008-11-17 22:59:57 -08:00
Dan Helfman
9dec0ae991 Fixed a bug in which the storage usage area was trying to be accessed even if it wasn't present. 2008-11-17 14:45:10 -08:00
Dan Helfman
4dc93c230b In several places, UI now looks at notebook forum tag instead of READ_WRITE_FOR_OWN_NOTES permissions of notebook. 2008-11-17 13:33:21 -08:00
Dan Helfman
4775d6df98 Removed the "changes" tab from your own notes in the discussion forums, since it didn't work there anyway due to a redirect. 2008-11-14 22:52:54 -08:00
Dan Helfman
968266079c Fixed a visual bug in which undoing the deletion of a note didn't always make the note reappear, even though the undeletion always worked. 2008-11-14 17:01:55 -08:00
Dan Helfman
e7038bfb1f You can now add an existing note directly to the note tree, instead of having to click "options" -> "show on startup". 2008-11-14 16:51:35 -08:00
Dan Helfman
45c40a44af Helpful <title> text on add-note-to-note-tree note name field. 2008-11-14 15:41:18 -08:00
Dan Helfman
68de634b38 Rearranged the links on the left and right side of the wiki editing page. Added an "add note to note tree" button that's not quite complete. 2008-11-14 12:34:06 -08:00
Dan Helfman
69987e08d9 Emphasizing that signing up for an account in order to post in the forums is free. 2008-11-12 15:21:40 -08:00
Dan Helfman
f632e109cd No longer displaying annoying warning messages about Safari/Chrome support being considered "beta". 2008-11-11 22:38:53 -08:00
Dan Helfman
d5efdf2665 Fixed a bug in IE in which clicking a link sometimes caused the browser window to scroll down and then immediately back up. 2008-11-11 11:40:26 -08:00
Dan Helfman
25b2f2fe84 Added permalinks to blog and discussion forum posts. 2008-11-10 12:32:52 -08:00
Dan Helfman
5b556d03cf Fixed a bug in which autosave did not cause the "notes" and "recent updates" links to rename if necessary. 2008-11-05 16:13:26 -08:00
Dan Helfman
23bff4d6b2 For forum threads, redirect from /notebooks/... URLs to corresponding /forums/... URLs. 2008-10-31 15:55:08 -07:00
Dan Helfman
dccab45de3 The username of the author of a forum post now shows up in the UI. 2008-10-30 16:53:42 -07:00
Dan Helfman
c636850cf0 Some code to tack on a byline to all notes with a creation timestamp, and then remove that byline when you focus a note to edit it. 2008-10-30 16:16:26 -07:00
Dan Helfman
b4a40d2c25 More work on the discussion forums. 2008-10-30 15:26:27 -07:00
Dan Helfman
d62b885e46 Bug fix for when you load a notebook and it has several notes, the page scrolls to part-way down the page after all the iframes load. 2008-10-30 14:57:27 -07:00
Dan Helfman
bce99c26bc New forum thread creation code, plus a re-working of URLs under "/forums/" 2008-10-28 14:07:49 -07:00
Dan Helfman
d1e257a4c2 Fixed typo. 2008-10-27 16:34:12 -07:00
Dan Helfman
21a05befe0 More forum-specific stuff. 2008-10-27 16:23:27 -07:00
Dan Helfman
388f2fcb02 Foundational work for both tags and discussion forums. Should have checked this in in smaller pieces. 2008-10-24 11:51:19 -07:00
Dan Helfman
5310a6916b Magic number to make Safari put links in the right location. 2008-10-08 23:44:25 -07:00
Dan Helfman
489cc08783 Safari/Chrome: Uploading files now works reliably instead of just once. Apparently WebKit caches iframe src URLs! 2008-10-08 17:09:13 -07:00
Dan Helfman
a1ffcfb9b8 Safari/Chrome: Pulldowns on inline images are now positioned correctly. 2008-10-08 14:56:01 -07:00
Dan Helfman
bd0fc7b461 Adding a beta support message for Chrome and Safari. 2008-10-07 16:52:05 -07:00
Dan Helfman
872d636ad4 Note resizing (growing and shrinking) now works as expected in Safari/Chrome. Shrinking didn't work before this fix. 2008-10-07 16:39:49 -07:00
Dan Helfman
8c7f05801c Modified the WebKit pulldown positioning code so that changes and options pulldowns show up in the correct location. 2008-10-07 14:52:32 -07:00
Dan Helfman
abd5a2a189 Pulldowns for search suggestions, importing, and exporting now show up. Worked around yet another WebKit bug/misfeature. 2008-10-06 17:56:41 -07:00
Dan Helfman
5944d1f20d Fixed bug in Safari/Chrome in which hiding an empty note caused it to get saved and end up in the "recent updates". 2008-10-06 15:48:32 -07:00
Dan Helfman
0d371cc490 Remove Safari/Chrome warning message, since hopefully they'll be supported by the time this release is done. 2008-10-06 15:47:19 -07:00
Dan Helfman
b19f488d90 Now also removing WebKit-generated <font> tags that result from titling/untitling note text. 2008-10-06 15:35:38 -07:00
Dan Helfman
317a79456c Underline and strikethrough now work in Chrome/Safari. Accomplished this by rewriting WebKit-generated HTML in realtime. 2008-10-06 15:09:13 -07:00
Dan Helfman
e2996030ac WebKit-specific hack to make the horizontal line under the title show up correctly. 2008-10-03 00:11:40 -07:00
Dan Helfman
41dade9f28 Safari/Chrome notes now start out in title mode (again). 2008-10-02 23:59:39 -07:00
Dan Helfman
a0b189695c You can now create and end links from within Safari/Chrome.
This involve changing the non-IE portion of Editor.insert_link() to use a different sort of title placeholder hack.
Also, as part of this commit, Editor now determines browser type once instead of for every Editor created.
2008-10-02 23:08:56 -07:00
Dan Helfman
fc925a36f8 Changing debugging display of note contents as HTML to use display_message() instead of alert(). 2008-10-02 23:02:08 -07:00
Dan Helfman
2e5ec59c2b Changed the warning about Safari/Chrome/Opera incompatibility to be an in-page message instead of a popup alert so as to be slightly less obnoxious. 2008-09-30 12:58:39 -07:00
Dan Helfman
80a0250c95 Fixed a bug in which clicking the "export" link when the current note was unsaved did not open the export pulldown. 2008-09-29 23:09:44 -07:00
Dan Helfman
968ef22bc4 Implemented CSV exporting, and improved CSV importing to better handle the exported CSV files.
Importing still needs work on properly handling internal note links.
2008-09-17 23:39:11 -07:00
Dan Helfman
c8e910b43a Made it clearer when reverting a note what's going on. Now opening the reverted note if it's not yet open, or highlighting it if it is open. 2008-09-08 15:44:24 -07:00
Dan Helfman
e06579c881 In the revision changes pulldown, no longer showing "by desktopuser" in Luminotes Desktop. 2008-09-08 15:29:16 -07:00
Dan Helfman
573b06fc01 Removed JavaScript unit/functional tests since they weren't really maintained. At least there are several hundred Python unit tests. 2008-08-20 02:06:14 -07:00
Dan Helfman
c37e35b042 Fixed a rare bug in which undeleting a note via "undo" sometimes does not show the undeleted note even if the undelete is successful. 2008-08-13 13:34:30 -07:00
Dan Helfman
c5b916885a When clearing pulldowns, preventing use of pulldown div if it has no pulldown member. 2008-08-13 13:02:07 -07:00
Dan Helfman
c6dbeffc10 Fixed a bug in which the character encoding of uploaded CSV files was not properly detected and used to decode the file.
Note that this fix introduces a new dependency: http://chardet.feedparser.org/ found in the python-chardet package.
2008-08-11 22:53:01 -07:00
Dan Helfman
5ef02e5c0c Fixed a bug in Firefox 3 in which disabling title text did not work. Fixed a bug in Firefox 2 and 3 so enter consistently inserts the same tag. 2008-08-11 20:37:20 -07:00
Dan Helfman
e844091cdc "There isn't a title column." -> "There is no title column." 2008-08-09 01:05:12 -07:00
Dan Helfman
52f129e571 New notebook import feature for importing notes from a CSV file. (Beta.)
Uses existing file upload mechanism with slightly modified UI to upload the file.
Then there's new CSV parsing code to parse the CSV and import it as a new notebook.
Still need a few more unit tests before this feature can be considered complete.
2008-08-08 16:39:53 -07:00
Dan Helfman
b7e07fbc72 Fixed a bug in which renaming a link title and then pressing ctrl-L would replace the link destination. 2008-08-01 15:50:49 -07:00
Dan Helfman
9fed61aae1 Skipping clearing of messages/errors if they haven't been open long enough to read. 2008-07-31 15:50:25 -07:00
Dan Helfman
17b49b404c Increased speed of note hiding animations. 2008-07-30 20:38:20 -07:00
Dan Helfman
a6bbf04dad Fairly large CSS overhaul with the goal of making both the left and right areas position: fixed;
Still works in IE 6 and 7. And of course Firefox. Even appears visually okay in Safari.
2008-07-30 16:49:50 -07:00
Dan Helfman
066ffdb308 Fixed bug where if you click on a (non-dirty) note, add a character, remove the character, and then click the save button, nothing happened.
Now, if save_editor() decides there's no need to actually save the focused note to the server, it disabled the save button as if a save occurred.
2008-07-29 19:05:34 -07:00
Dan Helfman
ac5c8f6174 By popular demand, added a "save" button that becomes grayed out when everything is saved. 2008-07-29 16:38:35 -07:00
Dan Helfman
c04b888646 Now displaying "saving" status text on HTTP POST and "loading" status on GET. 2008-07-29 15:37:12 -07:00
Dan Helfman
953bc5360d On second thought, making scrolling speed even faster (0.25 seconds in duration). 2008-07-29 14:52:23 -07:00
Dan Helfman
3a4030fee5 When scrolling to and then highlighting a note, do so serially instead of in parallel.
Also made speed of scrolling to a note or message slightly faster.
2008-07-29 14:48:54 -07:00