Archived
1
0
Commit Graph

244 Commits

Author SHA1 Message Date
Dan Helfman
6fcec83167 Fixed annoying bug where some unit tests didn't use stub SMTP class and so actually send real email messages. 2008-06-07 17:06:43 -07:00
1ea667528e Wrote unit tests for controller.Users.signup_group_member(). 2008-06-06 16:14:44 -07:00
7ee838d46e controller.Users.remove_group() now resets the removed user's rate plan to 0. Also fixed broken controller.Users.signup().
Updated unit tests.
2008-06-06 15:13:11 -07:00
a8a6070da0 Implemented controller.users.signup_group_member().
Modified UI code to call this method correctly and display results.
Split generic user signup functionality out into a separate private method.
2008-06-06 14:46:29 -07:00
9c923172ab Fixing broken unit test. 2008-06-05 16:00:24 -07:00
0faa06ea10 Called controller.Users.calculate_group_storage() from various places. Fixed model.User.sql_calculate_group_storage(). 2008-06-05 15:59:01 -07:00
a0ca8025d0 New controller.Users.calculate_group_storage(). 2008-06-05 14:16:49 -07:00
0e51e461fa New controller.Users.remove_group() method to remove a user's group membership. 2008-06-03 20:19:07 -07:00
3a9cd0a024 New controller.Groups.update_settings() and associated unit tests. 2008-06-03 16:11:27 -07:00
39ca4c619b Groups.load_users() now returns info on the group itself as well. 2008-06-02 16:03:48 -07:00
79e2c45533 New controller.Groups class and a new controller.Users.check_group() method.
Also a new model.Group.sql_load_users() method.
Lots of unit tests.
2008-05-29 16:36:14 -07:00
df3d170362 View groups that you're a member of, with an indicatation if you're an admin of that group.
- modify controller.Users.current() to return the user's groups
    - update test_current() unit tests to expect empty groups list in results
  - modify Main_page, Notebook_rss, Front_page, Tour_page, and Upgrade_page to accept a new groups parameter
    - Main_page should add it as a hidden HTML variable
  - update Wiki.js to read the hidden groups variable and display the groups in account settings
2008-05-28 16:05:38 -07:00
Dan Helfman
e971959755 Attempting to access the RSS feed for a non-existent notebook now
displays a somewhat informative message in the feed instead of just
silently raising an error.
2008-05-26 23:00:31 -07:00
Dan Helfman
953f572b20 Bug fix: Clear the memcache, search for notes in an main notebook (as the
anonymous user), open a search result from a notebook. Then, login and try to
edit that notebook as a user with read-write privileges. it will show up as
read-only, presumably because it's being read from the cache.
2008-05-19 23:43:33 -07:00
Dan Helfman
ae5c911c1c New multiple-notebook search query was way too slow. Now fixed.
- make model.Notebook.sql_search_notes() search either with user_id or an anonymous user_id, not both
  - update controller.Notebooks.search(), so if the anonymous user has access to the given notebook,
    then run the search as the anonymous user instead of the given user id
  - update unit tests
  - don't search trash/deleted notebooks
2008-05-19 22:36:21 -07:00
Dan Helfman
02a3544590 Search result now return notes from multiple notebooks.
- change model.Notebook.sql_search_notes() to be a static method
   - take a first_notebook_id argument and a user_id argument
   - join user_notebook on notebook_id and matches on user_notebook.user_id instead of notebook_id
   - order by notebook_id = first_notebook desc, rank instead of just rank
   - include search result for notebooks readable by anonymous user, but only if such a notebook is given as first_notebook_id
 - update code that calls model.Notebook.sql_search_notes()
 - update model.Note.to_dict() to include notebook_id
 - modify Wiki.display_search_results()
   - separate search results for the current notebook and results for all other notebooks
   - indicate which notebook each result is from
   - if there are results in other notebooks but no results in the current notebook, indicate that clearly
   - when you click on a result note link in the current notebook, it should simply open a new note
   - when you click on a result note link in another notebook, it should open in a new window
 - test in IE
 - update unit tests for:
   - controller.Notebooks.search()
   - model.Notebook.sql_search_notes()
   - model.Note.to_dict()
2008-05-19 15:16:25 -07:00
Dan Helfman
20995d3b2e Added support for database hostname and ssl mode in configuration file. 2008-05-16 14:12:01 -07:00
Dan Helfman
8b705ec4c3 In send_invites(), no longer implicitly assuming rate plan 0 has
notebook_collaboration set to False.
2008-05-08 23:17:17 +00:00
Dan Helfman
0323f6bc91 Passing new yearly parameter to main page. 2008-05-08 19:29:11 +00:00
Dan Helfman
a6baa45435 Made signup support yearly subscriptions. 2008-05-08 19:14:39 +00:00
Dan Helfman
269c28983d Support for yearly subscriptions. 2008-05-08 18:39:46 +00:00
Dan Helfman
18982dc129 Implemented basic user account settings. Now you can change your email
address.
2008-05-08 03:05:35 +00:00
Dan Helfman
70f52a7406 Fixed a bug where an invite sent for a notebook with an accented unicode
name would cause a UnicodeEncodeError upon sending the invite email. Now
such invites are encoded as quoted-printable UTF-8, while other invites
continue to be 7-bit ASCII.
2008-05-06 23:29:43 +00:00
Dan Helfman
bb77cefeaa Possibly fixed a bug where IE 7 would fail to download as HTML via HTTPS
due to cache issues. The fix entailed using a new @weakly_expire decorator
on controller.Notebooks.download_html().
2008-05-06 21:41:00 +00:00
Dan Helfman
8bed4a7f4d Fixed a bug where the Valid_id() validator would raise a TypeError when
given a None value. Now raising a ValueError instead.
2008-05-05 23:32:45 +00:00
Dan Helfman
1d17ea4eff Fixed a bug where attempting to load a notebook preview without access
would give a "list index out of range" error instead of an access error.
2008-05-05 23:10:26 +00:00
Dan Helfman
1095e509de Fixed yet another diff-breaking edge case. This one had to do with
inserting italicized text right before some existing italicized text.
2008-05-03 07:40:46 +00:00
Dan Helfman
570e0ade77 More diff fixes. This time for "<br/>" tags. 2008-05-03 06:10:09 +00:00
Dan Helfman
94fdd08cf4 * Fixed a bug that prevented diffs from working for notes with links.
* Made CSS for links within <del> or <ins> red or green, respectively.
2008-05-03 05:36:28 +00:00
Dan Helfman
97c373561d * Added replace_contents() to model.Note to set the contents without updating the revision or anything else.
* Added new optional previous_revision params to default(), contents() and load_note() in controller.Notebooks.
   These use Html_differ() to generate and return diffs.
 * Updated Wiki.js:
   * provide previous_revision when a revision is opened in a new window/tab
   * call load_note() when two revisions when a revision is clicked in Changes_pulldown
   * update compare_versions() to display a diff instead of opening the two revisions separately
   * update load_editor():
     * update all invocations of load_editor(), including in Editor.js, to accept a new previous_revision argument
     * modify load_editor() to use the previous_revision argument (when supplied) to load a diff
2008-05-03 04:29:23 +00:00
Dan Helfman
42ae3e0ba1 Completed Html_differ unit tests. 2008-05-02 23:59:03 +00:00
Dan Helfman
ba89c8116b Updated to handle the following case:
* If a phrase becomes italicized, it should show the non-italic version in red and immediately after, the italic
   version in green.

This required doing a pass on the HTML to merge certain elements together before doing the actual diff.
2008-05-02 21:03:46 +00:00
Dan Helfman
9b2a9db4e9 Implemented new HTML diffing class to produce an HTMLized diff of two HTML
strings. Not perfect yet. For instance, if string a contains "foo bar baz" and
string b contains "foo <i>bar</i> baz", the resulting output does not show
"bar" in strikeout and "<i>bar</i>" in green, as one might expect.
2008-05-02 18:58:36 +00:00
Dan Helfman
e052e3b357 Fixed bug in Html_cleaner which produced broken tags like "<br/>" instead of "<br />" 2008-05-02 18:56:03 +00:00
Dan Helfman
5f852a3d8e Bug fix: Used to get access error when you loaded the children links for a note that was in the trash. 2008-04-29 21:26:09 +00:00
Dan Helfman
b71568b35b Implemented unit tests for controller.Notebooks.load_recent_updates(). 2008-04-29 03:25:38 +00:00
Dan Helfman
1d0867d776 * Renamed existing controller.Notebooks.load_recent_notes method to just recent_notes().
* Implemented new controller.Notebooks.load_recent_updates() method.
 * Added new Wiki.js total_notes_count_updated signal
 * Added "more" and "less" links to "recent updates" table.
 * Updated Wiki.js Recent_notes to support new "more" and "less" links.
 * Commented out unfinished discussion forums unit test.
2008-04-29 00:54:08 +00:00
Dan Helfman
09f771b508 Commenting out discussion forums for now since they're unfinished. 2008-04-25 20:36:01 +00:00
Dan Helfman
011baf2cb4 Adding unfinished Forums controller and associated tests. 2008-04-25 20:34:01 +00:00
Dan Helfman
9c617687bd Fixing comment. 2008-04-25 19:46:42 +00:00
Dan Helfman
ea87c273f9 Added unit tests for new RSS related controller methods.
Setting separator to empty for a few more Rss_item elements.
2008-04-23 02:54:59 +00:00
Dan Helfman
b316b2f4a3 * Increasing after_login max string size from 100 to 1000 to accomodate larger URLs.
* controller.Notebooks now takes (and stores) an https_url constructor parameter.
 * New controller.Notebooks.updates() method to produce an updates RSS feed for a particular notebook.
 * New controller.Notebooks.get_update_link() method to make a brief page with just a link for an updated note, referred to by the feed.
 * Implemented views for the new RSS feed.
 * Fixed bug in Rss_item's guid that caused newlines to be inserted before and after long URLs.
 * Still need to unit test new controller code.
2008-04-22 23:24:30 +00:00
Dan Helfman
d3dce6f775 Sigh. 2008-04-22 20:26:09 +00:00
Dan Helfman
0f30c89ff3 Fixing "local variable 'image_buffer' referenced before assignment" error. 2008-04-22 19:35:33 +00:00
Dan Helfman
b3d5187c6c Fixed bug where calling image.save() with an interlaced PNG file would
raise an IOError. Now just displaying the default thumbnail if that
happens.
2008-04-22 18:34:34 +00:00
Dan Helfman
1ca9af536c Added RSS subscription links for all notebooks. 2008-04-18 20:49:22 +00:00
Dan Helfman
eb587fc44f Fixed bug where recent notes were ordered by creation time instead of revision time. 2008-04-18 20:39:23 +00:00
Dan Helfman
c488864273 * Now if you try to load a page where access is required, and you're not
logged in, you'll be redirected to a login page. After you login, you'll
   be redirected to the page you were originally trying to access.
2008-04-18 19:54:50 +00:00
Dan Helfman
d0a1cbf71d Complete unit tests for controller.Notebooks.load_note_links(). 2008-04-16 08:13:35 +00:00
Dan Helfman
8541c784be Modified tests for controller.Notebooks.default() to test for new "recent_notes" return value. 2008-04-16 07:33:07 +00:00