Archived
1
0
Commit Graph

491 Commits

Author SHA1 Message Date
Dan Helfman
092f3ff9c6 Removed Wiki.js.Upload_pulldown.shutdown() "force" flag as it's redundant if this.uploading is set accordingly.
Make IE 6 and 7 actually stop uploading a file when the cancel button is clicked.
Ignoring blank filename renames.
2008-02-25 21:56:33 +00:00
Dan Helfman
fb7655707e More defensive programming. 2008-02-25 07:19:15 +00:00
Dan Helfman
e6ff9203f3 Fix for a quota error being kicked off from each of the progress bar iframe
and the upload iframe, thereby causing one of them to hit a null
frame.pulldown member in IE 6 and throw a JavaScript error.
2008-02-25 07:13:12 +00:00
Dan Helfman
e283151a9b Visually truncating really long filenames. 2008-02-25 03:23:50 +00:00
Dan Helfman
8dee52a9d8 This public schema comment caused a problem on an install for one user. 2008-02-24 02:31:55 +00:00
Dan Helfman
dcd40eaa45 Tweaked controller.Files.download() to better handle filenames with weird characters. 2008-02-24 01:01:50 +00:00
Dan Helfman
9743859b41 Now correctly allowing large file uploads. 2008-02-24 00:31:07 +00:00
Dan Helfman
bb8442bb03 All unit tests passing again. 2008-02-23 23:57:05 +00:00
Dan Helfman
b7e1b26d3b Unit tests for controller.Files are done! 2008-02-23 23:16:39 +00:00
Dan Helfman
3ed4145ed3 Yet more controller.Files unit tests. 2008-02-23 22:59:36 +00:00
Dan Helfman
4150811d9e Many more controller.Files unit tests. 2008-02-23 22:17:02 +00:00
Dan Helfman
7b76d6371b Additional unit tests. 2008-02-23 08:59:39 +00:00
Dan Helfman
3f5d5d2a89 Implemented several unit tests for controller.Files. 2008-02-23 08:14:19 +00:00
Dan Helfman
e7c96cadf5 Using "link.innerHTML =" instead of replaceChildNodes() to set a file link's
title when uploading a file, as this plays more nicely with IE. With
replaceChildNodes(), IE swallows the text cursor and won't give it back.

Also explicitly passing link parameter to Upload_pulldown() constructor, as
editor.find_link_at_cursor() wasn't always working in IE.
2008-02-22 23:03:10 +00:00
Dan Helfman
36b11805c6 Now purging files from the database/filesystem when notes they're linked from
are deleted from the trash. Also displaying a message when deleting a file
manually via the "delete" button.
2008-02-22 21:08:29 +00:00
Dan Helfman
db1bc247ad Changing file link pattern slightly so that a file link with no title is not counted. 2008-02-22 20:04:23 +00:00
Dan Helfman
65ce915755 When saving a note, auto-delete any files that used to be linked from it but no longer are. Still need unit tests. 2008-02-22 19:47:28 +00:00
Dan Helfman
7b8f6bd6e5 Improved error reporting in the controller.Files.upload() method. Now
correctly displays an error to the user when uploading without a filename or
with an invalid file.
2008-02-21 19:39:03 +00:00
Dan Helfman
6a5481f7d6 Fixed updating and display of storage usage when an uploaded file is deleted. 2008-02-21 03:41:37 +00:00
Dan Helfman
e0c65a6ac4 File deletion now works. Still need unit tests. 2008-02-21 00:41:08 +00:00
Dan Helfman
eb18b6020d File renaming works. Unit tests still pending.
File deleting implemented. Testing and unit tests still pending.
Now releasing session lock at top of download() to prevent session deadlocks.
2008-02-20 23:25:13 +00:00
Dan Helfman
1f223089df Updated to emphasis storage space and mention file uploading. 2008-02-20 20:45:39 +00:00
Dan Helfman
8e4042eea0 Mentioned uploading and downloading files.
Bolded some intro text.
2008-02-20 20:36:47 +00:00
Dan Helfman
fd0e91ea39 Implemented quota enforcement when uploading a file. This occurs in two places:
1. In progress(), around the time when the file starts uploading. This causes
an upload that's too large to bail before the whole file uploads, but the
quota calculation is only an estimate and relies on the client actually
calling progress().

2. In upload(), when the file finishes uploading. This quota calculation is
exact, but only happens after the entire upload completes.
2008-02-20 20:21:54 +00:00
Dan Helfman
3d5baa1e24 * Quota storage calculation now takes uploaded files into account.
* controller.Files.upload() now updates user quota storage.
 * When a file is uploaded, the new storage bytes count is returned to the client and displayed.
2008-02-20 00:57:10 +00:00
Dan Helfman
f6c5071099 Moved HTML streaming progress bar code into view/ where it belongs. 2008-02-19 21:27:14 +00:00
Dan Helfman
ddc58449f8 Now displaying a message when the upload is cancelled. 2008-02-19 21:15:09 +00:00
Dan Helfman
8443f7e5cb Once an upload has started, you can no longer close the Upload_pulldown by
clicking somewhere else. You have to click "cancel". This is to prevent
accidental upload cancellations.
2008-02-19 20:48:43 +00:00
Dan Helfman
a34ffe2dc6 controller.Files.upload() now removes file data from disk upon an aborted upload.
Wiki.js Upload_pulldown() now has an update_position() method that's used when the pulldown is already open.
2008-02-19 20:40:19 +00:00
Dan Helfman
ebf123d052 Now you can close an upload / file link pulldown and end a file link. 2008-02-19 20:25:35 +00:00
Dan Helfman
804332b3e2 I hate the web. 2008-02-19 00:47:59 +00:00
Dan Helfman
b80ad248f9 Fixed to make progress bar and download link work properly in IE 6 and 7. 2008-02-18 23:44:17 +00:00
Dan Helfman
b543121767 Now Content-Type header is saved upon upload and sent upon download. 2008-02-18 20:19:36 +00:00
Dan Helfman
731dc52623 More work on file uploading. Unit tests need to be fixed. 2008-02-18 20:08:07 +00:00
Dan Helfman
43f098cda0 Hard-coding luminotes_title.png image dimensions to improve the way the page looks when it's loading without a cache. 2008-02-07 19:06:34 +00:00
Dan Helfman
1398e89f96 Wrote initial unit tests for new Files controller. A few more still needed. 2008-02-06 01:34:12 +00:00
Dan Helfman
90c83ad1e5 New File_link_pulldown, not yet complete. 2008-02-05 19:45:11 +00:00
Dan Helfman
04f86f05a6 Rewrote controller.Files.upload_file() not to use a CherryPy-2.1-style file upload filter.
Now releasing session lock before streaming the file to prevent session deadlock in the event of a cancelled upload.
2008-02-04 20:06:02 +00:00
Dan Helfman
362a125b1b Working "cancel" button during upload. 2008-02-01 22:44:01 +00:00
Dan Helfman
1bb6b4fcb0 When moving upload_file() from Notebooks to Files, forgot to change streaming
configuration accordingly to reflect the new URL.
2008-02-01 22:39:22 +00:00
Dan Helfman
e56503903b Factored out file upload methods from Notebooks to new Files controller.
Changed file link insertion code to reuse existing link creation code.
2008-02-01 19:17:10 +00:00
Dan Helfman
0cf2b5bda7 Initial work on UI and controller for file uploading:
* new toolbar button for attaching a file
 * button opens new Upload_pulldown() for uploading a file
 * began controller.Notebooks.upload_file() to process the upload
2008-01-31 21:52:32 +00:00
Dan Helfman
6bdacd272e * Replaced a workaround for a Firefox DesignMode bug. The bug causes a jumping
text cursor. The previous workaround involved appending <span> tags and had
   other negative side-effects. The new workaround involves removing extra <br>
   tags.
2008-01-28 20:45:36 +00:00
Dan Helfman
c4a313bf08 Completed conversion of checkbox and radio button text to use HTML <label> tag. 2008-01-26 19:32:22 +00:00
Dan Helfman
329397a681 Converted "share this notebook" access choice radio buttons to use HTML <label> tag. 2008-01-26 00:37:38 +00:00
Dan Helfman
ffd2d15175 Now, if you delete a notebook and the only remaining notebook is read-only,
then a new read-write notebook is created for you automatically. This fixes a
bug where you could delete a notebook and have only a read-only notebook
remaining, thereby having no way to add a new notebook.
2008-01-24 22:02:02 +00:00
Dan Helfman
43f4376821 Gonna release! 2008-01-22 23:36:32 +00:00
Dan Helfman
cb0e9137c9 Fixed several race conditions between save_note() and other note-mutating controller methods. 2008-01-22 23:29:16 +00:00
Dan Helfman
f0325ce58a Even rate plan button value is empty, don't try to use the value. 2008-01-22 22:08:09 +00:00
Dan Helfman
3d039cd14c Whoops.. Didn't mean to checkin modified Common.py config file. Reverting. 2008-01-22 20:31:36 +00:00