Fixed bug where revoke buttons would be created with the same invite_id due to
a closure using a variable within a for-loop.
This commit is contained in:
parent
2bcbc17172
commit
179f7ea4d1
|
@ -214,10 +214,7 @@ Editor.prototype.finish_init = function () {
|
|||
event.stop();
|
||||
} );
|
||||
|
||||
var revoke_buttons = getElementsByTagAndClassName( "input", "revoke_button" );
|
||||
for ( var i in revoke_buttons ) {
|
||||
var revoke_button = revoke_buttons[ i ];
|
||||
var invite_id = revoke_button.id.split( "_" ).pop();
|
||||
function connect_button( revoke_button, invite_id ) {
|
||||
connect( revoke_button, "onclick", function ( event ) {
|
||||
signal( self, "revoke_invite", invite_id, function ( result ) {
|
||||
if ( !result.invites ) return;
|
||||
|
@ -226,6 +223,13 @@ Editor.prototype.finish_init = function () {
|
|||
event.stop();
|
||||
} );
|
||||
}
|
||||
|
||||
var revoke_buttons = getElementsByTagAndClassName( "input", "revoke_button" );
|
||||
for ( var i in revoke_buttons ) {
|
||||
var revoke_button = revoke_buttons[ i ];
|
||||
var invite_id = revoke_button.id.split( "_" ).pop();
|
||||
connect_button( revoke_button, invite_id );
|
||||
}
|
||||
}
|
||||
} );
|
||||
|
||||
|
|
Reference in New Issue