Mention placeholders for repositories in documentation; fix #369 #371

fpoulain · 2020-11-18T19:00:49Z

fpoulain commented

2020-11-18 19:00:49 +00:00

No description provided.

witten referenced this pull request

2020-11-18 19:04:05 +00:00

Using placeholders in repositories #369

witten commented

2020-11-18 19:08:12 +00:00

This is great. Thank you for taking the time to make a PR.. And a test! My only request is that in the example in the repositories schema , you perhaps also include a repository name without any placeholders first. That way, users who don't know about or care about placeholders see a plain example in which they don't have to decipher {fqdn}, and users who do care about placeholders have an example that makes sense for them.

This is great. Thank you for taking the time to make a PR.. And a test! My only request is that in the example in the `repositories` schema , you perhaps also include a repository name *without* any placeholders first. That way, users who don't know about or care about placeholders see a plain example in which they don't have to decipher `{fqdn}`, and users who do care about placeholders have an example that makes sense for them.

fpoulain commented

2020-11-18 19:18:25 +00:00

Ok. Maybe with

example:
  - user@backupserver:sourcehostname.borg
  - "user@backupserver:/repos/{fqdn}"

Ok. Maybe with ``` example: - user@backupserver:sourcehostname.borg - "user@backupserver:/repos/{fqdn}" ```

witten commented

2020-11-18 19:19:01 +00:00

Yup, that'd be fine!

fpoulain commented

2020-11-18 19:23:52 +00:00

I force-pushed with that.

witten commented

2020-11-18 19:24:29 +00:00

Awesome, thank you!

witten merged commit e77757f0fd into master

2020-11-18 19:25:00 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#371