borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 1 Actions Packages Releases 121 Activity

Use values from BORG_* env variables if they are not specified in config.yaml #327

Merged
witten merged 1 commits from :master into master 2020-06-21 21:30:02 +00:00
Conversation 3 Commits 1 Files Changed 1 +2 -1
ralhei commented 2020-06-15 17:53:20 +00:00
Contributor
Copy Link

The rational behind this pull request is to allow the user to preset certain BORG_* environment variables and let borgmatic just pass them through to borg if they are not defined differently in the config.yaml file.

The rational behind this pull request is to allow the user to preset certain `BORG_*` environment variables and let borgmatic just pass them through to `borg` if they are not defined differently in the config.yaml file.
witten commented 2020-06-15 19:48:40 +00:00
Owner
Copy Link

Totally makes sense! Would you mind also updating tests to cover this change? The test file in question is tests/unit/borg/test_environment.py. I'm happy to help out with the tests if it's not clear.

Totally makes sense! Would you mind also updating tests to cover this change? The test file in question is `tests/unit/borg/test_environment.py`. I'm happy to help out with the tests if it's not clear.
witten commented 2020-06-21 21:28:11 +00:00
Owner
Copy Link

Since this is a fix for a fairly annoying regression, I'll go ahead and merge it and fix up the tests in master. Thanks for your contribution!

Since this is a fix for a fairly annoying regression, I'll go ahead and merge it and fix up the tests in master. Thanks for your contribution!
witten merged commit c8d5de2179 into master 2020-06-21 21:30:01 +00:00
witten commented 2020-06-23 18:27:39 +00:00
Owner
Copy Link

Released in borgmatic 1.5.7!

Released in borgmatic 1.5.7!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#327
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?