Limit argument range for --verbose, make default log level more explicit. #93
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#93
Loading…
Reference in New Issue
No description provided.
Delete Branch ":explicit_default_logging"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
See #92
Looks good. Thanks for the fix!
@ -92,6 +92,8 @@ def parse_arguments(*arguments):
parser.add_argument(
'-v', '--verbosity',
type=int,
choices=range(0,3),
At first I forgot that the end of
range()
is non-inclusive, and thought you were adding a new super-debug log level. But then I figured it out. :)@ -5,1 +4,3 @@
VERBOSITY_LOTS = 2
VERBOSITY_WARNING = 0
VERBOSITY_SOME = 1
VERBOSITY_LOTS = 2
Minor code style thing: I generally try to avoid manually lining up operators like this across lines with spacing. So I think I'd prefer this alterative if you don't mind:
I'm inspired by PEP-8 on this topic, by the way: https://www.python.org/dev/peps/pep-0008/#pet-peeves (scroll down to the last example in that section).
Ok, fixed the indention. I changed my commit and did a force push, so don't be surprised.
Cool, thank you!