Use XDG_CONFIG_HOME for user configuration directory, if set. #70

Closed
floli wants to merge 1 commits from (deleted):add_user_config into main
Collaborator

I decided against including python-xdg. The code is too trivial to warrant an additional dependency, imho.

I decided against including python-xdg. The code is too trivial to warrant an additional dependency, imho.
Owner

Thanks for doing this. A factoring thing though: The logic is getting just sufficiently complex that it'd be nice to do it within a function rather than at global scope. Besides just factoring, that has benefits like making it easier to write automated tests for the logic, which would also be nice in this case.

Note that I'm happy to do this if you want to hand it off.

Thanks for doing this. A factoring thing though: The logic is getting just sufficiently complex that it'd be nice to do it within a function rather than at global scope. Besides just factoring, that has benefits like making it easier to write automated tests for the logic, which would also be nice in this case. Note that I'm happy to do this if you want to hand it off.
Author
Collaborator

I would be grateful, if you would take this over. So I can also see and learn how you are intending to do it!

I would be grateful, if you would take this over. So I can also see and learn how you are intending to do it!
Owner

Sure thing! I took a stab at it here, starting from your changes: witten/borgmatic#71

Let me know your thoughts. Also, if you'd like to be listed in the AUTHORS file for any features you've worked on, let me know.

Sure thing! I took a stab at it here, starting from your changes: https://projects.torsion.org/witten/borgmatic/pulls/71 Let me know your thoughts. Also, if you'd like to be listed in the AUTHORS file for any features you've worked on, let me know.
witten closed this pull request 2018-06-20 05:37:10 +00:00
Owner

Any thoughts on the approach in witten/borgmatic#71? I'd like to either merge it or close it, given that it's falling behind master. Thanks!

Any thoughts on the approach in https://projects.torsion.org/witten/borgmatic/pulls/71? I'd like to either merge it or close it, given that it's falling behind master. Thanks!

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#70
No description provided.