Add default path for user configuration #66
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#66
Loading…
Reference in New Issue
No description provided.
Delete Branch ":add_user_config"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It would be even better to read out
XDG_CONFIG_HOME
and use that, but this would either introduce a dependency onpython-xdg
or add some more code (reading out environment variable return it or default value).What do you think about using
XDG_CONFIG_HOME
instead?See https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
This seems like a reasonable place to start. I don't have a problem reading an environment variable, and
python-xdg
looks pretty tiny without any major dependencies of its own. Do you have a sense of how commonlyXDG_CONFIG_HOME
is used, either on various Linux distros or by users?I'll merge this PR for now, but feel free to follow up with a ticket or PR for the
XDG
support.This has just been released as part of borgmatic 1.2.0!
Great!
Correctly implementing https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html requires some more effort than only reading the environement variable and providing a default, therefore I will likey follow up on that by a another pull request soon.
Not sure how commonly
XDG_CONFIG_HOME
is used, most people will just leave it at default, i.e. unset. It's certainly a good thing to support.