Support ruamel.yaml 0.17.x #404

New Issue

Closed

opened 2021-03-29 03:03:25 +00:00 by witten · 4 comments

witten commented 2021-03-29 03:03:25 +00:00

Owner

Copy Link

What I'm trying to do and why

borgmatic supports ruamel.yaml up to but not including 0.17.0 as a result of this in setup.py:

    install_requires=(
        ...
        'ruamel.yaml>0.15.0,<0.17.0',
        ...
    ),

However ruamel.yaml version 0.17.0 came out recently, and it would be good for borgmatic to support it.

So as part of this ticket, update the version range in setup.py, update test requirements as well, and confirm that borgmatic still works (and tests pass) with 0.17.0. Read through the ruamel.yaml changelog and make sure there no surprises.

Other notes / implementation ideas

Downstream issue on this: https://bugs.archlinux.org/task/70197

Environment

borgmatic version: master

#### What I'm trying to do and why borgmatic supports `ruamel.yaml` up to but not including `0.17.0` as a result of this in `setup.py`: ```python install_requires=( ... 'ruamel.yaml>0.15.0,<0.17.0', ... ), ``` However `ruamel.yaml` version `0.17.0` came out recently, and it would be good for borgmatic to support it. So as part of this ticket, update the version range in `setup.py`, update test requirements as well, and confirm that borgmatic still works (and tests pass) with `0.17.0`. Read through the `ruamel.yaml` changelog and make sure there no surprises. #### Other notes / implementation ideas Downstream issue on this: https://bugs.archlinux.org/task/70197 #### Environment **borgmatic version:** master

👍 1

csteinforth commented 2021-03-29 07:51:06 +00:00

Copy Link

Hi there,

had exactly this issue today. I solved this by downgrading the package python-ruamel-yaml to 0.16.13.

Regards,

Christoph

Hi there, had exactly this issue today. I solved this by downgrading the package `python-ruamel-yaml` to 0.16.13. Regards, Christoph

PopeRigby commented 2021-03-29 23:58:03 +00:00

Copy Link

Also having this issue on Arch Linux.

Also having this issue on Arch Linux.

witten commented 2021-03-30 22:55:50 +00:00

Author

Owner

Copy Link

Thanks for your patience here. I've just tested with ruamel.yaml 0.17.x and released borgmatic 1.5.13 with support for it!

Thanks for your patience here. I've just tested with ruamel.yaml 0.17.x and released borgmatic 1.5.13 with support for it!

👍 3 🎉 1

witten closed this issue 2021-03-30 22:55:55 +00:00

witten referenced this issue from a commit 2021-03-30 23:11:17 +00:00

Add support for ruamel.yaml 0.17.x YAML parsing library (#404).

csteinforth commented 2021-03-31 06:11:14 +00:00

Copy Link

New version of borgmatic just hit the arch repos. Thanks for your quick solution on this!

New version of `borgmatic` just hit the arch repos. Thanks for your quick solution on this!

👍 1

witten referenced this issue 2021-04-11 22:25:48 +00:00

python errors? #410

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#404

No description provided.