Support ruamel.yaml 0.17.x #404

Closed
opened 4 months ago by witten ยท 4 comments
witten commented 4 months ago
Owner

What I'm trying to do and why

borgmatic supports ruamel.yaml up to but not including 0.17.0 as a result of this in setup.py:

    install_requires=(
        ...
        'ruamel.yaml>0.15.0,<0.17.0',
        ...
    ),

However ruamel.yaml version 0.17.0 came out recently, and it would be good for borgmatic to support it.

So as part of this ticket, update the version range in setup.py, update test requirements as well, and confirm that borgmatic still works (and tests pass) with 0.17.0. Read through the ruamel.yaml changelog and make sure there no surprises.

Other notes / implementation ideas

Downstream issue on this: https://bugs.archlinux.org/task/70197

Environment

borgmatic version: master

#### What I'm trying to do and why borgmatic supports `ruamel.yaml` up to but not including `0.17.0` as a result of this in `setup.py`: ```python install_requires=( ... 'ruamel.yaml>0.15.0,<0.17.0', ... ), ``` However `ruamel.yaml` version `0.17.0` came out recently, and it would be good for borgmatic to support it. So as part of this ticket, update the version range in `setup.py`, update test requirements as well, and confirm that borgmatic still works (and tests pass) with `0.17.0`. Read through the `ruamel.yaml` changelog and make sure there no surprises. #### Other notes / implementation ideas Downstream issue on this: https://bugs.archlinux.org/task/70197 #### Environment **borgmatic version:** master

Hi there,

had exactly this issue today. I solved this by downgrading the package python-ruamel-yaml to 0.16.13.

Regards,

Christoph

Hi there, had exactly this issue today. I solved this by downgrading the package `python-ruamel-yaml` to 0.16.13. Regards, Christoph

Also having this issue on Arch Linux.

Also having this issue on Arch Linux.
Poster
Owner

Thanks for your patience here. I've just tested with ruamel.yaml 0.17.x and released borgmatic 1.5.13 with support for it!

Thanks for your patience here. I've just tested with ruamel.yaml 0.17.x and released borgmatic 1.5.13 with support for it!
witten closed this issue 4 months ago

New version of borgmatic just hit the arch repos. Thanks for your quick solution on this!

New version of `borgmatic` just hit the arch repos. Thanks for your quick solution on this!
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loadingโ€ฆ
There is no content yet.