Adjustments for Borg 1.2.0 #394

New Issue

Closed

opened 2021-02-26 11:07:04 +00:00 by bjo · 11 comments

bjo commented 2021-02-26 11:07:04 +00:00

Copy Link

Hi,
I think this issue https://github.com/borgbase/vorta/issues/238 also applies to borgmatic, as compact won't be done automatically any more with borg 1.2.0.

Hi, I think this issue https://github.com/borgbase/vorta/issues/238 also applies to borgmatic, as compact won't be done automatically any more with borg 1.2.0.

Ghost commented 2021-05-01 08:41:46 +00:00

Copy Link

while playing around with the 1.2 beta and using borgmatic in a venv for automated backups I was wondering if it - while adding adaptations for 1.2 and the new compaction behavior- would be feasible to add a passthrough mode to run verbatim borg commands on the reposiroties configured with borgmatic, making it possible to at least manually run some new borg features on each configured repo with borgmatic setting up the environment correctly each time (passphrases, data paths, ssh args etc). Like

/opt/borgmatic_venv/bin/borgmatic -c /etc/someconfig borg-run break-lock
or
/opt/borgmatic_venv/bin/borgmatic -c /etc/someconfig borg-run compact --cleanup-commits

(borg-run is the first thing I came up with)

The latter imrpving on the current situation with the compaction in borg 1.2, even if integration into the normal backup workflow would still be required I think.

while playing around with the 1.2 beta and using borgmatic in a venv for automated backups I was wondering if it - while adding adaptations for 1.2 and the new compaction behavior- would be feasible to add a passthrough mode to run verbatim borg commands on the reposiroties configured with borgmatic, making it possible to at least manually run some new borg features on each configured repo with borgmatic setting up the environment correctly each time (passphrases, data paths, ssh args etc). Like /opt/borgmatic_venv/bin/borgmatic -c /etc/someconfig borg-run break-lock or /opt/borgmatic_venv/bin/borgmatic -c /etc/someconfig borg-run compact --cleanup-commits (borg-run is the first thing I came up with) The latter imrpving on the current situation with the compaction in borg 1.2, even if integration into the normal backup workflow would still be required I think.

witten referenced this issue 2021-06-14 22:59:35 +00:00

Run arbitrary Borg commands #425

witten commented 2021-06-14 23:00:21 +00:00

Owner

Copy Link

@bjo: Thanks for bringing this to my attention! Fortunately in my delay to respond, Borg 1.2.0 hasn't been released quite yet...

@juliadin: That's an oft-mentioned feature request, although I don't know that anyone's actually filed it. So I've created a ticket for it here: #425. Feel free to follow along there.

@bjo: Thanks for bringing this to my attention! Fortunately in my delay to respond, Borg 1.2.0 hasn't been released quite yet... @juliadin: That's an oft-mentioned feature request, although I don't know that anyone's actually filed it. So I've created a ticket for it here: #425. Feel free to follow along there.

witten commented 2021-06-18 03:55:04 +00:00

Owner

Copy Link

#425 with the new borgmatic borg action has been released as part of borgmatic 1.5.15. Docs here: https://torsion.org/borgmatic/docs/how-to/run-arbitrary-borg-commands/

#425 with the new `borgmatic borg` action has been released as part of borgmatic 1.5.15. Docs here: https://torsion.org/borgmatic/docs/how-to/run-arbitrary-borg-commands/

bjo commented 2022-01-25 14:30:43 +00:00

Author

Copy Link

What's the status of compact? 1.2.0 is in beta meanwhile.

What's the status of `compact`? 1.2.0 is in [beta meanwhile](https://github.com/borgbackup/borg/releases/tag/1.2.0b4).

witten commented 2022-01-26 18:15:11 +00:00

Owner

Copy Link

There's no specific status—nobody is working on it that I'm aware of. But in the meantime, have you tried borgmatic borg compact?

There's no specific status—nobody is working on it that I'm aware of. But in the meantime, have you tried `borgmatic borg compact`?

witten commented 2022-02-07 05:20:12 +00:00

Owner

Copy Link

Some discussion on this topic here: https://www.reddit.com/r/BorgBackup/comments/slizrx/borg_120rc1_released/hvu75u5/

Some discussion on this topic here: https://www.reddit.com/r/BorgBackup/comments/slizrx/borg_120rc1_released/hvu75u5/

witten referenced this issue from a commit 2022-02-08 07:30:45 +00:00

Compact repository segments with new "borgmatic compact" action (#394).

witten referenced this issue from a commit 2022-02-08 17:35:27 +00:00

Fix some test failures (#394).

witten referenced this issue from a commit 2022-02-08 20:11:11 +00:00

Add tests for compact action (#394).

witten commented 2022-02-08 20:11:54 +00:00

Owner

Copy Link

A new borgmatic compact action is now implemented in master. It is not (yet) automatically invoked.

A new `borgmatic compact` action is now implemented in master. It is not (yet) automatically invoked.

witten commented 2022-02-09 01:08:37 +00:00

Owner

Copy Link

Anyone have thoughts on whether borgmatic compact should be run automatically (when no actions are specified)? I assume it should, since otherwise a repository with a Borg 1.2+ client will grow without bound. But I wanted to see if there were any arguments against, e.g. that running compact frequently will be slow.

Anyone have thoughts on whether `borgmatic compact` should be run automatically (when no actions are specified)? I assume it should, since otherwise a repository with a Borg 1.2+ client will grow without bound. But I wanted to see if there were any arguments against, e.g. that running `compact` frequently will be slow.

witten referenced this issue from a commit 2022-02-09 19:08:23 +00:00

Remove references to removed long-deprecated options (#394).

witten referenced this issue from a commit 2022-02-10 01:00:11 +00:00

Run "compact" action by default when no actions are specified (#394).

witten referenced this issue from a commit 2022-02-10 01:00:11 +00:00

When the "atime" option is used, tailor the flags passed to Borg depending on version (#394).

witten commented 2022-02-10 01:04:12 +00:00

Owner

Copy Link

I went ahead and integrated compact as a default action. The thinking is that prune won't "work" (actually free up space) without it, and so it would be in line with user expectations to compact whenever automatically running prune. However, if you run prune explicitly (rather than as a default action), you'll still need to compact on your own.

I went ahead and integrated `compact` as a default action. The thinking is that `prune` won't "work" (actually free up space) without it, and so it would be in line with user expectations to `compact` whenever automatically running `prune`. However, if you run `prune` explicitly (rather than as a default action), you'll still need to `compact` on your own.

👍 1

witten referenced this issue from a commit 2022-02-10 05:11:28 +00:00

When using the "bsd_flags" option, tailor the flags passed to Borg depending on the Borg version (#394).

witten referenced this issue from a commit 2022-02-10 17:51:34 +00:00

When using the "numeric_owner" option, tailor the flags passed to Borg depending on the Borg version (#394).

witten referenced this issue from a commit 2022-02-10 18:09:40 +00:00

When using the "numeric_owner" option with the "extract" action, tailor the flags passed to Borg depending on the Borg version (#394).

witten referenced this issue from a commit 2022-02-10 18:16:29 +00:00

When using the "remote_rate_limit" option, tailor the flags passed to Borg depending on the Borg version (#394).

witten commented 2022-02-10 18:24:26 +00:00

Owner

Copy Link

Implemented in master. Will be shipped as part of the next release. If there are any details I've missed, please post them here!

Implemented in master. Will be shipped as part of the next release. If there are any details I've missed, please post them here!

witten closed this issue 2022-02-10 18:24:27 +00:00

witten commented 2022-02-10 18:31:48 +00:00

Owner

Copy Link

This is now released as part of borgmatic 1.5.23.

This is now released as part of borgmatic 1.5.23.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#394

No description provided.