Convert of old INI-Configfile fails because of missing YAML Rendering #367

New Issue

Closed

opened 2020-11-14 11:56:19 +00:00 by 0nelight · 3 comments

0nelight commented 2020-11-14 11:56:19 +00:00

Copy Link

What I'm trying to do and why

I tried to convert an old INI-Config-File to the new YAML-Format but run into an Error that the file cannot be written because of the missing YAML Rendering.

Steps to reproduce

sudo upgrade-borgmatic-config -s ../borgmatic_config_files_old/backupconfig -d backupconfig.yaml

Actual behavior

sudo upgrade-borgmatic-config -s ../borgmatic_config_files_old/backupconfig -d backupconfig.yaml Traceback (most recent call last): File "/usr/local/bin/upgrade-borgmatic-config", line 8, in <module> sys.exit(main()) File "/usr/local/lib/python3.7/dist-packages/borgmatic/commands/convert_config.py", line 104, in main args.destination_config_filename, destination_config, mode=source_config_file_mode File "/usr/local/lib/python3.7/dist-packages/borgmatic/config/generate.py", line 128, in write_configuration config_file.write(rendered_config) TypeError: write() argument must be str, not CommentedMap

Other notes / implementation ideas

instead of this in /commands/convert_config.py:

destination_config = convert.convert_legacy_parsed_config(
	source_config, source_excludes, schema
	)

generate.write_configuration(
	args.destination_config_filename, destination_config, mode=source_config_file_mode
    )

this:

destination_config = convert.convert_legacy_parsed_config(
	source_config, source_excludes, schema
	)
 
destination_config = generate._render_configuration(destination_config)
 
generate.write_configuration(
	args.destination_config_filename, destination_config, mode=source_config_file_mode
    )

Environment

borgmatic version: 1.5.10

borgmatic installation method: pip

Borg version: 1.1.11

Python version: Python 3.7.3

operating system and version: Debian 10

#### What I'm trying to do and why I tried to convert an old INI-Config-File to the new YAML-Format but run into an Error that the file cannot be written because of the missing YAML Rendering. #### Steps to reproduce `sudo upgrade-borgmatic-config -s ../borgmatic_config_files_old/backupconfig -d backupconfig.yaml` #### Actual behavior `sudo upgrade-borgmatic-config -s ../borgmatic_config_files_old/backupconfig -d backupconfig.yaml Traceback (most recent call last): File "/usr/local/bin/upgrade-borgmatic-config", line 8, in <module> sys.exit(main()) File "/usr/local/lib/python3.7/dist-packages/borgmatic/commands/convert_config.py", line 104, in main args.destination_config_filename, destination_config, mode=source_config_file_mode File "/usr/local/lib/python3.7/dist-packages/borgmatic/config/generate.py", line 128, in write_configuration config_file.write(rendered_config) TypeError: write() argument must be str, not CommentedMap` #### Other notes / implementation ideas instead of this in [/commands/convert_config.py](https://projects.torsion.org/witten/borgmatic/src/commit/79bee755eed653c64a6a55a76b86695a10bb328f/borgmatic/commands/convert_config.py): ``` destination_config = convert.convert_legacy_parsed_config( source_config, source_excludes, schema ) generate.write_configuration( args.destination_config_filename, destination_config, mode=source_config_file_mode ) ``` this: ``` destination_config = convert.convert_legacy_parsed_config( source_config, source_excludes, schema ) destination_config = generate._render_configuration(destination_config) generate.write_configuration( args.destination_config_filename, destination_config, mode=source_config_file_mode ) ``` #### Environment **borgmatic version:** 1.5.10 **borgmatic installation method:** pip **Borg version:** 1.1.11 **Python version:** Python 3.7.3 **operating system and version:** Debian 10

0nelight closed this issue 2020-11-14 11:57:30 +00:00

0nelight reopened this issue 2020-11-14 11:58:00 +00:00

witten commented 2020-11-14 21:49:55 +00:00

Owner

Copy Link

Thank you so much for reporting this and tracking down the source of the problem! It looks like the write_configuration() function signature changed somewhere along the way, but convert_config.py wasn't ever updated to account for that. An integration test here would've been really useful.

Thank you so much for reporting this and tracking down the source of the problem! It looks like the `write_configuration()` function signature changed somewhere along the way, but `convert_config.py` wasn't ever updated to account for that. An integration test here would've been really useful.

witten added the

bug

label 2020-11-14 21:50:05 +00:00

witten referenced this issue from a commit 2020-11-18 23:01:37 +00:00

Fix traceback when upgrading old INI-style configuration with upgrade-borgmatic-config (#367).

witten commented 2020-11-18 23:02:23 +00:00

Owner

Copy Link

Fixed in master! Thanks again for reporting this.

Fixed in master! Thanks again for reporting this.

witten closed this issue 2020-11-18 23:02:24 +00:00

witten commented 2020-11-19 18:01:37 +00:00

Owner

Copy Link

Just released in borgmatic 1.5.11!

Just released in borgmatic 1.5.11!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#367

No description provided.