borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 2 Actions Packages Releases 121 Activity

Add before_extract and after_extract hooks #347

Merged
witten merged 3 commits from :master into master 2020-08-12 21:14:18 +00:00
Conversation 3 Commits 3 Files Changed 3 +43
networkjanitor commented 2020-08-01 14:15:46 +00:00
Contributor
Copy Link

adding before_extract and after_extract hooks based on #346

diverged from the original proposed naming of before_restore and after_restore to the actual command name, since there is a borgmatic restore command for restoring databases.

adding `before_extract` and `after_extract` hooks based on #346 diverged from the original proposed naming of `before_restore` and `after_restore` to the actual command name, since there is a `borgmatic restore` command for restoring databases.
witten reviewed 2020-08-12 21:05:47 +00:00
witten left a comment
Owner
Copy Link

Awesome, thanks for implementing this and adding a test! Looks great except for the very minor issue of the description strings. (See below.)

Awesome, thanks for implementing this and adding a test! Looks great except for the very minor issue of the description strings. (See below.)
borgmatic/commands/borgmatic.py Outdated
@ -94,0 +96,4 @@
hooks.get('before_extract'),
hooks.get('umask'),
config_filename,
'pre-check',
witten commented 2020-08-12 21:02:44 +00:00
Owner
Copy Link

This should be pre-extract.

This should be `pre-extract`.
borgmatic/commands/borgmatic.py Outdated
@ -168,0 +178,4 @@
hooks.get('after_extract'),
hooks.get('umask'),
config_filename,
'post-check',
witten commented 2020-08-12 21:03:03 +00:00
Owner
Copy Link

And post-extract.

And `post-extract`.
networkjanitor commented 2020-08-12 21:13:03 +00:00
Author
Contributor
Copy Link

changed them

changed them
👍 1
witten merged commit 93caeba200 into master 2020-08-12 21:14:16 +00:00
witten commented 2020-08-12 21:14:24 +00:00
Owner
Copy Link

Thanks!

Thanks!
witten commented 2020-08-21 21:34:29 +00:00
Owner
Copy Link

Just released in borgmatic 1.5.10!

Just released in borgmatic 1.5.10!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#347
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?