multiple source_directories broken since version 1.5.5 #333
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#333
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi,
From borgmatic version 1.5.5 borgmatic does not back up the secong folder.
/ is backed up, but /media/ssd is not backed up.
Version 1.5.4 worked as expected.
Thank you!
I have the following config file:
same problem with this config:
Yikes! Thank you for reporting this. I have an idea of what might be going on here: borgmatic 1.5.5 started de-duplicating source directories to prevent Borg from scanning the same source directories twice, which can cause hangs in certain cases. So for instance, source directories of
/foo
and/foo/bar
would get de-duplicated down to just/foo
.. because/foo
contains/foo/bar
, and therefore Borg will implicitly backup both.Something similiar is going on here:
/
contains/media/ssd
, and so borgmatic is de-duplicating that down to just/
. Now it sounds like that might be problematic because you haveone_file_system
set totrue
(a totally legitimate setting to have), and therefore Borg doesn't traverse from/
to/media/ssd
when scanning for files.I assume that your backup archives contained the contents of
/media/ssd
before borgmatic 1.5.5, and/media/ssd
is missing from archives afterwards? I'm just trying to understand howone_file_system
interacts with multiple Borg source directories. Thanks.Wow, fastest issue reply ever :) Thanks for that.
Yes, I confirm having /media/ssd in earlier backups.
If only the implementation of the fix could be so speedy! I'll have to think about what I can do here without regressing #316.
Okay, I've got an apparent fix in master. borgmatic now checks if two source directories are on the same filesystem before trying to de-duplicate them. If they're on different filesystems, as is the case with your first example, then borgmatic passes both of them to Borg.
Thanks again for bringing this to my attention. I'll add a note here when there's a release with this fix.
A question about this. Are
/media/xps2
and its sub-directories on the same filesystem? In any case, I would expect borgmatic 1.5.5/1.5.6 to de-duplicate them down to just/media/xps2
when passing them to Borg. But if they are all on the same filesystem, then Borg should implicitly backup both/media/xps2
and all of its sub-directories.Is that consistent with what you're seeing in the resulting archive? For instance, is
/media/xps2/Pictures
present there?Hey,
Thank you also for trying to fix this so quickly and also for this amazing wrapper :)
/media/xps2 = ext4 fs
/media/xps2/Pictures and /media/xps2/images = encfs mounts. So they should be considered different filesystems.
Once you have a release with this fix i can test both cases.
/media/xps2/Pictures is present but empty in the faulty backups.
Great, that sounds like that case should be handled!
I'll add a note here when the fix is released (hopefully soon!).
Released in borgmatic 1.5.7!