Use values from BORG_* env variables if they are not specified in config.yaml #327
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#327
Loading…
Reference in New Issue
No description provided.
Delete Branch ":master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The rational behind this pull request is to allow the user to preset certain
BORG_*
environment variables and let borgmatic just pass them through toborg
if they are not defined differently in the config.yaml file.Totally makes sense! Would you mind also updating tests to cover this change? The test file in question is
tests/unit/borg/test_environment.py
. I'm happy to help out with the tests if it's not clear.Since this is a fix for a fairly annoying regression, I'll go ahead and merge it and fix up the tests in master. Thanks for your contribution!
Released in borgmatic 1.5.7!