garbled --progress output #257
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#257
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
I'm trying to do an interactive backup to make sure my backups won't take too much space or pick up ridiculously large files.
Steps to reproduce (if a bug)
Setup this configuration in
/etc/borgmatic/config.yaml
, fairlynormal:
Note that I censored the repository path and removed commented out configuration.
Start borgmatic with
--progress
.Actual behavior (if a bug)
This is the output of the command:
Note the
A
lines: those mask the "progress" output, visible at thelast line because i hit "enter" while running the backup so that borg
would show it again. I believe this might because
borg
is called with--filter AME
, a flag that seems impossible to turn off from theuser's perspective.
Expected behavior (if a bug)
I would have expected the following output:
... ie. with a single line where processed files are shown.
Other notes / implementation ideas
I wonder if this is one of the flags that could be (by default!)
specified as one of the "arbitrary flags passed to borg" (in #235) and
that could then be overriden in the configuration...
In other words, if there are magic flags that are forcibly passed to borg by borgmatic, I would like to have a more generic way to change/disable those...
Environment
borgmatic version: 1.4.8
borgmatic installation method: debian package
Borg version: 1.1.9
Python version: 3.7.3
Database version (if applicable): N/A
operating system and version: Debian 10 "buster", with some
packages from unstable (namely borgmatic).
oh and thanks so much for your work on this project, i really appreciate your responsiveness! :) i can start using borgmatic now that 1.4.4 (1.4.8 actually) hit the Debian mirrors...
Glad to hear the project is (generally) working out for you, and is now more up-to-date in Debian! Thanks for reporting the issue.. I'll try to see if I can reproduce it. Perhaps
--filter AME
and--progress
are just incompatible from a user experience perspective?I would argue so, yes. Maybe it's just a matter of removing the
--filter
argument if--progress
is provided?Yup, that would certainly be one option.. assuming that actually solves it! I'll need to play around with some of the Borg flags.
I was able to reproduce this, even running Borg directly without borgmtaic. Looks like this is an underlying Borg issue. Related: https://github.com/borgbackup/borg/issues/476
Leaving out both
--list
and--filter
does work, but may in theory obscure some Borg file read errors because of the omission of'E' = regular file, an error happened while accessing/reading this file
. That's probably okay, given that it's not the default anyway.I'm inclined to make the fix here to omit
--list
and--filter
when--progress
is given as you suggested.Fixed / worked around in borgmatic 1.4.16, just released. Thanks again for reporting this!
awesome work, thanks!