support lower verbosity #236

New Issue

Closed

opened 2019-11-02 19:53:41 +00:00 by palto42 · 4 comments

palto42 commented 2019-11-02 19:53:41 +00:00

Contributor

Copy Link

What I'm trying to do and why

I would like to restrict the console output to ERROR level if borgmatic is used in cron.

Currently the lowest verbosity 0 translates to the logging level WARNING which causes the --stats option to be displayed on all log outputs (console and syslog/logfile).

If the console level could be set to ERROR and syslog uses default 0=WARNING, then the --stats option would only add the statistics to syslog. Errors and critical messages would still show on the console as well (and trigger an email in cron).

Implementation idea

Add support for the verbosity -1 and map it to logging level ERROR.

Although negative verbosity might look strange, it would be consistent with current behavior and is backwards compatible.

#### What I'm trying to do and why I would like to restrict the console output to ERROR level if borgmatic is used in cron. Currently the lowest verbosity 0 translates to the logging level WARNING which causes the `--stats` option to be displayed on all log outputs (console and syslog/logfile). If the console level could be set to ERROR and syslog uses default 0=WARNING, then the `--stats` option would only add the statistics to syslog. Errors and critical messages would still show on the console as well (and trigger an email in cron). #### Implementation idea Add support for the verbosity **-1** and map it to logging level ERROR. Although negative verbosity might look strange, it would be consistent with current behavior and is backwards compatible.

witten commented 2019-11-02 20:06:26 +00:00

Owner

Copy Link

That makes sense to me. It's similar in spirit to curl --silent or the --quiet flag of various programs. Sounds like it'd be pretty straight-forward to implement too. Are you interested in taking a crack at it?

That makes sense to me. It's similar in spirit to `curl --silent` or the `--quiet` flag of various programs. Sounds like it'd be pretty straight-forward to implement too. Are you interested in taking a crack at it?

palto42 commented 2019-11-03 08:28:39 +00:00

Author

Contributor

Copy Link

New PR #237 for this feature.

Was not sure how should the help text describe the level -1, used option 1 in PR.

1. Display verbose progress to the console (from none to lots: 0, 1, or 2) or only errors (-1)
2. Display verbose progress to the console (from error-only to lots: -1, 0, 1, or 2)

Looking at the latest code I found that you defined the default log-file-verbosity as 1 instead of 0 like for the others. To me this looks inconsistent and I would prefer to align it with the other 2 cases as default 0.

New PR #237 for this feature. Was not sure how should the help text describe the level -1, used option 1 in PR. 1. `Display verbose progress to the console (from none to lots: 0, 1, or 2) or only errors (-1)` 2. `Display verbose progress to the console (from error-only to lots: -1, 0, 1, or 2)` Looking at the latest code I found that you defined the default `log-file-verbosity` as 1 instead of 0 like for the others. To me this looks inconsistent and I would prefer to align it with the other 2 cases as default 0.

witten commented 2019-11-03 22:21:45 +00:00

Owner

Copy Link

Thanks, I will check out the PR when I get a chance!

Was not sure how should the help text describe the level -1, used option 1 in PR.

Seems reasonable.

Looking at the latest code I found that you defined the default log-file-verbosity as 1 instead of 0 like for the others. To me this looks inconsistent and I would prefer to align it with the other 2 cases as default 0.

My rationale for making it inconsistent at 1 was as follows: When logging to syslog, which is implicit, you might not want it to always spew info logs there. So the default is 0. But when logging to a file with --log-file, you're explicitly requesting that logs go to the file. And so it might be unexpected to a user to specify an explicit --log-file and then see no logs show up there (except warnings/errors)! In fact, the first few times I used --log-file, I said to myself: Is this even working? The file is zero bytes.

Having said all that, I don't feel strongly about it, so feel free to make it consistent if you like! After all, you are the primary user of the --log-file flag at this moment in time.

Thanks, I will check out the PR when I get a chance! > Was not sure how should the help text describe the level -1, used option 1 in PR. Seems reasonable. > Looking at the latest code I found that you defined the default log-file-verbosity as 1 instead of 0 like for the others. To me this looks inconsistent and I would prefer to align it with the other 2 cases as default 0. My rationale for making it inconsistent at 1 was as follows: When logging to syslog, which is implicit, you might not want it to always spew info logs there. So the default is 0. But when logging to a file with `--log-file`, you're explicitly requesting that logs go to the file. And so it might be unexpected to a user to specify an explicit `--log-file` and then see no logs show up there (except warnings/errors)! In fact, the first few times I used `--log-file`, I said to myself: Is this even working? The file is zero bytes. Having said all that, I don't feel strongly about it, so feel free to make it consistent if you like! After all, you are the primary user of the `--log-file` flag at this moment in time.

witten referenced this issue from a commit 2019-11-04 01:02:14 +00:00

Verbosity level "-1" for even quieter output: Errors only (#236).

witten commented 2019-11-04 01:06:46 +00:00

Owner

Copy Link

Just released in borgmatic 1.4.6. Nice work!

Just released in borgmatic 1.4.6. Nice work!

witten closed this issue 2019-11-04 01:06:46 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#236

No description provided.