check --only extract broken #217

New Issue

Closed

opened 2019-09-19 22:15:03 +00:00 by witten · 1 comment

witten commented 2019-09-19 22:15:03 +00:00

Owner

Copy Link

What I'm trying to do and why

I don't have a concrete use case other than testing the new check --only feature. But one use case I could imagine is running the slow extract consistency check from an infrequent cron job, separate from the regular consistency checks.

Steps to reproduce

Run the following:

borgmatic -c test.yaml -v 2 check --only extract

Actual behavior

# borgmatic -c test.yaml -v 2 check --only extract
usage: borgmatic extract [--repository REPOSITORY] --archive ARCHIVE
                         [--restore-path RESTORE_PATHS [RESTORE_PATHS ...]]
                         [--progress] [-h]
borgmatic extract: error: the following arguments are required: --archive
Error parsing arguments: /root/.local/bin/borgmatic -c test.yaml -v 2 check --only extract

Expected behavior

Run the borgmatic "extract" consistency check instead of erroring.

Other notes / implementation ideas

I think what's going on here is the argument parsing is getting confusing, thinking that we're trying to invoke the separate "extract" sub-command.

Environment

borgmatic version: 1.3.16

borgmatic installation method: pip install --user as root

Borg version: 1.1.10

Python version: 3.7.4

operating system and version: Manjaro stable

#### What I'm trying to do and why I don't have a concrete use case other than testing the new `check --only` feature. But one use case I could imagine is running the slow extract consistency check from an infrequent cron job, separate from the regular consistency checks. #### Steps to reproduce Run the following: ``` borgmatic -c test.yaml -v 2 check --only extract ``` #### Actual behavior ``` # borgmatic -c test.yaml -v 2 check --only extract usage: borgmatic extract [--repository REPOSITORY] --archive ARCHIVE [--restore-path RESTORE_PATHS [RESTORE_PATHS ...]] [--progress] [-h] borgmatic extract: error: the following arguments are required: --archive Error parsing arguments: /root/.local/bin/borgmatic -c test.yaml -v 2 check --only extract ``` #### Expected behavior Run the borgmatic "extract" consistency check instead of erroring. #### Other notes / implementation ideas I think what's going on here is the argument parsing is getting confusing, thinking that we're trying to invoke the separate "extract" sub-command. #### Environment **borgmatic version:** 1.3.16 **borgmatic installation method:** `pip install --user` as root **Borg version:** 1.1.10 **Python version:** 3.7.4 **operating system and version:** Manjaro stable

witten added the

bug

label 2019-09-19 22:15:08 +00:00

witten referenced this issue from a commit 2019-09-20 18:45:07 +00:00

Fix error with "borgmatic check --only" command-line flag with "extract" consistency check (#217).

witten commented 2019-09-20 18:48:14 +00:00

Author

Owner

Copy Link

Okay, this is fixed and released (borgmatic 1.3.17). Required a fair amount of refactoring of the argument parsing so that different subparsers don't try to consume each others arguments erroneously.. when the value consumed by one subparser (extract in check --only extract) happens to match the name of another subparser (extract)!

Okay, this is fixed and released (borgmatic 1.3.17). Required a fair amount of refactoring of the argument parsing so that different subparsers don't try to consume each others arguments erroneously.. when the value consumed by one subparser (`extract` in `check --only extract`) happens to match the name of another subparser (`extract`)!

witten closed this issue 2019-09-20 18:48:14 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#217

No description provided.