#209 Suggestion: config option to automatically accept Borg warning of repository location change

Closed
opened 3 weeks ago by adatum · 4 comments
adatum commented 3 weeks ago

Currently if the repository location changes, Borg issues a warning which requires a y/N response. The part of the warning containing the prompt is not visible when using borgmatic.

It would be good to:

  • have prompts visible so that the user can respond, and/or preferably
  • add a config option to automatically respond “y” to the Borg warning, via the BORG_RELOCATED_REPO_ACCESS_IS_OK Borg environment variable (see the automatic “answerers” section).
Currently if the repository location changes, Borg issues a warning which requires a y/N response. The part of the warning containing the prompt is not visible when using borgmatic. It would be good to: * have prompts visible so that the user can respond, and/or preferably * add a config option to automatically respond "y" to the Borg warning, via the BORG_RELOCATED_REPO_ACCESS_IS_OK [Borg environment variable](https://borgbackup.readthedocs.io/en/stable/usage/general.html#environment-variables) (see the automatic "answerers" section).
witten commented 2 weeks ago
Owner

Thank you for suggesting this! Just implemented in master. Now, instead of borgmatic hanging while Borg prompts for input, it defaults to setting BORG_RELOCATED_REPO_ACCESS_IS_OK=no when invoking Borg. And you can override this with a new boolean configuration file option in borgmatic’s storage section: relocated_repo_access_is_ok.

I’ll comment here when this makes its way into a borgmatic release.

Thank you for suggesting this! Just implemented in master. Now, instead of borgmatic hanging while Borg prompts for input, it defaults to setting `BORG_RELOCATED_REPO_ACCESS_IS_OK=no` when invoking Borg. And you can override this with a new boolean configuration file option in borgmatic's `storage` section: `relocated_repo_access_is_ok`. I'll comment here when this makes its way into a borgmatic release.
adatum commented 2 weeks ago
Poster

Thanks! Given the automated nature of borgmatic, I think this config option makes sense.

Note that borgmatic does not hang. The prompt asking for a y/N response simply is not displayed at the moment the prompt is asked. “y” + Enter still functions, and then reveals the prompt. Similarly, the prompt is revealed after hitting Ctrl+C when borgmatic “hangs”.

Thanks! Given the automated nature of borgmatic, I think this config option makes sense. Note that borgmatic does not hang. The prompt asking for a y/N response simply is not displayed at the moment the prompt is asked. "y" + Enter still functions, and then reveals the prompt. Similarly, the prompt is revealed after hitting Ctrl+C when borgmatic "hangs".
witten commented 2 weeks ago
Owner

Got it, thanks for the explanation. Still pretty unexpected behavior from a user’s perspective though! The new version will instead simply default to a N response so there are no hidden prompts.

Got it, thanks for the explanation. Still pretty unexpected behavior from a user's perspective though! The new version will instead simply default to a `N` response so there are no hidden prompts.
witten commented 3 days ago
Owner

And now released as part of borgmatic 1.3.15!

And now released as part of borgmatic 1.3.15!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.